All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tariq Toukan <tariqt@mellanox.com>
To: Jakub Kicinski <kuba@kernel.org>, Saeed Mahameed <saeedm@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, Tariq Toukan <tariqt@mellanox.com>,
	Boris Pismenny <borisp@mellanox.com>
Subject: Re: [net 8/8] net/mlx5e: kTLS, Add resiliency to zero-size record frags in TX resync flow
Date: Thu, 30 Apr 2020 11:22:29 +0300	[thread overview]
Message-ID: <00f2e766-a6eb-ce51-a787-ae9ab504dda6@mellanox.com> (raw)
In-Reply-To: <20200429171238.3f3a552a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>



On 4/30/2020 3:12 AM, Jakub Kicinski wrote:
> On Wed, 29 Apr 2020 15:54:49 -0700 Saeed Mahameed wrote:
>> From: Tariq Toukan <tariqt@mellanox.com>
>>
>> SKBs of TLS records might have empty zero-sized frags.
> 
> Why? Let's fix that instead of adding checks to drivers.
> 

Hi Jakub,

The HW spec requires the DUMP size to be non-zero, this patch comes to 
guarantee this in driver.
In kernel stack, having zero-side fragments is for sure non-optimal 
practice, but still could be considered valid and tolerated.
I agree that we should find the source of this practice in stack and 
enhance it.

Thanks,
Tariq

>> Posting a DUMP WQE for such frag would result an error completion.
>> Add in-driver resiliency and skip such frags.
>>
>> Fixes: d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload support")

  reply	other threads:[~2020-04-30  8:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 22:54 [pull request][net 0/8] Mellanox, mlx5 fixes 2020-04-29 Saeed Mahameed
2020-04-29 22:54 ` [net 1/8] net/mlx5: E-switch, Fix error unwinding flow for steering init failure Saeed Mahameed
2020-04-29 22:54 ` [net 2/8] net/mlx5: E-switch, Fix printing wrong error value Saeed Mahameed
2020-04-29 22:54 ` [net 3/8] net/mlx5: E-switch, Fix mutex init order Saeed Mahameed
2020-04-29 22:54 ` [net 4/8] net/mlx5: DR, On creation set CQ's arm_db member to right value Saeed Mahameed
2020-04-29 22:54 ` [net 5/8] net/mlx5: Fix forced completion access non initialized command entry Saeed Mahameed
2020-04-29 22:54 ` [net 6/8] net/mlx5: Fix command entry leak in Internal Error State Saeed Mahameed
2020-04-29 22:54 ` [net 7/8] net/mlx5e: Fix q counters on uplink representors Saeed Mahameed
2020-04-29 22:54 ` [net 8/8] net/mlx5e: kTLS, Add resiliency to zero-size record frags in TX resync flow Saeed Mahameed
2020-04-30  0:12   ` Jakub Kicinski
2020-04-30  8:22     ` Tariq Toukan [this message]
2020-04-30 15:37       ` Saeed Mahameed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00f2e766-a6eb-ce51-a787-ae9ab504dda6@mellanox.com \
    --to=tariqt@mellanox.com \
    --cc=borisp@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.