From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1264C432C3 for ; Tue, 19 Nov 2019 09:26:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B616622317 for ; Tue, 19 Nov 2019 09:26:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="VFscHZrp"; dkim=pass (1024-bit key) header.d=amazonses.com header.i=@amazonses.com header.b="HArAs762" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727334AbfKSJ00 (ORCPT ); Tue, 19 Nov 2019 04:26:26 -0500 Received: from a27-55.smtp-out.us-west-2.amazonses.com ([54.240.27.55]:53238 "EHLO a27-55.smtp-out.us-west-2.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725280AbfKSJ0Z (ORCPT ); Tue, 19 Nov 2019 04:26:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zsmsymrwgfyinv5wlfyidntwsjeeldzt; d=codeaurora.org; t=1574155584; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=04R5mjBFNb6yF5rldK/xnzdcVfFmrZckYZJnZOL4I8M=; b=VFscHZrpNwIeGbpbsZKLBQTe0zGIQKk2Xiolfc/Y6I+av3WvqffYDuU/9unKQmu7 m/E8OyWb1XIOaKfUu21yy+iB77JoXLnYLB4x3rIEUdMSwDbgVDqm5eN+pDJ4L3fpZcc ykxESjxJMLMtD/RHNzbh/KAt+lrH4qFtjtbvga9I= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx; d=amazonses.com; t=1574155584; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Feedback-ID; bh=04R5mjBFNb6yF5rldK/xnzdcVfFmrZckYZJnZOL4I8M=; b=HArAs762PzXwUsah1KKvXDOE9OUFf6Fz7XfSXFEFgL/0uwIZjpKVeF6YnrB26rVX Jd/a4Kbf/myr+DK96mD6KZq+RRB4NUJch0Ild6uDwPY2d9NBfN1JPUA2eaHX8urbEuS giMr7Hb1Wi/NeoF1WRIrfFOzexqrEKoEIKFuSQCo= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9D526C447A2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Pieter-Paul Giesberts , Winnie Chang , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , stable@vger.kernel.org Subject: Re: [PATCH FIX] brcmfmac: disable PCIe interrupts before bus reset In-Reply-To: <20191118115308.21963-1-zajec5@gmail.com> (=?utf-8?Q?=22Rafa?= =?utf-8?Q?=C5=82_Mi=C5=82ecki=22's?= message of "Mon, 18 Nov 2019 12:53:08 +0100") References: <20191118115308.21963-1-zajec5@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) Date: Tue, 19 Nov 2019 09:26:24 +0000 Message-ID: <0101016e82fc042b-a255d0f0-84e9-4c33-8512-4a3da77d6520-000000@us-west-2.amazonses.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SES-Outgoing: 2019.11.19-54.240.27.55 Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Rafa=C5=82 Mi=C5=82ecki writes: > From: Rafa=C5=82 Mi=C5=82ecki > > Keeping interrupts on could result in brcmfmac freeing some resources > and then IRQ handlers trying to use them. That was obviously a straight > path for crashing a kernel. > > Example: > CPU0 CPU1 > ---- ---- > brcmf_pcie_reset > brcmf_pcie_bus_console_read > brcmf_detach > ... > brcmf_fweh_detach > brcmf_proto_detach > brcmf_pcie_isr_thread > ... > brcmf_proto_msgbuf_rx_trigger > ... > drvr->proto->pd > brcmf_pcie_release_irq > > [ 363.789218] Unable to handle kernel NULL pointer dereference at virtua= l address 00000038 > [ 363.797339] pgd =3D c0004000 > [ 363.800050] [00000038] *pgd=3D00000000 > [ 363.803635] Internal error: Oops: 17 [#1] SMP ARM > (...) > [ 364.029209] Backtrace: > [ 364.031725] [] (brcmf_proto_msgbuf_rx_trigger [brcmfmac]) fr= om [] (brcmf_pcie_isr_thread+0x228/0x274 [brcmfmac]) > [ 364.043662] r7:00000001 r6:c8ca0000 r5:00010000 r4:c7b4f800 > > Fixes: 4684997d9eea ("brcmfmac: reset PCIe bus on a firmware crash") > Cc: stable@vger.kernel.org # v5.2+ > Signed-off-by: Rafa=C5=82 Mi=C5=82ecki > --- > Kalle: if you are planning another pull request for 5.4 you may push > this to the wireless-drivers. Otherwise make it > wireless-drivers-next and lets have stable maintainers pick it. Unless the sky falls down I'm not planning to submit anything for v5.4 anymore. So this has to go to -next. --=20 Kalle Valo