From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 19 Nov 2019 12:29:31 +0000 From: sibis@codeaurora.org Subject: Re: [PATCH 14/16] arm64: dts: qcom: msm8998: Add ADSP, MPSS and SLPI nodes In-Reply-To: References: <20191118214250.14002-1-sibis@codeaurora.org> <0101016e807934fa-4da223fb-1854-4a1e-a8ee-e088129c4812-000000@us-west-2.amazonses.com> Message-ID: <0101016e83a3aae0-2f25d2f3-6014-4992-9b40-d8716962215b-000000@us-west-2.amazonses.com> Sender: linux-arm-msm-owner@vger.kernel.org To: Jeffrey Hugo Cc: Bjorn Andersson , Jeffrey Hugo , Rob Herring , Jonathan Marek , Ohad Ben-Cohen , Mark Rutland , p.zabel@pengutronix.de, MSM , linux-remoteproc@vger.kernel.org, DTML , lkml , Andy Gross List-ID: On 2019-11-19 03:37, Jeffrey Hugo wrote: > On Mon, Nov 18, 2019 at 2:45 PM Sibi Sankar > wrote: >> >> This patch adds ADSP, MPSS and SLPI nodes for MSM8998 SoCs. >> >> Signed-off-by: Sibi Sankar >> --- >> arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 8 ++ >> arch/arm64/boot/dts/qcom/msm8998.dtsi | 122 >> ++++++++++++++++++++++ >> 2 files changed, 130 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi >> b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi >> index 5f101a20a20a2..29e0c2e988e4b 100644 >> --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi >> +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi >> @@ -23,6 +23,14 @@ >> }; >> }; >> >> +&adsp_pas { >> + status = "okay"; >> +}; >> + >> +&slpi_pas { > > "b" comes before "s", no? will re-order it in the next re-spin. > >> + status = "okay"; >> +}; >> + >> &blsp1_uart3 { >> status = "okay"; >> >> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi >> b/arch/arm64/boot/dts/qcom/msm8998.dtsi >> index 707673e3cf28a..dd1dc35e87b63 100644 >> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi >> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi >> @@ -337,6 +337,73 @@ >> }; >> }; >> >> + adsp_pas: remoteproc-adsp { >> + compatible = "qcom,msm8998-adsp-pas"; >> + >> + interrupts-extended = <&intc GIC_SPI 162 >> IRQ_TYPE_EDGE_RISING>, >> + <&adsp_smp2p_in 0 >> IRQ_TYPE_EDGE_RISING>, >> + <&adsp_smp2p_in 1 >> IRQ_TYPE_EDGE_RISING>, >> + <&adsp_smp2p_in 2 >> IRQ_TYPE_EDGE_RISING>, >> + <&adsp_smp2p_in 3 >> IRQ_TYPE_EDGE_RISING>; >> + interrupt-names = "wdog", "fatal", "ready", >> + "handover", "stop-ack"; >> + >> + clocks = <&xo>; >> + clock-names = "xo"; >> + >> + memory-region = <&adsp_mem>; >> + >> + qcom,smem-states = <&adsp_smp2p_out 0>; >> + qcom,smem-state-names = "stop"; >> + >> + power-domains = <&rpmpd MSM8998_VDDCX>; >> + power-domain-names = "cx"; >> + >> + status = "disabled"; >> + >> + glink-edge { >> + interrupts = > IRQ_TYPE_EDGE_RISING>; >> + label = "lpass"; >> + qcom,remote-pid = <2>; >> + mboxes = <&apcs_glb 9>; >> + }; >> + }; >> + >> + slpi_pas: remoteproc-slpi { >> + compatible = "qcom,msm8998-slpi-pas"; >> + >> + interrupts-extended = <&intc GIC_SPI 390 >> IRQ_TYPE_EDGE_RISING>, >> + <&slpi_smp2p_in 0 >> IRQ_TYPE_EDGE_RISING>, >> + <&slpi_smp2p_in 1 >> IRQ_TYPE_EDGE_RISING>, >> + <&slpi_smp2p_in 2 >> IRQ_TYPE_EDGE_RISING>, >> + <&slpi_smp2p_in 3 >> IRQ_TYPE_EDGE_RISING>; >> + interrupt-names = "wdog", "fatal", "ready", >> + "handover", "stop-ack"; >> + >> + px-supply = <&vreg_lvs2a_1p8>; >> + >> + clocks = <&xo>, >> + <&rpmcc RPM_SMD_AGGR2_NOC_CLK>; >> + clock-names = "xo", "aggre2"; >> + >> + memory-region = <&slpi_mem>; >> + >> + qcom,smem-states = <&slpi_smp2p_out 0>; >> + qcom,smem-state-names = "stop"; >> + >> + power-domains = <&rpmpd MSM8998_SSCCX>; >> + power-domain-names = "ssc_cx"; >> + >> + status = "disabled"; >> + >> + glink-edge { >> + interrupts = > IRQ_TYPE_EDGE_RISING>; >> + label = "dsps"; >> + qcom,remote-pid = <3>; >> + mboxes = <&apcs_glb 27>; >> + }; >> + }; >> + >> tcsr_mutex: hwlock { >> compatible = "qcom,tcsr-mutex"; >> syscon = <&tcsr_mutex_regs 0 0x1000>; >> @@ -1048,6 +1115,61 @@ >> #interrupt-cells = <0x2>; >> }; >> >> + mss_pil: remoteproc@4080000 { >> + compatible = "qcom,msm8998-mss-pil"; >> + reg = <0x04080000 0x100>, <0x04180000 0x20>; >> + reg-names = "qdsp6", "rmb"; >> + >> + interrupts-extended = >> + <&intc GIC_SPI 448 >> IRQ_TYPE_EDGE_RISING>, >> + <&modem_smp2p_in 0 >> IRQ_TYPE_EDGE_RISING>, >> + <&modem_smp2p_in 1 >> IRQ_TYPE_EDGE_RISING>, >> + <&modem_smp2p_in 2 >> IRQ_TYPE_EDGE_RISING>, >> + <&modem_smp2p_in 3 >> IRQ_TYPE_EDGE_RISING>, >> + <&modem_smp2p_in 7 >> IRQ_TYPE_EDGE_RISING>; >> + interrupt-names = "wdog", "fatal", "ready", >> + "handover", "stop-ack", >> + "shutdown-ack"; >> + >> + clocks = <&xo>, >> + <&gcc GCC_MSS_CFG_AHB_CLK>, >> + <&gcc GCC_BIMC_MSS_Q6_AXI_CLK>, >> + <&gcc GCC_BOOT_ROM_AHB_CLK>, >> + <&gcc GCC_MSS_GPLL0_DIV_CLK_SRC>, >> + <&gcc GCC_MSS_SNOC_AXI_CLK>, >> + <&gcc GCC_MSS_MNOC_BIMC_AXI_CLK>, >> + <&rpmcc RPM_SMD_QDSS_CLK>; >> + clock-names = "xo", "iface", "bus", "mem", >> "gpll0_mss", >> + "snoc_axi", "mnoc_axi", "qdss"; >> + >> + qcom,smem-states = <&modem_smp2p_out 0>; >> + qcom,smem-state-names = "stop"; >> + >> + resets = <&gcc GCC_MSS_RESTART>; >> + reset-names = "mss_restart"; >> + >> + qcom,halt-regs = <&tcsr_mutex_regs 0x23000 >> 0x25000 0x24000>; >> + >> + power-domains = <&rpmpd MSM8998_VDDCX>, >> + <&rpmpd MSM8998_VDDMX>; >> + power-domain-names = "cx", "mx"; >> + >> + mba { >> + memory-region = <&mba_mem>; >> + }; >> + >> + mpss { >> + memory-region = <&mpss_mem>; >> + }; >> + >> + glink-edge { >> + interrupts = > IRQ_TYPE_EDGE_RISING>; >> + label = "modem"; >> + qcom,remote-pid = <1>; >> + mboxes = <&apcs_glb 15>; >> + }; >> + }; >> + >> stm: stm@6002000 { >> compatible = "arm,coresight-stm", >> "arm,primecell"; >> reg = <0x06002000 0x1000>, >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora >> Forum, >> a Linux Foundation Collaborative Project >>