From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF11BC432C3 for ; Mon, 25 Nov 2019 12:11:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C6F5820674 for ; Mon, 25 Nov 2019 12:11:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="mLjUl6Gx"; dkim=pass (1024-bit key) header.d=amazonses.com header.i=@amazonses.com header.b="EElOjMlB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727150AbfKYMLM (ORCPT ); Mon, 25 Nov 2019 07:11:12 -0500 Received: from a27-185.smtp-out.us-west-2.amazonses.com ([54.240.27.185]:55104 "EHLO a27-185.smtp-out.us-west-2.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725828AbfKYMLM (ORCPT ); Mon, 25 Nov 2019 07:11:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zsmsymrwgfyinv5wlfyidntwsjeeldzt; d=codeaurora.org; t=1574683870; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:MIME-Version:Content-Type; bh=WA8L41etKerEMPhjYhfgg3Lt6XxJcn9BfYkWy5icFe8=; b=mLjUl6GxoW/wRN3ZqrC367pGr9y4jV9HigYWQU2sW625FJKw1J04bx38dNjo6q6N BtbL/k4zi3ig+003k7BwJKgWDqiMRrxyxNvFV+XVK8hl8ITF0TEwQYMfhJJagtcXl2T 58NcuxSYtw5o/f1iXPlFSHtpJFPPrJvYqx+f98jA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx; d=amazonses.com; t=1574683870; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:MIME-Version:Content-Type:Feedback-ID; bh=WA8L41etKerEMPhjYhfgg3Lt6XxJcn9BfYkWy5icFe8=; b=EElOjMlBWBaXPq9Do5BLtt7WQftCI8aw9rjLMpDv/SQIOf/9CVqKPTH6jCUBhrfe cn6O+afjP7F597M4F3a5amFKnlhOYvq5JMhe06b232uhb3e40Q0N26+Q1ZR6/5yGy0X sYEX2/JekMlolXHqhhN9ACz0zk2GSZmYR4/uA/Qw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0ECF5C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Paolo Abeni Cc: Johannes Berg , Alexander Lobakin , Edward Cree , Nicholas Johnson , David Miller , jiri@mellanox.com, edumazet@google.com, idosch@mellanox.com, petrm@mellanox.com, sd@queasysnail.net, f.fainelli@gmail.com, jaswinder.singh@linaro.org, ilias.apalodimas@linaro.org, linux-kernel@vger.kernel.org, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, linuxwifi@intel.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v2 net-next] net: core: use listified Rx for GRO_NORMAL in napi_gro_receive() References: <20191014080033.12407-1-alobakin@dlink.ru> <20191015.181649.949805234862708186.davem@davemloft.net> <7e68da00d7c129a8ce290229743beb3d@dlink.ru> <746f768684f266e5a5db1faf8314cd77@dlink.ru> <3147bff57d58fce651fe2d3ca53983be@dlink.ru> <414288fcac2ba4fcee48a63bdbf28f7b9a5037c6.camel@sipsolutions.net> Date: Mon, 25 Nov 2019 12:11:10 +0000 In-Reply-To: (Paolo Abeni's message of "Mon, 25 Nov 2019 12:42:44 +0100") Message-ID: <0101016ea2790643-5f91d22f-e322-497e-8c58-34f5942bd2af-000000@us-west-2.amazonses.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SES-Outgoing: 2019.11.25-54.240.27.185 Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Paolo Abeni writes: > On Mon, 2019-11-25 at 12:05 +0100, Johannes Berg wrote: >> On Mon, 2019-11-25 at 13:58 +0300, Alexander Lobakin wrote: >> >> > Agree. I mean, we _can_ handle this particular problem from networking >> > core side, but from my point of view only rethinking driver's logic is >> > the correct way to solve this and other issues that may potentionally >> > appear in future. >> >> Do tell what you think it should be doing :) >> >> One additional wrinkle is that we have firmware notifications, command >> completions and actual RX interleaved, so I think we do want to have >> interrupts for the notifications and command completions? > > I think it would be nice moving the iwlwifi driver to full/plain NAPI > mode. The interrupt handler could keep processing extra work as it does > now and queue real pkts on some internal queue, and than schedule the > relevant napi, which in turn could process such queue in the napi poll > method. Likely I missed tons of details and/or oversimplified it... Sorry for hijacking the thread, but I have a patch pending for ath10k (another wireless driver) which adds NAPI support to SDIO devices: https://patchwork.kernel.org/patch/11188393/ I think it does just what you suggested, but I'm no NAPI expert and would appreciate if someone more knowledgeable could take a look :) -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches