All of lore.kernel.org
 help / color / mirror / Atom feed
From: akolli@codeaurora.org
To: Kalle Valo <kvalo@codeaurora.org>
Cc: ath11k@lists.infradead.org, devicetree@vger.kernel.org,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH v6 2/3] ath11k: copy ce service configs to hw_params
Date: Mon, 7 Sep 2020 10:59:49 +0000	[thread overview]
Message-ID: <010101746838d5d2-5deaf2a7-2c2e-440d-b488-c9150e681566-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <87363t52nj.fsf@codeaurora.org>

On 2020-09-07 15:28, Kalle Valo wrote:
> Anilkumar Kolli <akolli@codeaurora.org> writes:
> 
>> No functional changes, added target ce service configurations to 
>> hw_params.
>> 
>> Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>
> 
> [...]
> 
>> --- a/drivers/net/wireless/ath/ath11k/core.c
>> +++ b/drivers/net/wireless/ath/ath11k/core.c
>> @@ -812,12 +812,6 @@ int ath11k_core_init(struct ath11k_base *ab)
>>  		return ret;
>>  	}
>> 
>> -	ret = ath11k_init_hw_params(ab);
>> -	if (ret) {
>> -		ath11k_err(ab, "failed to get hw params %d\n", ret);
>> -		return ret;
>> -	}
> 
> This is very suspicious.

ath11k_core_pre_init() is calling ath11k_init_hw_params(), again calling 
same function in ath11k_core_init()
is not needed. Will send this as a new patch ?

Thanks
Anil

  parent reply	other threads:[~2020-09-07 11:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24 16:44 [PATCH v6 0/3] ath11k: Add IPQ6018 support Anilkumar Kolli
2020-08-24 16:44 ` Anilkumar Kolli
2020-08-24 16:44 ` [PATCH v6 1/3] dt: bindings: net: update compatible for ath11k Anilkumar Kolli
2020-08-24 16:44   ` Anilkumar Kolli
2020-08-24 21:27   ` Rob Herring
2020-08-24 21:27     ` Rob Herring
2020-08-24 16:44 ` [PATCH v6 2/3] ath11k: copy ce service configs to hw_params Anilkumar Kolli
2020-08-24 16:44   ` Anilkumar Kolli
2020-09-07  9:59   ` Kalle Valo
2020-09-07  9:59   ` Kalle Valo
     [not found]   ` <87363t52nj.fsf@codeaurora.org>
2020-09-07 10:59     ` akolli
2020-09-07 16:25       ` Kalle Valo
2020-09-07 16:25       ` Kalle Valo
2020-09-07 10:59     ` akolli [this message]
2020-08-24 16:44 ` [PATCH v6 3/3] ath11k: add IPQ6018 support Anilkumar Kolli
2020-08-24 16:44   ` Anilkumar Kolli
2020-09-07 10:01   ` Kalle Valo
2020-09-07 10:01   ` Kalle Valo
     [not found]   ` <87y2ll3nzh.fsf@codeaurora.org>
2020-09-07 11:01     ` akolli
2020-09-07 11:01     ` akolli
2020-09-07  9:57 ` [PATCH v6 0/3] ath11k: Add " Kalle Valo
2020-09-07  9:57 ` Kalle Valo
     [not found] ` <877dt552q1.fsf@codeaurora.org>
2020-09-07 11:03   ` akolli
2020-09-07 11:03   ` akolli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=010101746838d5d2-5deaf2a7-2c2e-440d-b488-c9150e681566-000000@us-west-2.amazonses.com \
    --to=akolli@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.