From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9DCCC433E2 for ; Fri, 11 Sep 2020 02:51:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6694D2078B for ; Fri, 11 Sep 2020 02:51:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ko24ixHV"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="KMIlHRte"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amazonses.com header.i=@amazonses.com header.b="JyQ7dZgF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6694D2078B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=klFZf/y+15+WeOdRZBJ/A6prTDus9j6yRLTm9cmUq0Q=; b=Ko24ixHVrMMfumgPzjhIbIKs8 M5j2rqLcFZiCzNISdEU9S2c7S4a39HJMCvr+7fF3eEwBwTkkTlEwg/5gtH7xUVOKgvL1gRbIe2Iyw /61bk8xOlcfopcfeTyF69chInFHibCWPkj4458m3JTb7+ZJB91gu9gTMqp9IXP/n5mZvC1PEoo4Ct VyqHYjI7X83tuuk3dEy8dOfo5Xsmj50i8nDtKKJj4mtvBmPEIizT3pxSImN+/4gOZdPIDNMPfqOA6 mjfMalOjrL4nGzyLIU3XY9bONc4XMZNhijbIhq9nGx/o/thlqD9UIGAY+QMAUEWsS+iVbGptJtSgz v5+/3DYoQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGZ8N-0000hD-VO; Fri, 11 Sep 2020 02:49:56 +0000 Received: from a27-186.smtp-out.us-west-2.amazonses.com ([54.240.27.186]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGZ8D-0000cY-DQ for linux-arm-kernel@lists.infradead.org; Fri, 11 Sep 2020 02:49:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zsmsymrwgfyinv5wlfyidntwsjeeldzt; d=codeaurora.org; t=1599792582; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To; bh=5KK85+dfJXgPi6ADBxmN30HWzErDUq8NOg2n9wo+q88=; b=KMIlHRteb+QC2LYmnA/bF3MP7g+WYwTDjY9yn1bZvAucPQFbh4f6z/SfyHU/srFn MAEIhSFcuzT2ezMl4DvxgtTctjh6nZlzuTr24PvhiOXK/jzOc/UZqLwFHv99aehDt9F OxRs54vsTnQuSp74/LEqLpzwBNozwhix0KQSB2A0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=hsbnp7p3ensaochzwyq5wwmceodymuwv; d=amazonses.com; t=1599792582; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Feedback-ID; bh=5KK85+dfJXgPi6ADBxmN30HWzErDUq8NOg2n9wo+q88=; b=JyQ7dZgFTis4Ucz/3btppurbOdnSXNqAlrKXjGEX4ui8ZKdOLY69xZJluOrLbnda U6oSoS6Mla09EG4O97b25NPmUrEvQQQuq0wTJReS9LTbwKqyEr1uRNAl06o9UayRiNI 08I9rbiYT3khjUvlEtYtCBTpCYa/sYggmSQ/VIm4= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 62866C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=tingweiz@codeaurora.org Date: Fri, 11 Sep 2020 02:49:42 +0000 From: Tingwei Zhang To: Mathieu Poirier Subject: Re: [PATCH v10 08/24] coresight: etm: perf: Fix warning caused by etm_setup_aux failure Message-ID: <010101747b118e3a-bb0ce34d-ea43-4ff9-becf-66854d939a82-000000@us-west-2.amazonses.com> References: <20200821034445.967-1-tingwei@codeaurora.org> <20200821034445.967-9-tingwei@codeaurora.org> <20200910222840.GB590446@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200910222840.GB590446@xps15> User-Agent: Mutt/1.5.24 (2015-08-30) X-SES-Outgoing: 2020.09.11-54.240.27.186 Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200910_224945_670172_FDA2DE4B X-CRM114-Status: GOOD ( 23.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsoni@codeaurora.org, Sai Prakash Ranjan , Kim Phillips , Mao Jinlong , Suzuki K Poulose , Alexander Shishkin , Greg Kroah-Hartman , coresight@lists.linaro.org, Randy Dunlap , Mian Yousaf Kaukab , Russell King , linux-kernel@vger.kernel.org, Tingwei Zhang , Leo Yan , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 11, 2020 at 06:28:40AM +0800, Mathieu Poirier wrote: > On Fri, Aug 21, 2020 at 11:44:29AM +0800, Tingwei Zhang wrote: > > When coresight_build_path() fails on all the cpus, etm_setup_aux > > calls etm_free_aux() to free allocated event_data. > > WARN_ON(cpumask_empty(mask) will be triggered since cpu mask is empty. > > Check event_data->snk_config is not NULL first to avoid this > > warning. > > > > Signed-off-by: Tingwei Zhang > > Reviewed-by: Mike Leach > > Reviewed-by: Suzuki K Poulose > > Reviewed-by: Mathieu Poirier > > What happend to the Fixed tag that was in V8? This is casting doubts on > the > reset of this set. > Hi Mathieu, Sorry about the mess here. I pushed the change to Android mainline and missed fix tag when making V10. To make sure there's no other missing, I compared all V8 and V10 patches and rechecked all comments on V8. Two issues were found. 1. Reviewed-by from you on [patch 5/24] should not be added. 2. MODULE_LICENSE("GPL v2") was missed in V10. I'll fix all issues on V11. Shall I send V11 when it's ready or wait for your comments on other patches? Thanks, Tingwei > > --- > > drivers/hwtracing/coresight/coresight-etm-perf.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c > b/drivers/hwtracing/coresight/coresight-etm-perf.c > > index dcb0592418ae..3728c44e5763 100644 > > --- a/drivers/hwtracing/coresight/coresight-etm-perf.c > > +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c > > @@ -126,10 +126,10 @@ static void free_sink_buffer(struct etm_event_data > *event_data) > > cpumask_t *mask = &event_data->mask; > > struct coresight_device *sink; > > > > - if (WARN_ON(cpumask_empty(mask))) > > + if (!event_data->snk_config) > > return; > > > > - if (!event_data->snk_config) > > + if (WARN_ON(cpumask_empty(mask))) > > return; > > > > cpu = cpumask_first(mask); > > -- > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora > Forum, > > a Linux Foundation Collaborative Project > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel