From: James Byrne <james.byrne@origamienergy.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/minicom: make default port and lock directory fixed defaults
Date: Tue, 26 Nov 2019 09:52:04 +0000 [thread overview]
Message-ID: <0102016ea7200662-f8edd1c2-afe0-49e9-b3c7-edfd26668a59-000000@eu-west-1.amazonses.com> (raw)
In-Reply-To: <0102016e8e961113-8b7cfd63-a693-49fd-93a3-70b7bb311860-000000@eu-west-1.amazonses.com>
Minicom's configure script will set values for the default port and lock
directory based on the configuration of the host machine, which is not
useful for cross-compiling or reproducible builds, so instead set them
to sensible default values.
Signed-off-by: James Byrne <james.byrne@origamienergy.com>
---
Changes v1 -> v2:
- Use fixed default values instead of configurable ones.
Signed-off-by: James Byrne <james.byrne@origamienergy.com>
---
package/minicom/minicom.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/minicom/minicom.mk b/package/minicom/minicom.mk
index 11d69d4d0e..82484557ab 100644
--- a/package/minicom/minicom.mk
+++ b/package/minicom/minicom.mk
@@ -22,4 +22,6 @@ define MINICOM_MKDIR_M4
endef
MINICOM_POST_PATCH_HOOKS += MINICOM_MKDIR_M4
+MINICOM_CONF_OPTS = --enable-dfl-port=/dev/ttyS1 --enable-lock-dir=/var/lock
+
$(eval $(autotools-package))
--
2.24.0
next prev parent reply other threads:[~2019-11-26 9:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 15:30 [Buildroot] [PATCH 1/1] package/minicom: make default port and lock directory config options James Byrne
2019-11-21 17:35 ` Giulio Benetti
2019-11-23 11:03 ` Yann E. MORIN
2019-11-23 12:34 ` Peter Korsgaard
2019-11-26 9:52 ` James Byrne [this message]
2019-11-26 11:54 ` [Buildroot] [PATCH v2] package/minicom: make default port and lock directory fixed defaults Thomas Petazzoni
2019-12-03 13:46 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0102016ea7200662-f8edd1c2-afe0-49e9-b3c7-edfd26668a59-000000@eu-west-1.amazonses.com \
--to=james.byrne@origamienergy.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.