From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CA6DC43464 for ; Fri, 18 Sep 2020 10:37:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CFA421534 for ; Fri, 18 Sep 2020 10:37:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726219AbgIRKhd (ORCPT ); Fri, 18 Sep 2020 06:37:33 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:48420 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725941AbgIRKhd (ORCPT ); Fri, 18 Sep 2020 06:37:33 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id DCCD93B05D18F5165875; Fri, 18 Sep 2020 18:37:30 +0800 (CST) Received: from [10.174.179.63] (10.174.179.63) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.487.0; Fri, 18 Sep 2020 18:37:24 +0800 Subject: Re: [PATCH -next] i2c: efm32: Use devm_platform_get_and_ioremap_resource() To: Yicong Yang CC: , , , , , , References: <20200918082508.32427-1-bobo.shaobowang@huawei.com> <961c1feb-f818-f98c-f618-57c643bac04c@hisilicon.com> From: "Wangshaobo (bobo)" Message-ID: <01032e87-f334-c586-2baa-78919310d736@huawei.com> Date: Fri, 18 Sep 2020 18:37:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <961c1feb-f818-f98c-f618-57c643bac04c@hisilicon.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.63] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/9/18 18:01, Yicong Yang 写道: > On 2020/9/18 16:25, Wang ShaoBo wrote: >> Make use of devm_platform_get_and_ioremap_resource() provided by >> driver core platform instead of duplicated analogue. dev_err() is >> removed because it has been done in devm_ioremap_resource(). >> >> Signed-off-by: Wang ShaoBo >> --- >> drivers/i2c/busses/i2c-efm32.c | 12 +++--------- >> 1 file changed, 3 insertions(+), 9 deletions(-) >> >> diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c >> index 838ce0947191..f6e13ceeb2b3 100644 >> --- a/drivers/i2c/busses/i2c-efm32.c >> +++ b/drivers/i2c/busses/i2c-efm32.c >> @@ -332,21 +332,15 @@ static int efm32_i2c_probe(struct platform_device *pdev) >> return ret; >> } >> >> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> - if (!res) { >> - dev_err(&pdev->dev, "failed to determine base address\n"); >> - return -ENODEV; >> - } >> + ddata->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res); >> + if (IS_ERR(ddata->base)) >> + return PTR_ERR(ddata->base); >> >> if (resource_size(res) < 0x42) { > res is not assigned. should it be removed? I am not sure what you want to ask, but devm_platform_get_and_ioremap_resource() will assign variable res a value, if it is NULL, internal devm_ioremap_resource() will return error at the begining, so at this time if(IS_ERR(ddata->base)) true and terminate the process, which is as same as the original sentences work. >> dev_err(&pdev->dev, "memory resource too small\n"); >> return -EINVAL; >> } >> >> - ddata->base = devm_ioremap_resource(&pdev->dev, res); >> - if (IS_ERR(ddata->base)) >> - return PTR_ERR(ddata->base); >> - >> ret = platform_get_irq(pdev, 0); >> if (ret <= 0) { >> if (!ret) > . From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F396DC43464 for ; Fri, 18 Sep 2020 10:39:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AA4721D24 for ; Fri, 18 Sep 2020 10:39:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="J0BNfqO8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AA4721D24 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sZyDXtPOhjrepv2BOfPdQOtiXq30ukp+nN/9gd4wDeI=; b=J0BNfqO8vn7e9kTXdtNou7cAA DxFJQ9BGcCQt3XNB/dgJ/2sjvnVzzU1oGmmrOtoQLcBLHX/A0f6xhvQXphmTMQzd7fVoOKHgMNMEt zPsBBD8E9ySnGDk1gNF4EsEEeBTAKZoVpOknigxOjqzspl3N8OMv8mYerDkO5GS4NMlbib8LkY56f grRasDOVj8yJa/SymlmWXTUOWTJfsQoq4H2lKD4OAMh0cCY1BdwoJKMtXmaJH2vGlK0BR08xM5fEC GHR+AcMdl/RBpNajWDkxcXYQkrud+yJVvlXzOdtS4g6k4Es/tFYwWGVvjLw+42UyiDfd/rxMi/a0k VKhNEzZeQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJDlu-0003CP-2J; Fri, 18 Sep 2020 10:37:42 +0000 Received: from szxga06-in.huawei.com ([45.249.212.32] helo=huawei.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJDln-0003Ai-Oj for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 10:37:37 +0000 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id DCCD93B05D18F5165875; Fri, 18 Sep 2020 18:37:30 +0800 (CST) Received: from [10.174.179.63] (10.174.179.63) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.487.0; Fri, 18 Sep 2020 18:37:24 +0800 Subject: Re: [PATCH -next] i2c: efm32: Use devm_platform_get_and_ioremap_resource() To: Yicong Yang References: <20200918082508.32427-1-bobo.shaobowang@huawei.com> <961c1feb-f818-f98c-f618-57c643bac04c@hisilicon.com> From: "Wangshaobo (bobo)" Message-ID: <01032e87-f334-c586-2baa-78919310d736@huawei.com> Date: Fri, 18 Sep 2020 18:37:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <961c1feb-f818-f98c-f618-57c643bac04c@hisilicon.com> X-Originating-IP: [10.174.179.63] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_063736_079327_F5998995 X-CRM114-Status: GOOD ( 14.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cj.chengjian@huawei.com, linux-kernel@vger.kernel.org, wsa@kernel.org, linux-i2c@vger.kernel.org, huawei.libin@huawei.com, u.kleine-koenig@pengutronix.de, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CuWcqCAyMDIwLzkvMTggMTg6MDEsIFlpY29uZyBZYW5nIOWGmemBkzoKPiBPbiAyMDIwLzkvMTgg MTY6MjUsIFdhbmcgU2hhb0JvIHdyb3RlOgo+PiBNYWtlIHVzZSBvZiBkZXZtX3BsYXRmb3JtX2dl dF9hbmRfaW9yZW1hcF9yZXNvdXJjZSgpIHByb3ZpZGVkIGJ5Cj4+IGRyaXZlciBjb3JlIHBsYXRm b3JtIGluc3RlYWQgb2YgZHVwbGljYXRlZCBhbmFsb2d1ZS4gZGV2X2VycigpIGlzCj4+IHJlbW92 ZWQgYmVjYXVzZSBpdCBoYXMgYmVlbiBkb25lIGluIGRldm1faW9yZW1hcF9yZXNvdXJjZSgpLgo+ Pgo+PiBTaWduZWQtb2ZmLWJ5OiBXYW5nIFNoYW9CbyA8Ym9iby5zaGFvYm93YW5nQGh1YXdlaS5j b20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvaTJjL2J1c3Nlcy9pMmMtZWZtMzIuYyB8IDEyICsrKy0t LS0tLS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25z KC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2kyYy9idXNzZXMvaTJjLWVmbTMyLmMgYi9k cml2ZXJzL2kyYy9idXNzZXMvaTJjLWVmbTMyLmMKPj4gaW5kZXggODM4Y2UwOTQ3MTkxLi5mNmUx M2NlZWIyYjMgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvaTJjL2J1c3Nlcy9pMmMtZWZtMzIuYwo+ PiArKysgYi9kcml2ZXJzL2kyYy9idXNzZXMvaTJjLWVmbTMyLmMKPj4gQEAgLTMzMiwyMSArMzMy LDE1IEBAIHN0YXRpYyBpbnQgZWZtMzJfaTJjX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2Ug KnBkZXYpCj4+ICAgCQlyZXR1cm4gcmV0Owo+PiAgIAl9Cj4+ICAgCj4+IC0JcmVzID0gcGxhdGZv cm1fZ2V0X3Jlc291cmNlKHBkZXYsIElPUkVTT1VSQ0VfTUVNLCAwKTsKPj4gLQlpZiAoIXJlcykg ewo+PiAtCQlkZXZfZXJyKCZwZGV2LT5kZXYsICJmYWlsZWQgdG8gZGV0ZXJtaW5lIGJhc2UgYWRk cmVzc1xuIik7Cj4+IC0JCXJldHVybiAtRU5PREVWOwo+PiAtCX0KPj4gKwlkZGF0YS0+YmFzZSA9 IGRldm1fcGxhdGZvcm1fZ2V0X2FuZF9pb3JlbWFwX3Jlc291cmNlKHBkZXYsIDAsICZyZXMpOwo+ PiArCWlmIChJU19FUlIoZGRhdGEtPmJhc2UpKQo+PiArCQlyZXR1cm4gUFRSX0VSUihkZGF0YS0+ YmFzZSk7Cj4+ICAgCj4+ICAgCWlmIChyZXNvdXJjZV9zaXplKHJlcykgPCAweDQyKSB7Cj4gcmVz IGlzIG5vdCBhc3NpZ25lZC4gc2hvdWxkIGl0IGJlIHJlbW92ZWQ/CgpJIGFtIG5vdCBzdXJlIHdo YXQgeW91IHdhbnQgdG8gYXNrLCBidXQgZGV2bV9wbGF0Zm9ybV9nZXRfYW5kX2lvcmVtYXBfcmVz b3VyY2UoKSB3aWxsCmFzc2lnbiB2YXJpYWJsZSByZXMgYSB2YWx1ZSwgaWYgaXQgaXMgTlVMTCwg aW50ZXJuYWwgZGV2bV9pb3JlbWFwX3Jlc291cmNlKCkgd2lsbCByZXR1cm4gZXJyb3IKYXQgdGhl IGJlZ2luaW5nLCBzbyBhdCB0aGlzIHRpbWUgaWYoSVNfRVJSKGRkYXRhLT5iYXNlKSkgdHJ1ZSBh bmQgdGVybWluYXRlIHRoZSBwcm9jZXNzLAp3aGljaCBpcyBhcyBzYW1lIGFzIHRoZSBvcmlnaW5h bCBzZW50ZW5jZXMgd29yay4KCj4+ICAgCQlkZXZfZXJyKCZwZGV2LT5kZXYsICJtZW1vcnkgcmVz b3VyY2UgdG9vIHNtYWxsXG4iKTsKPj4gICAJCXJldHVybiAtRUlOVkFMOwo+PiAgIAl9Cj4+ICAg Cj4+IC0JZGRhdGEtPmJhc2UgPSBkZXZtX2lvcmVtYXBfcmVzb3VyY2UoJnBkZXYtPmRldiwgcmVz KTsKPj4gLQlpZiAoSVNfRVJSKGRkYXRhLT5iYXNlKSkKPj4gLQkJcmV0dXJuIFBUUl9FUlIoZGRh dGEtPmJhc2UpOwo+PiAtCj4+ICAgCXJldCA9IHBsYXRmb3JtX2dldF9pcnEocGRldiwgMCk7Cj4+ ICAgCWlmIChyZXQgPD0gMCkgewo+PiAgIAkJaWYgKCFyZXQpCj4gLgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=