From: Boris Ostrovsky <firstname.lastname@example.org> To: Juergen Gross <email@example.com>, Jan Beulich <firstname.lastname@example.org> Cc: "email@example.com" <firstname.lastname@example.org> Subject: Re: [PATCH] x86/Xen: swap NX determination and GDT setup on BSP Date: Fri, 21 May 2021 09:12:29 -0400 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On 5/21/21 3:45 AM, Juergen Gross wrote: > On 21.05.21 09:26, Jan Beulich wrote: >> On 21.05.2021 09:18, Juergen Gross wrote: >>> On 20.05.21 14:08, Jan Beulich wrote: >>>> On 20.05.2021 13:57, Juergen Gross wrote: >>>>> On 20.05.21 13:42, Jan Beulich wrote: >>>>>> xen_setup_gdt(), via xen_load_gdt_boot(), wants to adjust page tables. >>>>>> For this to work when NX is not available, x86_configure_nx() needs > to >>>>>> be called first. >>>>>> >>>>>> Reported-by: Olaf Hering <email@example.com> >>>>>> Signed-off-by: Jan Beulich <firstname.lastname@example.org> >>>>> >>>>> Reviewed-by: Juergen Gross <email@example.com> >>>> >>>> Thanks. I guess I forgot >>>> >>>> Cc: firstname.lastname@example.org >>>> >>>> If you agree, can you please add this before pushing to Linus? >>> >>> Uh, just had a look why x86_configure_nx() was called after >>> xen_setup_gdt(). >>> >>> Upstream your patch will be fine, but before kernel 5.9 it will >>> break running as 32-bit PV guest (see commit 36104cb9012a82e7). >> >> Oh, indeed. That commit then actually introduced the issue here, >> and hence a Fixes: tag may be warranted. > > Added it already. :-) > > And I've limited the backport to happen not for 5.8 and older, of > course. Did something changed recently that this became a problem? That commit has been there for 3 years. Didn't Olaf report this to be a problem only on SLES kernels? -boris
next prev parent reply other threads:[~2021-05-21 13:13 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-20 11:42 Jan Beulich 2021-05-20 11:57 ` Juergen Gross 2021-05-20 12:08 ` Jan Beulich 2021-05-20 12:18 ` Juergen Gross 2021-05-21 7:18 ` Juergen Gross 2021-05-21 7:26 ` Jan Beulich 2021-05-21 7:45 ` Juergen Gross 2021-05-21 13:12 ` Boris Ostrovsky [this message] 2021-05-21 13:15 ` Jan Beulich 2021-05-21 13:17 ` Boris Ostrovsky 2021-05-21 8:30 ` Juergen Gross
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] x86/Xen: swap NX determination and GDT setup on BSP' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.