From mboxrd@z Thu Jan  1 00:00:00 1970
From: Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: [PATCH v3] net: mlx5: Add a missing check on idr_find, free buf
Date: Tue, 19 Mar 2019 16:57:47 +0000
Message-ID: <010498dc10890e09c18ab6941fa2abcde6a7b28e.camel@mellanox.com>
References: <20190319155524.6978-1-pakki001@umn.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20190319155524.6978-1-pakki001@umn.edu>
Content-Language: en-US
Content-ID: <252F3ABE701D5744BFB0FF6E3863C8A9@eurprd05.prod.outlook.com>
Sender: linux-kernel-owner@vger.kernel.org
To: "pakki001@umn.edu" <pakki001@umn.edu>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>, Boris Pismenny <borisp@mellanox.com>, "weiyongjun1@huawei.com" <weiyongjun1@huawei.com>, "kjlu@umn.edu" <kjlu@umn.edu>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, Ilya Lesokhin <ilyal@mellanox.com>, "davem@davemloft.net" <davem@davemloft.net>, "leon@kernel.org" <leon@kernel.org>
List-Id: linux-rdma@vger.kernel.org

T24gVHVlLCAyMDE5LTAzLTE5IGF0IDEwOjU1IC0wNTAwLCBBZGl0eWEgUGFra2kgd3JvdGU6DQo+
IGlkcl9maW5kKCkgY2FuIHJldHVybiBhIE5VTEwgdmFsdWUgdG8gJ2Zsb3cnIHdoaWNoIGlzIHVz
ZWQgd2l0aG91dCBhDQo+IGNoZWNrLg0KPiBUaGUgcGF0Y2ggYWRkcyBhIGNoZWNrIHRvIGF2b2lk
IHBvdGVudGlhbCBOVUxMIHBvaW50ZXIgZGVyZWZlcmVuY2UuDQo+IEluIGNhc2Ugb2YgbWx4NV9m
cGdhX3NidV9jb25uX3NlbmRtc2coKSBmYWlsdXJlLCBmcmVlIGJ1ZiBhbGxvY2F0ZWQNCj4gdXNp
bmcga3phbGxvYy4NCj4gDQo+IC0tLQ0KPiB2MjogZmFpbHVyZSB0byByZXR1cm4gaW4gY2FzZSBv
ZiBmbG93IGZhaWx1cmUuDQo+IHYxOiBGYWlsZWQgdG8gZnJlZSBidWYgaW4gY2FzZSBvZiBmbG93
IGZhaWx1cmUuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBBZGl0eWEgUGFra2kgPHBha2tpMDAxQHVt
bi5lZHU+DQo+IC0tLQ0KPiAgZHJpdmVycy9uZXQvZXRoZXJuZXQvbWVsbGFub3gvbWx4NS9jb3Jl
L2ZwZ2EvdGxzLmMgfCA3ICsrKysrKysNCj4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMo
KykNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC9ldGhlcm5ldC9tZWxsYW5veC9tbHg1
L2NvcmUvZnBnYS90bHMuYw0KPiBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L21lbGxhbm94L21seDUv
Y29yZS9mcGdhL3Rscy5jDQo+IGluZGV4IDVjZjVmMmE5ZDUxZi4uMjI0ZTBkN2Y2NDg5IDEwMDY0
NA0KPiAtLS0gYS9kcml2ZXJzL25ldC9ldGhlcm5ldC9tZWxsYW5veC9tbHg1L2NvcmUvZnBnYS90
bHMuYw0KPiArKysgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9tZWxsYW5veC9tbHg1L2NvcmUvZnBn
YS90bHMuYw0KPiBAQCAtMjI2LDYgKzIyNiwxMSBAQCBpbnQgbWx4NV9mcGdhX3Rsc19yZXN5bmNf
cngoc3RydWN0IG1seDVfY29yZV9kZXYNCj4gKm1kZXYsIHUzMiBoYW5kbGUsIHUzMiBzZXEsDQo+
ICAJcmN1X3JlYWRfbG9jaygpOw0KPiAgCWZsb3cgPSBpZHJfZmluZCgmbWRldi0+ZnBnYS0+dGxz
LT5yeF9pZHIsIG50b2hsKGhhbmRsZSkpOw0KPiAgCXJjdV9yZWFkX3VubG9jaygpOw0KPiArCWlm
ICghZmxvdykgew0KPiArCQlXQVJOX09OQ0UoMSwgIlJlY2VpdmVkIE5VTEwgcG9pbnRlciBmb3Ig
aGFuZGxlXG4iKTsNCj4gKwkJa2ZyZWUoYnVmKTsNCj4gKwkJcmV0dXJuIC1FSU5WQUw7DQo+ICsJ
fQ0KDQpKdXN0IGEgc21hbGwgbml0LCBpdCB3b3VsZCBoYXZlIGJlZW4gc2ltcGxlciBpZiB5b3Ug
anVzdCBjaGFuZ2VkIHRoZQ0Kb3JkZXIgYmV0d2VlbiBidWYgPSBremFsbG9jKC4uLikgYW5kIGZs
b3cgPSBpZHJfZmluZCwgdG8gYXZvaWQNCmtmcmVlKGJ1Zikgb24gZXJyIGZsb3cuDQoNClBsZWFz
ZSBhZGQgdGhlIGZpeGVzIHRhZyBhcyBFcmljIHN1Z2dlc3RlZC4NCg0KPiAgCW1seDVfZnBnYV90
bHNfZmxvd190b19jbWQoZmxvdywgY21kKTsNCj4gIA0KPiAgCU1MWDVfU0VUKHRsc19jbWQsIGNt
ZCwgc3dpZCwgbnRvaGwoaGFuZGxlKSk7DQo+IEBAIC0yMzgsNiArMjQzLDggQEAgaW50IG1seDVf
ZnBnYV90bHNfcmVzeW5jX3J4KHN0cnVjdCBtbHg1X2NvcmVfZGV2DQo+ICptZGV2LCB1MzIgaGFu
ZGxlLCB1MzIgc2VxLA0KPiAgCWJ1Zi0+Y29tcGxldGUgPSBtbHhfdGxzX2tmcmVlX2NvbXBsZXRl
Ow0KPiAgDQo+ICAJcmV0ID0gbWx4NV9mcGdhX3NidV9jb25uX3NlbmRtc2cobWRldi0+ZnBnYS0+
dGxzLT5jb25uLCBidWYpOw0KPiArCWlmIChyZXQgPCAwKQ0KPiArCQlrZnJlZShidWYpOw0KPiAg
DQo+ICAJcmV0dXJuIHJldDsNCj4gIH0NCg==