From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCHv6 18/33] net/dpaa2: adding eth ops to dpaa2
Date: Mon, 23 Jan 2017 17:35:25 +0000
Message-ID: <010516e0-e56b-88c1-7734-3baf568f4e01@intel.com>
References: <1484832240-2048-1-git-send-email-hemant.agrawal@nxp.com>
 <1485172803-17288-1-git-send-email-hemant.agrawal@nxp.com>
 <1485172803-17288-19-git-send-email-hemant.agrawal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: thomas.monjalon@6wind.com, bruce.richardson@intel.com,
 shreyansh.jain@nxp.com, john.mcnamara@intel.com,
 jerin.jacob@caviumnetworks.com
To: Hemant Agrawal <hemant.agrawal@nxp.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 75E13108F
 for <dev@dpdk.org>; Mon, 23 Jan 2017 18:35:28 +0100 (CET)
In-Reply-To: <1485172803-17288-19-git-send-email-hemant.agrawal@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/23/2017 11:59 AM, Hemant Agrawal wrote:
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
<...>

>  static int
>  dpaa2_dev_init(struct rte_eth_dev *eth_dev)
>  {
<...>
> +	eth_dev->data->nb_rx_queues = priv->nb_rx_queues;
> +	eth_dev->data->nb_tx_queues = priv->nb_tx_queues;

No need to assign these during init(), app should set these via
rte_eth_dev_configure() API.

> +
> +	priv->hw = dpni_dev;
> +	priv->hw_id = hw_id;
> +	priv->flags = 0;

<...>