From: "Richard Purdie" <rpurdie@rpsys.net>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Andrew Morton <akpm@osdl.org>, Wolfgang Wander <wwc@rentec.com>,
linux-mm@kvack.org
Subject: Re: 2.6.12-rc4-mm2
Date: Sun, 5 Jun 2005 19:43:38 +0100 [thread overview]
Message-ID: <010a01c569fe$83899a10$0f01a8c0@max> (raw)
In-Reply-To: 20050605124556.A23271@flint.arm.linux.org.uk
Russell King:
>> [PATCH] ARM: Move copy/clear user_page locking into implementation
>
> This one changes the way we do these operations on SA1100, but it got
> tested prior to submission on the Assabet which didn't show anything
> up. However, if I had to pick one, it'd be this.
And testing confirms this patch is indeed at fault. Adding/removing the code
below stabilises/destabilises the system (I'm defining instability as random
segfaults, floating point errors, illegal instructions and alignment
errors).
The test system is ARM PXA255 based (v5te core, preempt enabled) and its
using copypage-xscale.S. I suspect the locking below is needed on the xscale
for some reason.
Does that make sense and highlight a problem?
Richard
--- a/include/asm-arm/page.h
+++ b/include/asm-arm/page.h
@@ -114,19 +114,8 @@ extern void __cpu_copy_user_page(void *t
unsigned long user);
#endif
-#define clear_user_page(addr,vaddr,pg) \
- do { \
- preempt_disable(); \
- __cpu_clear_user_page(addr, vaddr); \
- preempt_enable(); \
- } while (0)
-
-#define copy_user_page(to,from,vaddr,pg) \
- do { \
- preempt_disable(); \
- __cpu_copy_user_page(to, from, vaddr); \
- preempt_enable(); \
- } while (0)
+#define clear_user_page(addr,vaddr,pg) __cpu_clear_user_page(addr, vaddr)
+#define copy_user_page(to,from,vaddr,pg) __cpu_copy_user_page(to, from,
vaddr)
#define clear_page(page) memzero((void *)(page), PAGE_SIZE)
extern void copy_page(void *to, const void *from);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2005-06-05 18:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050516130048.6f6947c1.akpm@osdl.org>
[not found] ` <20050516210655.E634@flint.arm.linux.org.uk>
[not found] ` <030401c55a6e$34e67cb0$0f01a8c0@max>
2005-05-16 23:39 ` 2.6.12-rc4-mm2 Andrew Morton
2005-05-17 0:13 ` 2.6.12-rc4-mm2 Wolfgang Wander
2005-05-17 8:38 ` 2.6.12-rc4-mm2 Richard Purdie
2005-06-02 21:02 ` 2.6.12-rc4-mm2 Russell King
2005-06-02 22:20 ` 2.6.12-rc4-mm2 Wolfgang Wander
2005-06-02 22:28 ` 2.6.12-rc4-mm2 Richard Purdie
2005-06-04 14:18 ` 2.6.12-rc4-mm2 Richard Purdie
2005-06-04 14:43 ` 2.6.12-rc4-mm2 Richard Purdie
2005-06-05 11:39 ` 2.6.12-rc4-mm2 Richard Purdie
2005-06-05 11:45 ` 2.6.12-rc4-mm2 Russell King
2005-06-05 18:43 ` Richard Purdie [this message]
2005-06-05 19:16 ` 2.6.12-rc4-mm2 Russell King
2005-05-16 9:13 2.6.12-rc4-mm2 Andrew Morton
2005-05-16 9:25 ` 2.6.12-rc4-mm2 Russell King
2005-05-16 10:50 ` 2.6.12-rc4-mm2 Danny ter Haar
2005-05-16 11:17 ` 2.6.12-rc4-mm2 Alexey Dobriyan
2005-05-16 11:38 ` 2.6.12-rc4-mm2 Danny ter Haar
2005-05-16 12:15 ` 2.6.12-rc4-mm2 Alexey Dobriyan
2005-05-16 17:11 ` 2.6.12-rc4-mm2 Danny ter Haar
2005-05-16 17:43 ` 2.6.12-rc4-mm2 Alexey Dobriyan
2005-05-16 19:30 ` 2.6.12-rc4-mm2 Danny ter Haar
2005-05-16 12:30 ` 2.6.12-rc4-mm2 Brice Goglin
2005-05-17 9:06 ` 2.6.12-rc4-mm2 Brice Goglin
2005-05-17 16:38 ` 2.6.12-rc4-mm2 Richard Purdie
2005-05-18 22:45 ` 2.6.12-rc4-mm2 Richard Purdie
2005-05-18 7:14 ` 2.6.12-rc4-mm2 Coywolf Qi Hunt
[not found] ` <20050516021302.13bd285a.akpm-3NddpPZAyC0@public.gmane.org>
2005-05-18 20:26 ` 2.6.12-rc4-mm2 Alexander Nyberg
2005-05-18 20:26 ` 2.6.12-rc4-mm2 Alexander Nyberg
[not found] ` <1116447964.23209.26.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2005-05-24 8:45 ` 2.6.12-rc4-mm2 Andrew Morton
2005-05-19 14:59 ` 2.6.12-rc4-mm2 Brice Goglin
-- strict thread matches above, loose matches on Subject: below --
2005-05-12 10:31 2.6.12-rc4-mm1 Andrew Morton
2005-05-14 11:27 ` 2.6.12-rc4-mm1 Richard Purdie
2005-05-16 11:27 ` 2.6.12-rc4-mm2 Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='010a01c569fe$83899a10$0f01a8c0@max' \
--to=rpurdie@rpsys.net \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
--cc=rmk@arm.linux.org.uk \
--cc=wwc@rentec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.