From: <rsbecker@nexbridge.com>
To: "'Taylor Blau'" <me@ttaylorr.com>
Cc: <git@vger.kernel.org>
Subject: RE: [BUG] Re: Git 2.35.0-rc0
Date: Mon, 10 Jan 2022 21:57:57 -0500 [thread overview]
Message-ID: <010b01d80697$0c848770$258d9650$@nexbridge.com> (raw)
In-Reply-To: <Ydzw+RqR6IfbT/oM@nand.local>
On January 10, 2022 9:53 PM, Taylor Blau wrote:
> On Mon, Jan 10, 2022 at 09:20:15PM -0500, rsbecker@nexbridge.com
> wrote:
> > Hi All,
> >
> > Git 2.35.0-rc0 is not portable:
> >
> > uncompress2(uncompressed + block_header_skip, &dst_len,
> > ^
> > "/home/ituglib/randall/jenkins/.jenkins/workspace/Git_Pipeline/reftabl
> > e/bloc
> > k.c", line 213: error(114):
> > identifier "uncompress2" is undefined
> >
> > This is not a POSIX compliant call.
>
> uncompress2() isn't a POSIX thing, it's part of zlib IIUC. The new caller is in the
> reftable code, which provides a build knob
> NO_UNCOMPRESS2 that you can use if your version of zlib does not have
> uncompress2().
>
> uncompress2() was added to zlib back in 37281ac (Add uncompress2()
> function, which returns the input size used., 2016-11-15), which first
> appeared in version 1.2.9.
>
> If your system doesn't have a modern-ish zlib, you may try building with that
> knob, or upgrading your system's copy of zlib. And if NonStop doesn't have a
> modern zlib available at all, we should modify the NonStop section of
> config.mak.uname.
There is no provision in reftable/block.c to avoid using uncompress2, so the knob will not help. Our zlibc is not that recent (as in it does not have uncompress2) and we cannot make the 2.35.0 timeframe to upgrade it. The current zlib seems to require gcc and is very difficult to port at this stage. This is a blocker situation.
--Randall
next prev parent reply other threads:[~2022-01-11 2:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 2:20 [BUG] Re: Git 2.35.0-rc0 rsbecker
2022-01-11 2:52 ` Taylor Blau
2022-01-11 2:57 ` rsbecker [this message]
2022-01-11 3:00 ` Taylor Blau
2022-01-11 3:03 ` rsbecker
2022-01-11 3:51 ` rsbecker
2022-01-11 12:51 ` rsbecker
2022-01-11 19:53 ` Taylor Blau
2022-01-11 20:39 ` rsbecker
2022-01-12 19:18 ` Junio C Hamano
2022-01-12 19:21 ` Taylor Blau
2022-01-13 13:21 ` Ævar Arnfjörð Bjarmason
2022-01-13 18:03 ` Junio C Hamano
[not found] <00ef01d80691$82df3380$889d9a80$@nexbridge.com>
2022-01-11 2:25 ` rsbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='010b01d80697$0c848770$258d9650$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.