All of lore.kernel.org
 help / color / mirror / Atom feed
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: S3C64XX: Prototype SPI devices
Date: Thu, 09 Sep 2010 20:18:10 +0900	[thread overview]
Message-ID: <011001cb5010$b2848840$178d98c0$%kim@samsung.com> (raw)
In-Reply-To: <20100908124605.GA10413@rakim.wolfsonmicro.main>

Mark Brown wrote:
> 
> On Wed, Sep 08, 2010 at 09:39:21PM +0900, Kukjin Kim wrote:
> > Mark Brown wrote:
> 
> > > Avoids build warnings due to the undeclared non-statics.
> 
> > Could you please let me know what's the build warning?
> 
> It'll have been something along the lines of:
> 
> 's3c64xx_device_iis0' not declared; should it be static?
> 

> for each device.  Possibly generated by sparse rather than GCC - I
> always build with sparse as well.

Hi Mark,

Sorry...I can't understand your comment.

You mean the build warning is 's3c64xx_device_iis0' is not declared..right?
Hmm...the 's3c64xx_device_iis0' used only in a mach-s3c64xx/mach-smartq.c
file.
And defined it as extern struct in a plat-samsung/include/plat/devs.h file.
...So...why need to modify mach-s3c64xx/dev-spi.c for it?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

  reply	other threads:[~2010-09-09 11:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-08 10:25 [PATCH 1/2] ARM: S3C64XX: Fix dev-spi build Mark Brown
2010-09-08 10:25 ` [PATCH 2/2] ARM: S3C64XX: Prototype SPI devices Mark Brown
2010-09-08 12:39   ` Kukjin Kim
2010-09-08 12:46     ` Mark Brown
2010-09-09 11:18       ` Kukjin Kim [this message]
2010-09-09 11:33         ` Mark Brown
2010-09-08 11:52 ` [PATCH 1/2] ARM: S3C64XX: Fix dev-spi build Kukjin Kim
2010-09-08 12:12   ` Mark Brown
2010-09-08 12:21     ` Kukjin Kim
2010-09-08 14:17   ` Jassi Brar
2010-09-08 16:01     ` Mark Brown
2010-09-09  1:17       ` Jassi Brar
2010-09-09 11:11       ` Kukjin Kim
2010-09-09 11:34         ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2010-08-20 15:38 Mark Brown
2010-08-20 15:39 ` [PATCH 2/2] ARM: S3C64XX: Prototype SPI devices Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='011001cb5010$b2848840$178d98c0$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.