All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org,
	Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	'Christoph Hellwig' <hch-jcswGhMUV9g@public.gmane.org>,
	Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Subject: RE: [PATCH v2 0/3] new ib_drain_qp() API
Date: Tue, 9 Feb 2016 14:50:45 -0600	[thread overview]
Message-ID: <011601d1637b$8c01a3e0$a404eba0$@opengridcomputing.com> (raw)
In-Reply-To: <010901d16375$1a023210$4e069630$@opengridcomputing.com>

> > This series creates a new helper API for draining a queue pair.  It is a
> > rework of an original patch created by Christoph Hellwig as part of the CQ
> > API rework and was dropped to be resubmitted by me with iw_cxgb4 support.
> 
> I finally got SRP running to test this series and it isn't working. :(  Anyway, there will be v3 posted once I fix it.
> 
> Steve.

The problem is SRP creates its SQ CQ with IB_POLL_DIRECT context, so the CQ is never armed for interrupts, and SRP polls the CQ
directly.  So the drain logic won't work.  

I propose ib_drain_qp() takes a new parameter that tells it which queues to drain.  Then the SRP code will only drain the RQ (which
is what it is doing prior to this series).

Thoughts?

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-02-09 20:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-08 22:14 [PATCH v2 0/3] new ib_drain_qp() API Steve Wise
     [not found] ` <cover.1454969695.git.swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2016-01-14 18:24   ` [PATCH 2/3] iw_cxgb4: add drain_qp function Steve Wise
2016-01-27 20:09   ` [PATCH 3/3] IB/srp: use ib_drain_qp() Steve Wise
2016-02-05 21:13   ` [PATCH 1/3] IB: new common API for draining a queue pair Steve Wise
2016-02-09 20:04   ` [PATCH v2 0/3] new ib_drain_qp() API Steve Wise
2016-02-09 20:50     ` Steve Wise [this message]
2016-02-09 21:03       ` Bart Van Assche
     [not found]         ` <56BA540B.4040405-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-09 21:06           ` Steve Wise
2016-02-09 21:18           ` Chuck Lever
     [not found]             ` <08D51C34-0009-4784-BE80-7BCB85441606-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-02-09 21:20               ` Steve Wise
2016-02-09 21:35                 ` Chuck Lever
     [not found]         ` <011901d1637d$b5286400$1f792c00$@opengridcomputing.com>
2016-02-09 21:58           ` Steve Wise
2016-02-09 22:23             ` Chuck Lever
2016-02-10 10:33             ` Sagi Grimberg
     [not found]               ` <56BB11F0.9090203-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-02-10 14:08                 ` Bart Van Assche
     [not found]                   ` <56BB4479.8090009-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-11 10:46                     ` Sagi Grimberg
     [not found]                       ` <56BC6686.8030301-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-02-11 15:15                         ` Bart Van Assche
     [not found]                           ` <56BCA57A.4000500-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-02-11 16:11                             ` Sagi Grimberg
     [not found]                               ` <56BCB2C3.9060408-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-02-11 18:54                                 ` Bart Van Assche
2016-02-10 15:27                 ` Steve Wise
2016-02-10 15:55                   ` Steve Wise
2016-02-11 15:22                   ` Doug Ledford
     [not found]                     ` <56BCA741.6020800-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-02-11 16:09                       ` Sagi Grimberg
     [not found]                         ` <56BCB239.3020505-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-02-11 16:10                           ` Steve Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='011601d1637b$8c01a3e0$a404eba0$@opengridcomputing.com' \
    --to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
    --cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
    --cc=chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=hch-jcswGhMUV9g@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.