From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46208) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPa6C-0004sR-Af for qemu-devel@nongnu.org; Tue, 19 Jul 2016 14:50:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPa69-0005yn-4l for qemu-devel@nongnu.org; Tue, 19 Jul 2016 14:50:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPa68-0005yW-Vq for qemu-devel@nongnu.org; Tue, 19 Jul 2016 14:50:29 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1B3E564387 for ; Tue, 19 Jul 2016 18:50:28 +0000 (UTC) References: <20160719085432.4572-1-marcandre.lureau@redhat.com> <20160719085432.4572-26-marcandre.lureau@redhat.com> From: John Snow Message-ID: <012084d3-6f7c-052f-1c2c-239eed9ce587@redhat.com> Date: Tue, 19 Jul 2016 14:50:27 -0400 MIME-Version: 1.0 In-Reply-To: <20160719085432.4572-26-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 25/37] ahci: free irqs array List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org On 07/19/2016 04:54 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > Each irq is referenced by the IDEBus in ide_init2(), thus we can free > the no longer used array. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > hw/ide/ahci.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c > index bcb9ff9..6defeed 100644 > --- a/hw/ide/ahci.c > +++ b/hw/ide/ahci.c > @@ -1478,6 +1478,7 @@ void ahci_realize(AHCIState *s, DeviceState *qdev= , AddressSpace *as, int ports) > ad->port.dma->ops =3D &ahci_dma_ops; > ide_register_restart_cb(&ad->port); > } > + g_free(irqs); > } > =20 > void ahci_uninit(AHCIState *s) >=20 Oh, we pass these by-value, so yes. Reviewed-by: John Snow And if this entire series gets picked up, have an ACK to mean "I don't care who stages this:" Acked-by: John Snow