From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve Wise" Subject: RE: [PATCH v2 0/3] new ib_drain_qp() API Date: Tue, 9 Feb 2016 15:58:09 -0600 Message-ID: <012801d16384$f68884f0$e3998ed0$@opengridcomputing.com> References: <010901d16375$1a023210$4e069630$@opengridcomputing.com> <011601d1637b$8c01a3e0$a404eba0$@opengridcomputing.com> <56BA540B.4040405@sandisk.com> <011901d1637d$b5286400$1f792c00$@opengridcomputing.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <011901d1637d$b5286400$1f792c00$@opengridcomputing.com> Content-Language: en-us Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: 'Bart Van Assche' , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: 'Sagi Grimberg' , 'Christoph Hellwig' , 'Chuck Lever' List-Id: linux-rdma@vger.kernel.org > > Hello Steve, > > > > How about creating three functions - one that drains the receive queue, > > one that drains the send queue and a third function that drains both ? > > The latter function then can call the two former functions. And since > > only one of these three functions will have a user in your patch series > > (the function that drains the RQ), how about only introducing only that > > function now and to wait with introducing the two other functions until > > these have a user ? > > That sounds reasonable. Simpler too perhaps. We'll see if anyone else > has an opinion. Another option is for ib_drain_qp() to just skip queues with IB_POLL_DIRECT CQ processing. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html