From: "Zhao, Yakui" <yakui.zhao@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH V2] drm/i915: Use I915_MAP_WC for execlists context buffer on the platforms without LLC
Date: Fri, 22 Jun 2018 08:06:27 +0000 [thread overview]
Message-ID: <01363028D91B0B448414F51B4258CAA569F2DDB6@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <152965300886.11773.1843695981890264642@mail.alporthouse.com>
>-----Original Message-----
>From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
>Sent: Friday, June 22, 2018 3:37 PM
>To: Zhao, Yakui <yakui.zhao@intel.com>; intel-gfx@lists.freedesktop.org
>Subject: RE: [PATCH V2] drm/i915: Use I915_MAP_WC for execlists context
>buffer on the platforms without LLC
>
>Quoting Zhao, Yakui (2018-06-22 08:29:15)
>>
>>
>> >-----Original Message-----
>> >From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
>> >Sent: Friday, June 22, 2018 2:36 PM
>> >To: Zhao, Yakui <yakui.zhao@intel.com>;
>> >intel-gfx@lists.freedesktop.org
>> >Cc: Zhao, Yakui <yakui.zhao@intel.com>
>> >Subject: Re: [PATCH V2] drm/i915: Use I915_MAP_WC for execlists
>> >context buffer on the platforms without LLC
>> >
>> >Quoting Zhao Yakui (2018-06-22 07:09:10)
>> >> @@ -2728,6 +2729,7 @@ populate_lr_context(struct i915_gem_context
>*ctx,
>> >> struct intel_engine_cs *engine,
>> >> struct intel_ring *ring) {
>> >> + enum i915_map_type map = HAS_LLC(ctx->i915) ? I915_MAP_WB :
>> >> + I915_MAP_WC;
>> >> void *vaddr;
>> >> u32 *regs;
>> >> int ret;
>> >> @@ -2738,13 +2740,12 @@ populate_lr_context(struct
>i915_gem_context
>> >*ctx,
>> >> return ret;
>> >> }
>> >>
>> >> - vaddr = i915_gem_object_pin_map(ctx_obj, I915_MAP_WB);
>> >> + vaddr = i915_gem_object_pin_map(ctx_obj, map);
>> >
>> >As this uses the cpu domain and flushed afterwards, this one is
>> >correct in its usage of MAP_WB.
>>
>> In this function the content of context state is flushed.
>>
>> But the function of execlists_submit_ports will update it again before writing
>the ELSP port.
>> And there is no flush. In fact after the ELSP port is written, the HW will start
>to execute the submitted commands.
>
>That's a different map.
Really? It is allocated in one gem obj.
Will you please help to point out where to handle the different map?
Thanks
Yakui
>-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-06-22 8:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 6:09 [PATCH V2] drm/i915: Use I915_MAP_WC for execlists context buffer on the platforms without LLC Zhao Yakui
2018-06-22 6:26 ` Chris Wilson
2018-06-22 7:34 ` Zhao, Yakui
2018-06-22 6:35 ` ✗ Fi.CI.BAT: failure for drm/i915: Use I915_MAP_WC for execlists context buffer on the platforms without LLC (rev2) Patchwork
2018-06-22 6:36 ` [PATCH V2] drm/i915: Use I915_MAP_WC for execlists context buffer on the platforms without LLC Chris Wilson
2018-06-22 7:29 ` Zhao, Yakui
2018-06-22 7:36 ` Chris Wilson
2018-06-22 8:06 ` Zhao, Yakui [this message]
2018-06-22 8:10 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01363028D91B0B448414F51B4258CAA569F2DDB6@SHSMSX101.ccr.corp.intel.com \
--to=yakui.zhao@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.