From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Sylwester Nawrocki' <sylvester.nawrocki@gmail.com>,
'Vikas Sajjan' <vikas.sajjan@linaro.org>
Cc: linux-samsung-soc@vger.kernel.org, sachin.kamat@linaro.org,
t.figa@samsung.com, devicetree-discuss@lists.ozlabs.org,
inki.dae@samsung.com, jy0922.shim@samsung.com,
'sunil joshi' <joshi@samsung.com>
Subject: RE: [PATCH v6 5/5] ARM: dts: Add FIMD DT binding Documentation
Date: Thu, 07 Mar 2013 08:56:23 +0900 [thread overview]
Message-ID: <013901ce1ac6$3533b130$9f9b1390$%kim@samsung.com> (raw)
In-Reply-To: <5137B326.3040404@gmail.com>
Sylwester Nawrocki wrote:
>
> On 03/06/2013 10:13 PM, Sylwester Nawrocki wrote:
> > @@ -305,9 +305,9 @@ struct platform_device s5p_device_jpeg = {
> > #ifdef CONFIG_S5P_DEV_FIMD0
> > static struct resource s5p_fimd0_resource[] = {
> > [0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K),
> > - [1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC),
> > - [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO),
> > - [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM),
> > + [1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"),
> > + [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO, "fifo"),
> > + [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM, "system"),
> > };
>
> Oops, something missing here. Of course should be:
>
> @@ -160,9 +160,9 @@ struct platform_device samsung_asoc_idma = {
> #ifdef CONFIG_S3C_DEV_FB
> static struct resource s3c_fb_resource[] = {
> [0] = DEFINE_RES_MEM(S3C_PA_FB, SZ_16K),
> - [1] = DEFINE_RES_IRQ(IRQ_LCD_VSYNC),
> - [2] = DEFINE_RES_IRQ(IRQ_LCD_FIFO),
> - [3] = DEFINE_RES_IRQ(IRQ_LCD_SYSTEM),
> + [1] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_VSYNC, "vsync"),
> + [2] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_FIFO, "fifo"),
> + [3] = DEFINE_RES_IRQ_NAMED(IRQ_LCD_SYSTEM, "system"),
^^^^^^^
BTW, can you use 'tab' instead of white space at mark '^'
- Kukjin
next prev parent reply other threads:[~2013-03-06 23:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 9:42 [PATCH v6 0/5] Add DRM FIMD DT support for Exynos4 DT Machines Vikas Sajjan
2013-02-28 9:42 ` [PATCH v6 1/5] ARM: dts: Add FIMD node to exynos4 Vikas Sajjan
2013-02-28 9:42 ` [PATCH v6 2/5] ARM: dts: Add lcd pinctrl node entries for EXYNOS4412 SoC Vikas Sajjan
2013-02-28 9:42 ` [PATCH v6 3/5] ARM: dts: Add FIMD node and display timing node to exynos4412-origen.dts Vikas Sajjan
2013-02-28 9:42 ` [PATCH v6 4/5] ARM: dts: Add FIMD AUXDATA node entry for exynos4 DT Vikas Sajjan
2013-02-28 9:42 ` [PATCH v6 5/5] ARM: dts: Add FIMD DT binding Documentation Vikas Sajjan
2013-03-03 19:11 ` Sylwester Nawrocki
2013-03-03 20:03 ` Sylwester Nawrocki
2013-03-06 10:18 ` Vikas Sajjan
2013-03-06 21:13 ` Sylwester Nawrocki
2013-03-06 21:20 ` Sylwester Nawrocki
2013-03-06 23:56 ` Kukjin Kim [this message]
2013-03-07 6:50 ` Vikas Sajjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='013901ce1ac6$3533b130$9f9b1390$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=inki.dae@samsung.com \
--cc=joshi@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=sylvester.nawrocki@gmail.com \
--cc=t.figa@samsung.com \
--cc=vikas.sajjan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.