From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heinrich Schuchardt Date: Sat, 18 Nov 2017 00:09:11 +0100 Subject: [U-Boot] [PATCH v2 18/18] efi_loader: helper function to add EFI object to list In-Reply-To: References: <20171112140247.26532-1-xypron.glpk@gmx.de> <20171112140247.26532-19-xypron.glpk@gmx.de> Message-ID: <013b4b34-ca4e-7d03-6560-b4fde8e140a2@gmx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/17/2017 03:07 PM, Simon Glass wrote: > On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: >> To avoid duplicate coding provide a helper function that >> initializes an EFI object and adds it to the EFI object >> list. >> >> efi_exit() is the only place where we dereference a handle > > de-reference? Google spits out zillions of results for writing it without hyphen including online dictionaries. Regards Heinrich > >> to obtain a protocol interface. Add a comment to the function. >> >> Suggested-by: Alexander Graf >> Signed-off-by: Heinrich Schuchardt >> --- >> v2 >> new patch >> --- >> include/efi_loader.h | 2 ++ >> lib/efi_loader/efi_boottime.c | 39 ++++++++++++++++++++++++++++++++------- >> lib/efi_loader/efi_disk.c | 4 +--- >> lib/efi_loader/efi_gop.c | 4 +--- >> lib/efi_loader/efi_net.c | 4 +--- >> 5 files changed, 37 insertions(+), 16 deletions(-) > > Reviewed-by: Simon Glass >