From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size To: "Darrick J. Wong" , axboe@kernel.dk, akpm@linux-foundation.org References: <147510957066.8940.13803086684642725401.stgit@birch.djwong.org> <147510958448.8940.14280630935441533825.stgit@birch.djwong.org> Cc: linux-block@vger.kernel.org, tytso@mit.edu, martin.petersen@oracle.com, snitzer@redhat.com, linux-api@vger.kernel.org, bfoster@redhat.com, xfs@oss.sgi.com, hch@infradead.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, bart.vanassche@sandisk.com, Christoph Hellwig From: Hannes Reinecke Message-ID: <01403e58-6638-7c60-c195-5ab413f4ceb4@suse.de> Date: Thu, 29 Sep 2016 07:56:31 +0200 MIME-Version: 1.0 In-Reply-To: <147510958448.8940.14280630935441533825.stgit@birch.djwong.org> Content-Type: text/plain; charset=utf-8 List-ID: On 09/29/2016 02:39 AM, Darrick J. Wong wrote: > Make sure that the offset and length arguments that we're using to > construct WRITE SAME and DISCARD requests are actually aligned to the > logical block size. Failure to do this causes other errors in other > parts of the block layer or the SCSI layer because disks don't support > partial logical block writes. > > Signed-off-by: Darrick J. Wong > Reviewed-by: Christoph Hellwig > Reviewed-by: Bart Van Assche > Reviewed-by: Martin K. Petersen > --- > block/blk-lib.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 0E0DF7CA1 for ; Thu, 29 Sep 2016 00:56:35 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id D4824304032 for ; Wed, 28 Sep 2016 22:56:34 -0700 (PDT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by cuda.sgi.com with ESMTP id qJ9aTYZt4RFkdLRF (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 28 Sep 2016 22:56:33 -0700 (PDT) Subject: Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size References: <147510957066.8940.13803086684642725401.stgit@birch.djwong.org> <147510958448.8940.14280630935441533825.stgit@birch.djwong.org> From: Hannes Reinecke Message-ID: <01403e58-6638-7c60-c195-5ab413f4ceb4@suse.de> Date: Thu, 29 Sep 2016 07:56:31 +0200 MIME-Version: 1.0 In-Reply-To: <147510958448.8940.14280630935441533825.stgit@birch.djwong.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: "Darrick J. Wong" , axboe@kernel.dk, akpm@linux-foundation.org Cc: hch@infradead.org, tytso@mit.edu, martin.petersen@oracle.com, snitzer@redhat.com, linux-api@vger.kernel.org, bfoster@redhat.com, xfs@oss.sgi.com, linux-block@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, bart.vanassche@sandisk.com, Christoph Hellwig T24gMDkvMjkvMjAxNiAwMjozOSBBTSwgRGFycmljayBKLiBXb25nIHdyb3RlOgo+IE1ha2Ugc3Vy ZSB0aGF0IHRoZSBvZmZzZXQgYW5kIGxlbmd0aCBhcmd1bWVudHMgdGhhdCB3ZSdyZSB1c2luZyB0 bwo+IGNvbnN0cnVjdCBXUklURSBTQU1FIGFuZCBESVNDQVJEIHJlcXVlc3RzIGFyZSBhY3R1YWxs eSBhbGlnbmVkIHRvIHRoZQo+IGxvZ2ljYWwgYmxvY2sgc2l6ZS4gIEZhaWx1cmUgdG8gZG8gdGhp cyBjYXVzZXMgb3RoZXIgZXJyb3JzIGluIG90aGVyCj4gcGFydHMgb2YgdGhlIGJsb2NrIGxheWVy IG9yIHRoZSBTQ1NJIGxheWVyIGJlY2F1c2UgZGlza3MgZG9uJ3Qgc3VwcG9ydAo+IHBhcnRpYWwg bG9naWNhbCBibG9jayB3cml0ZXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogRGFycmljayBKLiBXb25n IDxkYXJyaWNrLndvbmdAb3JhY2xlLmNvbT4KPiBSZXZpZXdlZC1ieTogQ2hyaXN0b3BoIEhlbGx3 aWcgPGhjaEBsc3QuZGU+Cj4gUmV2aWV3ZWQtYnk6IEJhcnQgVmFuIEFzc2NoZSA8YmFydC52YW5h c3NjaGVAc2FuZGlzay5jb20+Cj4gUmV2aWV3ZWQtYnk6IE1hcnRpbiBLLiBQZXRlcnNlbiA8bWFy dGluLnBldGVyc2VuQG9yYWNsZS5jb20+Cj4gLS0tCj4gIGJsb2NrL2Jsay1saWIuYyB8ICAgMTUg KysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspCj4gClJl dmlld2VkLWJ5OiBIYW5uZXMgUmVpbmVja2UgPGhhcmVAc3VzZS5jb20+CgpDaGVlcnMsCgpIYW5u ZXMKLS0gCkRyLiBIYW5uZXMgUmVpbmVja2UJCSAgICAgIHpTZXJpZXMgJiBTdG9yYWdlCmhhcmVA c3VzZS5kZQkJCSAgICAgICs0OSA5MTEgNzQwNTMgNjg4ClNVU0UgTElOVVggUHJvZHVjdHMgR21i SCwgTWF4ZmVsZHN0ci4gNSwgOTA0MDkgTsO8cm5iZXJnCkdGOiBKLiBIYXduLCBKLiBHdWlsZCwg Ri4gSW1lbmTDtnJmZmVyLCBIUkIgMTY3NDYgKEFHIE7DvHJuYmVyZykKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCnhmcyBtYWlsaW5nIGxpc3QKeGZzQG9z cy5zZ2kuY29tCmh0dHA6Ly9vc3Muc2dpLmNvbS9tYWlsbWFuL2xpc3RpbmZvL3hmcwo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH 2/3] block: require write_same and discard requests align to logical block size Date: Thu, 29 Sep 2016 07:56:31 +0200 Message-ID: <01403e58-6638-7c60-c195-5ab413f4ceb4@suse.de> References: <147510957066.8940.13803086684642725401.stgit@birch.djwong.org> <147510958448.8940.14280630935441533825.stgit@birch.djwong.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <147510958448.8940.14280630935441533825.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Darrick J. Wong" , axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org Cc: linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tytso-3s7WtUTddSA@public.gmane.org, martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bfoster-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org, hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org, Christoph Hellwig List-Id: linux-api@vger.kernel.org On 09/29/2016 02:39 AM, Darrick J. Wong wrote: > Make sure that the offset and length arguments that we're using to > construct WRITE SAME and DISCARD requests are actually aligned to the > logical block size. Failure to do this causes other errors in other > parts of the block layer or the SCSI layer because disks don't support > partial logical block writes. > > Signed-off-by: Darrick J. Wong > Reviewed-by: Christoph Hellwig > Reviewed-by: Bart Van Assche > Reviewed-by: Martin K. Petersen > --- > block/blk-lib.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare-l3A5Bk7waGM@public.gmane.org +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)