From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christophe Leroy Date: Mon, 25 Mar 2019 15:25:24 +0000 Subject: Re: [PATCH v5 3/3] locking/rwsem: Optimize down_read_trylock() Message-Id: <014279a5-8998-8e03-adb3-c3d611dff171@c-s.fr> List-Id: References: <20190322143008.21313-1-longman@redhat.com> <20190322143008.21313-4-longman@redhat.com> In-Reply-To: <20190322143008.21313-4-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Waiman Long , Peter Zijlstra , Ingo Molnar , Will Deacon , Thomas Gleixner Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, linux-mips@vger.kernel.org, "H. Peter Anvin" , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Davidlohr Bueso , linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, x86@kernel.org, uclinux-h8-devel@lists.sourceforge.jp, linux-xtensa@linux-xtensa.org, Arnd Bergmann , linux-um@lists.infradead.org, linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, Borislav Petkov , linux-arm-kernel@lists.infradead.org, Tim Chen , linux-parisc@vger.kernel.org, Linus Torvalds , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.or Hi, Could you share the microbenchmark you are using ? I'd like to test the series on powerpc. Thanks Christophe Le 22/03/2019 à 15:30, Waiman Long a écrit : > Modify __down_read_trylock() to optimize for an unlocked rwsem and make > it generate slightly better code. > > Before this patch, down_read_trylock: > > 0x0000000000000000 <+0>: callq 0x5 > 0x0000000000000005 <+5>: jmp 0x18 > 0x0000000000000007 <+7>: lea 0x1(%rdx),%rcx > 0x000000000000000b <+11>: mov %rdx,%rax > 0x000000000000000e <+14>: lock cmpxchg %rcx,(%rdi) > 0x0000000000000013 <+19>: cmp %rax,%rdx > 0x0000000000000016 <+22>: je 0x23 > 0x0000000000000018 <+24>: mov (%rdi),%rdx > 0x000000000000001b <+27>: test %rdx,%rdx > 0x000000000000001e <+30>: jns 0x7 > 0x0000000000000020 <+32>: xor %eax,%eax > 0x0000000000000022 <+34>: retq > 0x0000000000000023 <+35>: mov %gs:0x0,%rax > 0x000000000000002c <+44>: or $0x3,%rax > 0x0000000000000030 <+48>: mov %rax,0x20(%rdi) > 0x0000000000000034 <+52>: mov $0x1,%eax > 0x0000000000000039 <+57>: retq > > After patch, down_read_trylock: > > 0x0000000000000000 <+0>: callq 0x5 > 0x0000000000000005 <+5>: xor %eax,%eax > 0x0000000000000007 <+7>: lea 0x1(%rax),%rdx > 0x000000000000000b <+11>: lock cmpxchg %rdx,(%rdi) > 0x0000000000000010 <+16>: jne 0x29 > 0x0000000000000012 <+18>: mov %gs:0x0,%rax > 0x000000000000001b <+27>: or $0x3,%rax > 0x000000000000001f <+31>: mov %rax,0x20(%rdi) > 0x0000000000000023 <+35>: mov $0x1,%eax > 0x0000000000000028 <+40>: retq > 0x0000000000000029 <+41>: test %rax,%rax > 0x000000000000002c <+44>: jns 0x7 > 0x000000000000002e <+46>: xor %eax,%eax > 0x0000000000000030 <+48>: retq > > By using a rwsem microbenchmark, the down_read_trylock() rate (with a > load of 10 to lengthen the lock critical section) on a x86-64 system > before and after the patch were: > > Before Patch After Patch > # of Threads rlock rlock > ------------ ----- ----- > 1 14,496 14,716 > 2 8,644 8,453 > 4 6,799 6,983 > 8 5,664 7,190 > > On a ARM64 system, the performance results were: > > Before Patch After Patch > # of Threads rlock rlock > ------------ ----- ----- > 1 23,676 24,488 > 2 7,697 9,502 > 4 4,945 3,440 > 8 2,641 1,603 > > For the uncontended case (1 thread), the new down_read_trylock() is a > little bit faster. For the contended cases, the new down_read_trylock() > perform pretty well in x86-64, but performance degrades at high > contention level on ARM64. > > Suggested-by: Linus Torvalds > Signed-off-by: Waiman Long > --- > kernel/locking/rwsem.h | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/kernel/locking/rwsem.h b/kernel/locking/rwsem.h > index 45ee00236e03..1f5775aa6a1d 100644 > --- a/kernel/locking/rwsem.h > +++ b/kernel/locking/rwsem.h > @@ -174,14 +174,17 @@ static inline int __down_read_killable(struct rw_semaphore *sem) > > static inline int __down_read_trylock(struct rw_semaphore *sem) > { > - long tmp; > + /* > + * Optimize for the case when the rwsem is not locked at all. > + */ > + long tmp = RWSEM_UNLOCKED_VALUE; > > - while ((tmp = atomic_long_read(&sem->count)) >= 0) { > - if (tmp = atomic_long_cmpxchg_acquire(&sem->count, tmp, > - tmp + RWSEM_ACTIVE_READ_BIAS)) { > + do { > + if (atomic_long_try_cmpxchg_acquire(&sem->count, &tmp, > + tmp + RWSEM_ACTIVE_READ_BIAS)) { > return 1; > } > - } > + } while (tmp >= 0); > return 0; > } > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7F02C43381 for ; Mon, 25 Mar 2019 15:25:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD28A2087E for ; Mon, 25 Mar 2019 15:25:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="Gb0MkZXr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729473AbfCYPZa (ORCPT ); Mon, 25 Mar 2019 11:25:30 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:45723 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725810AbfCYPZ2 (ORCPT ); Mon, 25 Mar 2019 11:25:28 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 44SdPD2xnBz9v0lr; Mon, 25 Mar 2019 16:25:20 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=Gb0MkZXr; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id CrK4rxgSxrO3; Mon, 25 Mar 2019 16:25:20 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 44SdPD1fbZz9tyDn; Mon, 25 Mar 2019 16:25:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1553527520; bh=JrL7MExoxenGmOAA8+6zfD5VS8gV08AijePqq6+rivY=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Gb0MkZXr4cfDzR19n8lna6H+IPA5AH3vZL1jNvOtCev91KCVbckg3/MYHKcjqkio5 h3ZxOQHblb9nHvTSJ7+rGRyQcDlyWn4FJ8MQkFBX2AdS6cvQu/8kr1/7uriihL47lA Q8KeTVo/1kkW9DTDs2sH3feGWWW85xlVR3ifVPe8= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 464268B8AB; Mon, 25 Mar 2019 16:25:25 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id PjtKP9S86Vzq; Mon, 25 Mar 2019 16:25:25 +0100 (CET) Received: from PO15451 (po15451.idsi0.si.c-s.fr [172.25.231.2]) by messagerie.si.c-s.fr (Postfix) with ESMTP id DA4758B74F; Mon, 25 Mar 2019 16:25:24 +0100 (CET) Subject: Re: [PATCH v5 3/3] locking/rwsem: Optimize down_read_trylock() To: Waiman Long , Peter Zijlstra , Ingo Molnar , Will Deacon , Thomas Gleixner Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, linux-mips@vger.kernel.org, "H. Peter Anvin" , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Davidlohr Bueso , linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, x86@kernel.org, uclinux-h8-devel@lists.sourceforge.jp, linux-xtensa@linux-xtensa.org, Arnd Bergmann , linux-um@lists.infradead.org, linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, Borislav Petkov , linux-arm-kernel@lists.infradead.org, Tim Chen , linux-parisc@vger.kernel.org, Linus Torvalds , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, nios2-dev@lists.rocketboards.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org References: <20190322143008.21313-1-longman@redhat.com> <20190322143008.21313-4-longman@redhat.com> From: Christophe Leroy Message-ID: <014279a5-8998-8e03-adb3-c3d611dff171@c-s.fr> Date: Mon, 25 Mar 2019 16:25:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190322143008.21313-4-longman@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org Hi, Could you share the microbenchmark you are using ? I'd like to test the series on powerpc. Thanks Christophe Le 22/03/2019 à 15:30, Waiman Long a écrit : > Modify __down_read_trylock() to optimize for an unlocked rwsem and make > it generate slightly better code. > > Before this patch, down_read_trylock: > > 0x0000000000000000 <+0>: callq 0x5 > 0x0000000000000005 <+5>: jmp 0x18 > 0x0000000000000007 <+7>: lea 0x1(%rdx),%rcx > 0x000000000000000b <+11>: mov %rdx,%rax > 0x000000000000000e <+14>: lock cmpxchg %rcx,(%rdi) > 0x0000000000000013 <+19>: cmp %rax,%rdx > 0x0000000000000016 <+22>: je 0x23 > 0x0000000000000018 <+24>: mov (%rdi),%rdx > 0x000000000000001b <+27>: test %rdx,%rdx > 0x000000000000001e <+30>: jns 0x7 > 0x0000000000000020 <+32>: xor %eax,%eax > 0x0000000000000022 <+34>: retq > 0x0000000000000023 <+35>: mov %gs:0x0,%rax > 0x000000000000002c <+44>: or $0x3,%rax > 0x0000000000000030 <+48>: mov %rax,0x20(%rdi) > 0x0000000000000034 <+52>: mov $0x1,%eax > 0x0000000000000039 <+57>: retq > > After patch, down_read_trylock: > > 0x0000000000000000 <+0>: callq 0x5 > 0x0000000000000005 <+5>: xor %eax,%eax > 0x0000000000000007 <+7>: lea 0x1(%rax),%rdx > 0x000000000000000b <+11>: lock cmpxchg %rdx,(%rdi) > 0x0000000000000010 <+16>: jne 0x29 > 0x0000000000000012 <+18>: mov %gs:0x0,%rax > 0x000000000000001b <+27>: or $0x3,%rax > 0x000000000000001f <+31>: mov %rax,0x20(%rdi) > 0x0000000000000023 <+35>: mov $0x1,%eax > 0x0000000000000028 <+40>: retq > 0x0000000000000029 <+41>: test %rax,%rax > 0x000000000000002c <+44>: jns 0x7 > 0x000000000000002e <+46>: xor %eax,%eax > 0x0000000000000030 <+48>: retq > > By using a rwsem microbenchmark, the down_read_trylock() rate (with a > load of 10 to lengthen the lock critical section) on a x86-64 system > before and after the patch were: > > Before Patch After Patch > # of Threads rlock rlock > ------------ ----- ----- > 1 14,496 14,716 > 2 8,644 8,453 > 4 6,799 6,983 > 8 5,664 7,190 > > On a ARM64 system, the performance results were: > > Before Patch After Patch > # of Threads rlock rlock > ------------ ----- ----- > 1 23,676 24,488 > 2 7,697 9,502 > 4 4,945 3,440 > 8 2,641 1,603 > > For the uncontended case (1 thread), the new down_read_trylock() is a > little bit faster. For the contended cases, the new down_read_trylock() > perform pretty well in x86-64, but performance degrades at high > contention level on ARM64. > > Suggested-by: Linus Torvalds > Signed-off-by: Waiman Long > --- > kernel/locking/rwsem.h | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/kernel/locking/rwsem.h b/kernel/locking/rwsem.h > index 45ee00236e03..1f5775aa6a1d 100644 > --- a/kernel/locking/rwsem.h > +++ b/kernel/locking/rwsem.h > @@ -174,14 +174,17 @@ static inline int __down_read_killable(struct rw_semaphore *sem) > > static inline int __down_read_trylock(struct rw_semaphore *sem) > { > - long tmp; > + /* > + * Optimize for the case when the rwsem is not locked at all. > + */ > + long tmp = RWSEM_UNLOCKED_VALUE; > > - while ((tmp = atomic_long_read(&sem->count)) >= 0) { > - if (tmp == atomic_long_cmpxchg_acquire(&sem->count, tmp, > - tmp + RWSEM_ACTIVE_READ_BIAS)) { > + do { > + if (atomic_long_try_cmpxchg_acquire(&sem->count, &tmp, > + tmp + RWSEM_ACTIVE_READ_BIAS)) { > return 1; > } > - } > + } while (tmp >= 0); > return 0; > } > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christophe Leroy Subject: Re: [PATCH v5 3/3] locking/rwsem: Optimize down_read_trylock() Date: Mon, 25 Mar 2019 16:25:24 +0100 Message-ID: <014279a5-8998-8e03-adb3-c3d611dff171@c-s.fr> References: <20190322143008.21313-1-longman@redhat.com> <20190322143008.21313-4-longman@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190322143008.21313-4-longman@redhat.com> Content-Language: fr Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Waiman Long , Peter Zijlstra , Ingo Molnar , Will Deacon , Thomas Gleixner Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, linux-mips@vger.kernel.org, "H. Peter Anvin" , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Davidlohr Bueso , linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, x86@kernel.org, uclinux-h8-devel@lists.sourceforge.jp, linux-xtensa@linux-xtensa.org, Arnd Bergmann , linux-um@lists.infradead.org, linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, Borislav Petkov , linux-arm-kernel@lists.infradead.org, Tim Chen , linux-parisc@vger.kernel.org, Linus Torvalds , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.or List-ID: Hi, Could you share the microbenchmark you are using ? I'd like to test the series on powerpc. Thanks Christophe Le 22/03/2019 à 15:30, Waiman Long a écrit : > Modify __down_read_trylock() to optimize for an unlocked rwsem and make > it generate slightly better code. > > Before this patch, down_read_trylock: > > 0x0000000000000000 <+0>: callq 0x5 > 0x0000000000000005 <+5>: jmp 0x18 > 0x0000000000000007 <+7>: lea 0x1(%rdx),%rcx > 0x000000000000000b <+11>: mov %rdx,%rax > 0x000000000000000e <+14>: lock cmpxchg %rcx,(%rdi) > 0x0000000000000013 <+19>: cmp %rax,%rdx > 0x0000000000000016 <+22>: je 0x23 > 0x0000000000000018 <+24>: mov (%rdi),%rdx > 0x000000000000001b <+27>: test %rdx,%rdx > 0x000000000000001e <+30>: jns 0x7 > 0x0000000000000020 <+32>: xor %eax,%eax > 0x0000000000000022 <+34>: retq > 0x0000000000000023 <+35>: mov %gs:0x0,%rax > 0x000000000000002c <+44>: or $0x3,%rax > 0x0000000000000030 <+48>: mov %rax,0x20(%rdi) > 0x0000000000000034 <+52>: mov $0x1,%eax > 0x0000000000000039 <+57>: retq > > After patch, down_read_trylock: > > 0x0000000000000000 <+0>: callq 0x5 > 0x0000000000000005 <+5>: xor %eax,%eax > 0x0000000000000007 <+7>: lea 0x1(%rax),%rdx > 0x000000000000000b <+11>: lock cmpxchg %rdx,(%rdi) > 0x0000000000000010 <+16>: jne 0x29 > 0x0000000000000012 <+18>: mov %gs:0x0,%rax > 0x000000000000001b <+27>: or $0x3,%rax > 0x000000000000001f <+31>: mov %rax,0x20(%rdi) > 0x0000000000000023 <+35>: mov $0x1,%eax > 0x0000000000000028 <+40>: retq > 0x0000000000000029 <+41>: test %rax,%rax > 0x000000000000002c <+44>: jns 0x7 > 0x000000000000002e <+46>: xor %eax,%eax > 0x0000000000000030 <+48>: retq > > By using a rwsem microbenchmark, the down_read_trylock() rate (with a > load of 10 to lengthen the lock critical section) on a x86-64 system > before and after the patch were: > > Before Patch After Patch > # of Threads rlock rlock > ------------ ----- ----- > 1 14,496 14,716 > 2 8,644 8,453 > 4 6,799 6,983 > 8 5,664 7,190 > > On a ARM64 system, the performance results were: > > Before Patch After Patch > # of Threads rlock rlock > ------------ ----- ----- > 1 23,676 24,488 > 2 7,697 9,502 > 4 4,945 3,440 > 8 2,641 1,603 > > For the uncontended case (1 thread), the new down_read_trylock() is a > little bit faster. For the contended cases, the new down_read_trylock() > perform pretty well in x86-64, but performance degrades at high > contention level on ARM64. > > Suggested-by: Linus Torvalds > Signed-off-by: Waiman Long > --- > kernel/locking/rwsem.h | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/kernel/locking/rwsem.h b/kernel/locking/rwsem.h > index 45ee00236e03..1f5775aa6a1d 100644 > --- a/kernel/locking/rwsem.h > +++ b/kernel/locking/rwsem.h > @@ -174,14 +174,17 @@ static inline int __down_read_killable(struct rw_semaphore *sem) > > static inline int __down_read_trylock(struct rw_semaphore *sem) > { > - long tmp; > + /* > + * Optimize for the case when the rwsem is not locked at all. > + */ > + long tmp = RWSEM_UNLOCKED_VALUE; > > - while ((tmp = atomic_long_read(&sem->count)) >= 0) { > - if (tmp == atomic_long_cmpxchg_acquire(&sem->count, tmp, > - tmp + RWSEM_ACTIVE_READ_BIAS)) { > + do { > + if (atomic_long_try_cmpxchg_acquire(&sem->count, &tmp, > + tmp + RWSEM_ACTIVE_READ_BIAS)) { > return 1; > } > - } > + } while (tmp >= 0); > return 0; > } > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10923C43381 for ; Mon, 25 Mar 2019 15:25:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7989D20896 for ; Mon, 25 Mar 2019 15:25:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eiauUUBz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="Gb0MkZXr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7989D20896 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EJg9HUXbKgqO1bgc5RPs01+N1h9++yKyACfOqYvgdsA=; b=eiauUUBzTyfpDl4O8Psndu88L DXuqMqTawCNAkFKCoESm2uYzffgtYxxqg0LaoS+TsNCarn5zYGRXDe3cIdyIPz17TUyViGMTCqLCD zunhFThzW4mhqqAiBBaFcr1zxPSO8OoxoGKOhMJDVhLcFQn/eHZDU7jXp4YNRaH+uKmTg0oaw6dRE TFq5Dse2ep1urNb1V8J9fvdy3cw3XHw0MaeFKkH4X9k6dir8wzFavjWZIkJrlRliF7oXNjmFtulwt TJH0YPxfo0362juJtAc1sKNrn/kd/cBpweqiFmAAJ5tYJwxTtIz1AOdHbH2KafRZA9/67ZlQLHe3o tkl2GxDhg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8RTt-00033D-2M; Mon, 25 Mar 2019 15:25:45 +0000 Received: from pegase1.c-s.fr ([93.17.236.30]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8RTj-0002vy-4v; Mon, 25 Mar 2019 15:25:37 +0000 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 44SdPD2xnBz9v0lr; Mon, 25 Mar 2019 16:25:20 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=Gb0MkZXr; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id CrK4rxgSxrO3; Mon, 25 Mar 2019 16:25:20 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 44SdPD1fbZz9tyDn; Mon, 25 Mar 2019 16:25:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1553527520; bh=JrL7MExoxenGmOAA8+6zfD5VS8gV08AijePqq6+rivY=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Gb0MkZXr4cfDzR19n8lna6H+IPA5AH3vZL1jNvOtCev91KCVbckg3/MYHKcjqkio5 h3ZxOQHblb9nHvTSJ7+rGRyQcDlyWn4FJ8MQkFBX2AdS6cvQu/8kr1/7uriihL47lA Q8KeTVo/1kkW9DTDs2sH3feGWWW85xlVR3ifVPe8= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 464268B8AB; Mon, 25 Mar 2019 16:25:25 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id PjtKP9S86Vzq; Mon, 25 Mar 2019 16:25:25 +0100 (CET) Received: from PO15451 (po15451.idsi0.si.c-s.fr [172.25.231.2]) by messagerie.si.c-s.fr (Postfix) with ESMTP id DA4758B74F; Mon, 25 Mar 2019 16:25:24 +0100 (CET) Subject: Re: [PATCH v5 3/3] locking/rwsem: Optimize down_read_trylock() To: Waiman Long , Peter Zijlstra , Ingo Molnar , Will Deacon , Thomas Gleixner References: <20190322143008.21313-1-longman@redhat.com> <20190322143008.21313-4-longman@redhat.com> From: Christophe Leroy Message-ID: <014279a5-8998-8e03-adb3-c3d611dff171@c-s.fr> Date: Mon, 25 Mar 2019 16:25:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190322143008.21313-4-longman@redhat.com> Content-Language: fr X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190325_082535_502312_5688C77E X-CRM114-Status: GOOD ( 22.59 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, "H. Peter Anvin" , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Davidlohr Bueso , linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, x86@kernel.org, uclinux-h8-devel@lists.sourceforge.jp, linux-xtensa@linux-xtensa.org, Arnd Bergmann , linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, Borislav Petkov , linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, Linus Torvalds , linux-mips@vger.kernel.org, linux-alpha@vger.kernel.org, nios2-dev@lists.rocketboards.org, Andrew Morton , Tim Chen Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org SGksCgpDb3VsZCB5b3Ugc2hhcmUgdGhlIG1pY3JvYmVuY2htYXJrIHlvdSBhcmUgdXNpbmcgPwoK SSdkIGxpa2UgdG8gdGVzdCB0aGUgc2VyaWVzIG9uIHBvd2VycGMuCgpUaGFua3MKQ2hyaXN0b3Bo ZQoKTGUgMjIvMDMvMjAxOSDDoCAxNTozMCwgV2FpbWFuIExvbmcgYSDDqWNyaXTCoDoKPiBNb2Rp ZnkgX19kb3duX3JlYWRfdHJ5bG9jaygpIHRvIG9wdGltaXplIGZvciBhbiB1bmxvY2tlZCByd3Nl bSBhbmQgbWFrZQo+IGl0IGdlbmVyYXRlIHNsaWdodGx5IGJldHRlciBjb2RlLgo+IAo+IEJlZm9y ZSB0aGlzIHBhdGNoLCBkb3duX3JlYWRfdHJ5bG9jazoKPiAKPiAgICAgMHgwMDAwMDAwMDAwMDAw MDAwIDwrMD46ICAgICBjYWxscSAgMHg1IDxkb3duX3JlYWRfdHJ5bG9jays1Pgo+ICAgICAweDAw MDAwMDAwMDAwMDAwMDUgPCs1PjogICAgIGptcCAgICAweDE4IDxkb3duX3JlYWRfdHJ5bG9jaysy ND4KPiAgICAgMHgwMDAwMDAwMDAwMDAwMDA3IDwrNz46ICAgICBsZWEgICAgMHgxKCVyZHgpLCVy Y3gKPiAgICAgMHgwMDAwMDAwMDAwMDAwMDBiIDwrMTE+OiAgICBtb3YgICAgJXJkeCwlcmF4Cj4g ICAgIDB4MDAwMDAwMDAwMDAwMDAwZSA8KzE0PjogICAgbG9jayBjbXB4Y2hnICVyY3gsKCVyZGkp Cj4gICAgIDB4MDAwMDAwMDAwMDAwMDAxMyA8KzE5PjogICAgY21wICAgICVyYXgsJXJkeAo+ICAg ICAweDAwMDAwMDAwMDAwMDAwMTYgPCsyMj46ICAgIGplICAgICAweDIzIDxkb3duX3JlYWRfdHJ5 bG9jayszNT4KPiAgICAgMHgwMDAwMDAwMDAwMDAwMDE4IDwrMjQ+OiAgICBtb3YgICAgKCVyZGkp LCVyZHgKPiAgICAgMHgwMDAwMDAwMDAwMDAwMDFiIDwrMjc+OiAgICB0ZXN0ICAgJXJkeCwlcmR4 Cj4gICAgIDB4MDAwMDAwMDAwMDAwMDAxZSA8KzMwPjogICAgam5zICAgIDB4NyA8ZG93bl9yZWFk X3RyeWxvY2srNz4KPiAgICAgMHgwMDAwMDAwMDAwMDAwMDIwIDwrMzI+OiAgICB4b3IgICAgJWVh eCwlZWF4Cj4gICAgIDB4MDAwMDAwMDAwMDAwMDAyMiA8KzM0PjogICAgcmV0cQo+ICAgICAweDAw MDAwMDAwMDAwMDAwMjMgPCszNT46ICAgIG1vdiAgICAlZ3M6MHgwLCVyYXgKPiAgICAgMHgwMDAw MDAwMDAwMDAwMDJjIDwrNDQ+OiAgICBvciAgICAgJDB4MywlcmF4Cj4gICAgIDB4MDAwMDAwMDAw MDAwMDAzMCA8KzQ4PjogICAgbW92ICAgICVyYXgsMHgyMCglcmRpKQo+ICAgICAweDAwMDAwMDAw MDAwMDAwMzQgPCs1Mj46ICAgIG1vdiAgICAkMHgxLCVlYXgKPiAgICAgMHgwMDAwMDAwMDAwMDAw MDM5IDwrNTc+OiAgICByZXRxCj4gCj4gQWZ0ZXIgcGF0Y2gsIGRvd25fcmVhZF90cnlsb2NrOgo+ IAo+ICAgICAweDAwMDAwMDAwMDAwMDAwMDAgPCswPjoJY2FsbHEgIDB4NSA8ZG93bl9yZWFkX3Ry eWxvY2srNT4KPiAgICAgMHgwMDAwMDAwMDAwMDAwMDA1IDwrNT46CXhvciAgICAlZWF4LCVlYXgK PiAgICAgMHgwMDAwMDAwMDAwMDAwMDA3IDwrNz46CWxlYSAgICAweDEoJXJheCksJXJkeAo+ICAg ICAweDAwMDAwMDAwMDAwMDAwMGIgPCsxMT46CWxvY2sgY21weGNoZyAlcmR4LCglcmRpKQo+ICAg ICAweDAwMDAwMDAwMDAwMDAwMTAgPCsxNj46CWpuZSAgICAweDI5IDxkb3duX3JlYWRfdHJ5bG9j ays0MT4KPiAgICAgMHgwMDAwMDAwMDAwMDAwMDEyIDwrMTg+Ogltb3YgICAgJWdzOjB4MCwlcmF4 Cj4gICAgIDB4MDAwMDAwMDAwMDAwMDAxYiA8KzI3PjoJb3IgICAgICQweDMsJXJheAo+ICAgICAw eDAwMDAwMDAwMDAwMDAwMWYgPCszMT46CW1vdiAgICAlcmF4LDB4MjAoJXJkaSkKPiAgICAgMHgw MDAwMDAwMDAwMDAwMDIzIDwrMzU+Ogltb3YgICAgJDB4MSwlZWF4Cj4gICAgIDB4MDAwMDAwMDAw MDAwMDAyOCA8KzQwPjoJcmV0cQo+ICAgICAweDAwMDAwMDAwMDAwMDAwMjkgPCs0MT46CXRlc3Qg ICAlcmF4LCVyYXgKPiAgICAgMHgwMDAwMDAwMDAwMDAwMDJjIDwrNDQ+OglqbnMgICAgMHg3IDxk b3duX3JlYWRfdHJ5bG9jays3Pgo+ICAgICAweDAwMDAwMDAwMDAwMDAwMmUgPCs0Nj46CXhvciAg ICAlZWF4LCVlYXgKPiAgICAgMHgwMDAwMDAwMDAwMDAwMDMwIDwrNDg+OglyZXRxCj4gCj4gQnkg dXNpbmcgYSByd3NlbSBtaWNyb2JlbmNobWFyaywgdGhlIGRvd25fcmVhZF90cnlsb2NrKCkgcmF0 ZSAod2l0aCBhCj4gbG9hZCBvZiAxMCB0byBsZW5ndGhlbiB0aGUgbG9jayBjcml0aWNhbCBzZWN0 aW9uKSBvbiBhIHg4Ni02NCBzeXN0ZW0KPiBiZWZvcmUgYW5kIGFmdGVyIHRoZSBwYXRjaCB3ZXJl Ogo+IAo+ICAgICAgICAgICAgICAgICAgIEJlZm9yZSBQYXRjaCAgICBBZnRlciBQYXRjaAo+ICAg ICAjIG9mIFRocmVhZHMgICAgIHJsb2NrICAgICAgICAgICBybG9jawo+ICAgICAtLS0tLS0tLS0t LS0gICAgIC0tLS0tICAgICAgICAgICAtLS0tLQo+ICAgICAgICAgIDEgICAgICAgICAgIDE0LDQ5 NiAgICAgICAgICAxNCw3MTYKPiAgICAgICAgICAyICAgICAgICAgICAgOCw2NDQgICAgICAgICAg IDgsNDUzCj4gCTQgICAgICAgICAgICA2LDc5OSAgICAgICAgICAgNiw5ODMKPiAJOCAgICAgICAg ICAgIDUsNjY0ICAgICAgICAgICA3LDE5MAo+IAo+IE9uIGEgQVJNNjQgc3lzdGVtLCB0aGUgcGVy Zm9ybWFuY2UgcmVzdWx0cyB3ZXJlOgo+IAo+ICAgICAgICAgICAgICAgICAgIEJlZm9yZSBQYXRj aCAgICBBZnRlciBQYXRjaAo+ICAgICAjIG9mIFRocmVhZHMgICAgIHJsb2NrICAgICAgICAgICBy bG9jawo+ICAgICAtLS0tLS0tLS0tLS0gICAgIC0tLS0tICAgICAgICAgICAtLS0tLQo+ICAgICAg ICAgIDEgICAgICAgICAgIDIzLDY3NiAgICAgICAgICAyNCw0ODgKPiAgICAgICAgICAyICAgICAg ICAgICAgNyw2OTcgICAgICAgICAgIDksNTAyCj4gICAgICAgICAgNCAgICAgICAgICAgIDQsOTQ1 ICAgICAgICAgICAzLDQ0MAo+ICAgICAgICAgIDggICAgICAgICAgICAyLDY0MSAgICAgICAgICAg MSw2MDMKPiAKPiBGb3IgdGhlIHVuY29udGVuZGVkIGNhc2UgKDEgdGhyZWFkKSwgdGhlIG5ldyBk b3duX3JlYWRfdHJ5bG9jaygpIGlzIGEKPiBsaXR0bGUgYml0IGZhc3Rlci4gRm9yIHRoZSBjb250 ZW5kZWQgY2FzZXMsIHRoZSBuZXcgZG93bl9yZWFkX3RyeWxvY2soKQo+IHBlcmZvcm0gcHJldHR5 IHdlbGwgaW4geDg2LTY0LCBidXQgcGVyZm9ybWFuY2UgZGVncmFkZXMgYXQgaGlnaAo+IGNvbnRl bnRpb24gbGV2ZWwgb24gQVJNNjQuCj4gCj4gU3VnZ2VzdGVkLWJ5OiBMaW51cyBUb3J2YWxkcyA8 dG9ydmFsZHNAbGludXgtZm91bmRhdGlvbi5vcmc+Cj4gU2lnbmVkLW9mZi1ieTogV2FpbWFuIExv bmcgPGxvbmdtYW5AcmVkaGF0LmNvbT4KPiAtLS0KPiAgIGtlcm5lbC9sb2NraW5nL3J3c2VtLmgg fCAxMyArKysrKysrKy0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA1 IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9rZXJuZWwvbG9ja2luZy9yd3NlbS5oIGIv a2VybmVsL2xvY2tpbmcvcndzZW0uaAo+IGluZGV4IDQ1ZWUwMDIzNmUwMy4uMWY1Nzc1YWE2YTFk IDEwMDY0NAo+IC0tLSBhL2tlcm5lbC9sb2NraW5nL3J3c2VtLmgKPiArKysgYi9rZXJuZWwvbG9j a2luZy9yd3NlbS5oCj4gQEAgLTE3NCwxNCArMTc0LDE3IEBAIHN0YXRpYyBpbmxpbmUgaW50IF9f ZG93bl9yZWFkX2tpbGxhYmxlKHN0cnVjdCByd19zZW1hcGhvcmUgKnNlbSkKPiAgIAo+ICAgc3Rh dGljIGlubGluZSBpbnQgX19kb3duX3JlYWRfdHJ5bG9jayhzdHJ1Y3Qgcndfc2VtYXBob3JlICpz ZW0pCj4gICB7Cj4gLQlsb25nIHRtcDsKPiArCS8qCj4gKwkgKiBPcHRpbWl6ZSBmb3IgdGhlIGNh c2Ugd2hlbiB0aGUgcndzZW0gaXMgbm90IGxvY2tlZCBhdCBhbGwuCj4gKwkgKi8KPiArCWxvbmcg dG1wID0gUldTRU1fVU5MT0NLRURfVkFMVUU7Cj4gICAKPiAtCXdoaWxlICgodG1wID0gYXRvbWlj X2xvbmdfcmVhZCgmc2VtLT5jb3VudCkpID49IDApIHsKPiAtCQlpZiAodG1wID09IGF0b21pY19s b25nX2NtcHhjaGdfYWNxdWlyZSgmc2VtLT5jb3VudCwgdG1wLAo+IC0JCQkJICAgdG1wICsgUldT RU1fQUNUSVZFX1JFQURfQklBUykpIHsKPiArCWRvIHsKPiArCQlpZiAoYXRvbWljX2xvbmdfdHJ5 X2NtcHhjaGdfYWNxdWlyZSgmc2VtLT5jb3VudCwgJnRtcCwKPiArCQkJCQl0bXAgKyBSV1NFTV9B Q1RJVkVfUkVBRF9CSUFTKSkgewo+ICAgCQkJcmV0dXJuIDE7Cj4gICAJCX0KPiAtCX0KPiArCX0g d2hpbGUgKHRtcCA+PSAwKTsKPiAgIAlyZXR1cm4gMDsKPiAgIH0KPiAgIAo+IAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGlu ZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 980F9C43381 for ; Mon, 25 Mar 2019 15:28:55 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDC3220811 for ; Mon, 25 Mar 2019 15:28:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="Gb0MkZXr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDC3220811 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44SdTJ65vQzDqJX for ; Tue, 26 Mar 2019 02:28:52 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=c-s.fr (client-ip=93.17.236.30; helo=pegase1.c-s.fr; envelope-from=christophe.leroy@c-s.fr; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=c-s.fr header.i=@c-s.fr header.b="Gb0MkZXr"; dkim-atps=neutral Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44SdPT3W0XzDqH5 for ; Tue, 26 Mar 2019 02:25:30 +1100 (AEDT) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 44SdPD2xnBz9v0lr; Mon, 25 Mar 2019 16:25:20 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=Gb0MkZXr; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id CrK4rxgSxrO3; Mon, 25 Mar 2019 16:25:20 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 44SdPD1fbZz9tyDn; Mon, 25 Mar 2019 16:25:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1553527520; bh=JrL7MExoxenGmOAA8+6zfD5VS8gV08AijePqq6+rivY=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Gb0MkZXr4cfDzR19n8lna6H+IPA5AH3vZL1jNvOtCev91KCVbckg3/MYHKcjqkio5 h3ZxOQHblb9nHvTSJ7+rGRyQcDlyWn4FJ8MQkFBX2AdS6cvQu/8kr1/7uriihL47lA Q8KeTVo/1kkW9DTDs2sH3feGWWW85xlVR3ifVPe8= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 464268B8AB; Mon, 25 Mar 2019 16:25:25 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id PjtKP9S86Vzq; Mon, 25 Mar 2019 16:25:25 +0100 (CET) Received: from PO15451 (po15451.idsi0.si.c-s.fr [172.25.231.2]) by messagerie.si.c-s.fr (Postfix) with ESMTP id DA4758B74F; Mon, 25 Mar 2019 16:25:24 +0100 (CET) Subject: Re: [PATCH v5 3/3] locking/rwsem: Optimize down_read_trylock() To: Waiman Long , Peter Zijlstra , Ingo Molnar , Will Deacon , Thomas Gleixner References: <20190322143008.21313-1-longman@redhat.com> <20190322143008.21313-4-longman@redhat.com> From: Christophe Leroy Message-ID: <014279a5-8998-8e03-adb3-c3d611dff171@c-s.fr> Date: Mon, 25 Mar 2019 16:25:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190322143008.21313-4-longman@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, "H. Peter Anvin" , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Davidlohr Bueso , linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, x86@kernel.org, uclinux-h8-devel@lists.sourceforge.jp, linux-xtensa@linux-xtensa.org, Arnd Bergmann , linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, Borislav Petkov , linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, Linus Torvalds , linux-mips@vger.kernel.org, linux-alpha@vger.kernel.org, nios2-dev@lists.rocketboards.org, Andrew Morton , Tim Chen Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi, Could you share the microbenchmark you are using ? I'd like to test the series on powerpc. Thanks Christophe Le 22/03/2019 à 15:30, Waiman Long a écrit : > Modify __down_read_trylock() to optimize for an unlocked rwsem and make > it generate slightly better code. > > Before this patch, down_read_trylock: > > 0x0000000000000000 <+0>: callq 0x5 > 0x0000000000000005 <+5>: jmp 0x18 > 0x0000000000000007 <+7>: lea 0x1(%rdx),%rcx > 0x000000000000000b <+11>: mov %rdx,%rax > 0x000000000000000e <+14>: lock cmpxchg %rcx,(%rdi) > 0x0000000000000013 <+19>: cmp %rax,%rdx > 0x0000000000000016 <+22>: je 0x23 > 0x0000000000000018 <+24>: mov (%rdi),%rdx > 0x000000000000001b <+27>: test %rdx,%rdx > 0x000000000000001e <+30>: jns 0x7 > 0x0000000000000020 <+32>: xor %eax,%eax > 0x0000000000000022 <+34>: retq > 0x0000000000000023 <+35>: mov %gs:0x0,%rax > 0x000000000000002c <+44>: or $0x3,%rax > 0x0000000000000030 <+48>: mov %rax,0x20(%rdi) > 0x0000000000000034 <+52>: mov $0x1,%eax > 0x0000000000000039 <+57>: retq > > After patch, down_read_trylock: > > 0x0000000000000000 <+0>: callq 0x5 > 0x0000000000000005 <+5>: xor %eax,%eax > 0x0000000000000007 <+7>: lea 0x1(%rax),%rdx > 0x000000000000000b <+11>: lock cmpxchg %rdx,(%rdi) > 0x0000000000000010 <+16>: jne 0x29 > 0x0000000000000012 <+18>: mov %gs:0x0,%rax > 0x000000000000001b <+27>: or $0x3,%rax > 0x000000000000001f <+31>: mov %rax,0x20(%rdi) > 0x0000000000000023 <+35>: mov $0x1,%eax > 0x0000000000000028 <+40>: retq > 0x0000000000000029 <+41>: test %rax,%rax > 0x000000000000002c <+44>: jns 0x7 > 0x000000000000002e <+46>: xor %eax,%eax > 0x0000000000000030 <+48>: retq > > By using a rwsem microbenchmark, the down_read_trylock() rate (with a > load of 10 to lengthen the lock critical section) on a x86-64 system > before and after the patch were: > > Before Patch After Patch > # of Threads rlock rlock > ------------ ----- ----- > 1 14,496 14,716 > 2 8,644 8,453 > 4 6,799 6,983 > 8 5,664 7,190 > > On a ARM64 system, the performance results were: > > Before Patch After Patch > # of Threads rlock rlock > ------------ ----- ----- > 1 23,676 24,488 > 2 7,697 9,502 > 4 4,945 3,440 > 8 2,641 1,603 > > For the uncontended case (1 thread), the new down_read_trylock() is a > little bit faster. For the contended cases, the new down_read_trylock() > perform pretty well in x86-64, but performance degrades at high > contention level on ARM64. > > Suggested-by: Linus Torvalds > Signed-off-by: Waiman Long > --- > kernel/locking/rwsem.h | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/kernel/locking/rwsem.h b/kernel/locking/rwsem.h > index 45ee00236e03..1f5775aa6a1d 100644 > --- a/kernel/locking/rwsem.h > +++ b/kernel/locking/rwsem.h > @@ -174,14 +174,17 @@ static inline int __down_read_killable(struct rw_semaphore *sem) > > static inline int __down_read_trylock(struct rw_semaphore *sem) > { > - long tmp; > + /* > + * Optimize for the case when the rwsem is not locked at all. > + */ > + long tmp = RWSEM_UNLOCKED_VALUE; > > - while ((tmp = atomic_long_read(&sem->count)) >= 0) { > - if (tmp == atomic_long_cmpxchg_acquire(&sem->count, tmp, > - tmp + RWSEM_ACTIVE_READ_BIAS)) { > + do { > + if (atomic_long_try_cmpxchg_acquire(&sem->count, &tmp, > + tmp + RWSEM_ACTIVE_READ_BIAS)) { > return 1; > } > - } > + } while (tmp >= 0); > return 0; > } > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1568C10F03 for ; Mon, 25 Mar 2019 15:25:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0C992087E for ; Mon, 25 Mar 2019 15:25:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bcVAdwdi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="Gb0MkZXr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0C992087E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3YxANPUWlpug6k1Li9eQdgKAlX2s19Pq0bFlkubvP9Y=; b=bcVAdwdiQiRzYjpMLHXR8wshu CfUkP3Q1iDJXOg5WxD22IQN3ulyv3dotMJ04L3AAoQsXSLcyJa8jYDRePS8efQx4TmVHh/tXPEyyp muP/YUGK1Vubr/sqyApklqNwM7HCPLENzVSGnV+N9pl3H+dV9GXa26vr6DlFtjFH4bhTeCQ+MM6kH S7uxsKGk3QeTpu94DtjZs8pMthKygxIIBcGcNmePbdHW6wxes6e/Wz556RwOwdgCMt6vbChQLQy2F kRE2DgfIAK0jz3m3xqdoQgBCczVpl1bwclt9MWE273m3oxFIWsb8+1UGnINtkEY5Vp5FRxkIqc7dX OpaWHlTFQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8RTm-0002xb-Vj; Mon, 25 Mar 2019 15:25:38 +0000 Received: from pegase1.c-s.fr ([93.17.236.30]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8RTj-0002vy-4v; Mon, 25 Mar 2019 15:25:37 +0000 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 44SdPD2xnBz9v0lr; Mon, 25 Mar 2019 16:25:20 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=Gb0MkZXr; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id CrK4rxgSxrO3; Mon, 25 Mar 2019 16:25:20 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 44SdPD1fbZz9tyDn; Mon, 25 Mar 2019 16:25:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1553527520; bh=JrL7MExoxenGmOAA8+6zfD5VS8gV08AijePqq6+rivY=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Gb0MkZXr4cfDzR19n8lna6H+IPA5AH3vZL1jNvOtCev91KCVbckg3/MYHKcjqkio5 h3ZxOQHblb9nHvTSJ7+rGRyQcDlyWn4FJ8MQkFBX2AdS6cvQu/8kr1/7uriihL47lA Q8KeTVo/1kkW9DTDs2sH3feGWWW85xlVR3ifVPe8= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 464268B8AB; Mon, 25 Mar 2019 16:25:25 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id PjtKP9S86Vzq; Mon, 25 Mar 2019 16:25:25 +0100 (CET) Received: from PO15451 (po15451.idsi0.si.c-s.fr [172.25.231.2]) by messagerie.si.c-s.fr (Postfix) with ESMTP id DA4758B74F; Mon, 25 Mar 2019 16:25:24 +0100 (CET) Subject: Re: [PATCH v5 3/3] locking/rwsem: Optimize down_read_trylock() To: Waiman Long , Peter Zijlstra , Ingo Molnar , Will Deacon , Thomas Gleixner References: <20190322143008.21313-1-longman@redhat.com> <20190322143008.21313-4-longman@redhat.com> From: Christophe Leroy Message-ID: <014279a5-8998-8e03-adb3-c3d611dff171@c-s.fr> Date: Mon, 25 Mar 2019 16:25:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190322143008.21313-4-longman@redhat.com> Content-Language: fr X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190325_082535_502312_5688C77E X-CRM114-Status: GOOD ( 22.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, "H. Peter Anvin" , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Davidlohr Bueso , linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, x86@kernel.org, uclinux-h8-devel@lists.sourceforge.jp, linux-xtensa@linux-xtensa.org, Arnd Bergmann , linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, Borislav Petkov , linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, Linus Torvalds , linux-mips@vger.kernel.org, linux-alpha@vger.kernel.org, nios2-dev@lists.rocketboards.org, Andrew Morton , Tim Chen Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpDb3VsZCB5b3Ugc2hhcmUgdGhlIG1pY3JvYmVuY2htYXJrIHlvdSBhcmUgdXNpbmcgPwoK SSdkIGxpa2UgdG8gdGVzdCB0aGUgc2VyaWVzIG9uIHBvd2VycGMuCgpUaGFua3MKQ2hyaXN0b3Bo ZQoKTGUgMjIvMDMvMjAxOSDDoCAxNTozMCwgV2FpbWFuIExvbmcgYSDDqWNyaXTCoDoKPiBNb2Rp ZnkgX19kb3duX3JlYWRfdHJ5bG9jaygpIHRvIG9wdGltaXplIGZvciBhbiB1bmxvY2tlZCByd3Nl bSBhbmQgbWFrZQo+IGl0IGdlbmVyYXRlIHNsaWdodGx5IGJldHRlciBjb2RlLgo+IAo+IEJlZm9y ZSB0aGlzIHBhdGNoLCBkb3duX3JlYWRfdHJ5bG9jazoKPiAKPiAgICAgMHgwMDAwMDAwMDAwMDAw MDAwIDwrMD46ICAgICBjYWxscSAgMHg1IDxkb3duX3JlYWRfdHJ5bG9jays1Pgo+ICAgICAweDAw MDAwMDAwMDAwMDAwMDUgPCs1PjogICAgIGptcCAgICAweDE4IDxkb3duX3JlYWRfdHJ5bG9jaysy ND4KPiAgICAgMHgwMDAwMDAwMDAwMDAwMDA3IDwrNz46ICAgICBsZWEgICAgMHgxKCVyZHgpLCVy Y3gKPiAgICAgMHgwMDAwMDAwMDAwMDAwMDBiIDwrMTE+OiAgICBtb3YgICAgJXJkeCwlcmF4Cj4g ICAgIDB4MDAwMDAwMDAwMDAwMDAwZSA8KzE0PjogICAgbG9jayBjbXB4Y2hnICVyY3gsKCVyZGkp Cj4gICAgIDB4MDAwMDAwMDAwMDAwMDAxMyA8KzE5PjogICAgY21wICAgICVyYXgsJXJkeAo+ICAg ICAweDAwMDAwMDAwMDAwMDAwMTYgPCsyMj46ICAgIGplICAgICAweDIzIDxkb3duX3JlYWRfdHJ5 bG9jayszNT4KPiAgICAgMHgwMDAwMDAwMDAwMDAwMDE4IDwrMjQ+OiAgICBtb3YgICAgKCVyZGkp LCVyZHgKPiAgICAgMHgwMDAwMDAwMDAwMDAwMDFiIDwrMjc+OiAgICB0ZXN0ICAgJXJkeCwlcmR4 Cj4gICAgIDB4MDAwMDAwMDAwMDAwMDAxZSA8KzMwPjogICAgam5zICAgIDB4NyA8ZG93bl9yZWFk X3RyeWxvY2srNz4KPiAgICAgMHgwMDAwMDAwMDAwMDAwMDIwIDwrMzI+OiAgICB4b3IgICAgJWVh eCwlZWF4Cj4gICAgIDB4MDAwMDAwMDAwMDAwMDAyMiA8KzM0PjogICAgcmV0cQo+ICAgICAweDAw MDAwMDAwMDAwMDAwMjMgPCszNT46ICAgIG1vdiAgICAlZ3M6MHgwLCVyYXgKPiAgICAgMHgwMDAw MDAwMDAwMDAwMDJjIDwrNDQ+OiAgICBvciAgICAgJDB4MywlcmF4Cj4gICAgIDB4MDAwMDAwMDAw MDAwMDAzMCA8KzQ4PjogICAgbW92ICAgICVyYXgsMHgyMCglcmRpKQo+ICAgICAweDAwMDAwMDAw MDAwMDAwMzQgPCs1Mj46ICAgIG1vdiAgICAkMHgxLCVlYXgKPiAgICAgMHgwMDAwMDAwMDAwMDAw MDM5IDwrNTc+OiAgICByZXRxCj4gCj4gQWZ0ZXIgcGF0Y2gsIGRvd25fcmVhZF90cnlsb2NrOgo+ IAo+ICAgICAweDAwMDAwMDAwMDAwMDAwMDAgPCswPjoJY2FsbHEgIDB4NSA8ZG93bl9yZWFkX3Ry eWxvY2srNT4KPiAgICAgMHgwMDAwMDAwMDAwMDAwMDA1IDwrNT46CXhvciAgICAlZWF4LCVlYXgK PiAgICAgMHgwMDAwMDAwMDAwMDAwMDA3IDwrNz46CWxlYSAgICAweDEoJXJheCksJXJkeAo+ICAg ICAweDAwMDAwMDAwMDAwMDAwMGIgPCsxMT46CWxvY2sgY21weGNoZyAlcmR4LCglcmRpKQo+ICAg ICAweDAwMDAwMDAwMDAwMDAwMTAgPCsxNj46CWpuZSAgICAweDI5IDxkb3duX3JlYWRfdHJ5bG9j ays0MT4KPiAgICAgMHgwMDAwMDAwMDAwMDAwMDEyIDwrMTg+Ogltb3YgICAgJWdzOjB4MCwlcmF4 Cj4gICAgIDB4MDAwMDAwMDAwMDAwMDAxYiA8KzI3PjoJb3IgICAgICQweDMsJXJheAo+ICAgICAw eDAwMDAwMDAwMDAwMDAwMWYgPCszMT46CW1vdiAgICAlcmF4LDB4MjAoJXJkaSkKPiAgICAgMHgw MDAwMDAwMDAwMDAwMDIzIDwrMzU+Ogltb3YgICAgJDB4MSwlZWF4Cj4gICAgIDB4MDAwMDAwMDAw MDAwMDAyOCA8KzQwPjoJcmV0cQo+ICAgICAweDAwMDAwMDAwMDAwMDAwMjkgPCs0MT46CXRlc3Qg ICAlcmF4LCVyYXgKPiAgICAgMHgwMDAwMDAwMDAwMDAwMDJjIDwrNDQ+OglqbnMgICAgMHg3IDxk b3duX3JlYWRfdHJ5bG9jays3Pgo+ICAgICAweDAwMDAwMDAwMDAwMDAwMmUgPCs0Nj46CXhvciAg ICAlZWF4LCVlYXgKPiAgICAgMHgwMDAwMDAwMDAwMDAwMDMwIDwrNDg+OglyZXRxCj4gCj4gQnkg dXNpbmcgYSByd3NlbSBtaWNyb2JlbmNobWFyaywgdGhlIGRvd25fcmVhZF90cnlsb2NrKCkgcmF0 ZSAod2l0aCBhCj4gbG9hZCBvZiAxMCB0byBsZW5ndGhlbiB0aGUgbG9jayBjcml0aWNhbCBzZWN0 aW9uKSBvbiBhIHg4Ni02NCBzeXN0ZW0KPiBiZWZvcmUgYW5kIGFmdGVyIHRoZSBwYXRjaCB3ZXJl Ogo+IAo+ICAgICAgICAgICAgICAgICAgIEJlZm9yZSBQYXRjaCAgICBBZnRlciBQYXRjaAo+ICAg ICAjIG9mIFRocmVhZHMgICAgIHJsb2NrICAgICAgICAgICBybG9jawo+ICAgICAtLS0tLS0tLS0t LS0gICAgIC0tLS0tICAgICAgICAgICAtLS0tLQo+ICAgICAgICAgIDEgICAgICAgICAgIDE0LDQ5 NiAgICAgICAgICAxNCw3MTYKPiAgICAgICAgICAyICAgICAgICAgICAgOCw2NDQgICAgICAgICAg IDgsNDUzCj4gCTQgICAgICAgICAgICA2LDc5OSAgICAgICAgICAgNiw5ODMKPiAJOCAgICAgICAg ICAgIDUsNjY0ICAgICAgICAgICA3LDE5MAo+IAo+IE9uIGEgQVJNNjQgc3lzdGVtLCB0aGUgcGVy Zm9ybWFuY2UgcmVzdWx0cyB3ZXJlOgo+IAo+ICAgICAgICAgICAgICAgICAgIEJlZm9yZSBQYXRj aCAgICBBZnRlciBQYXRjaAo+ICAgICAjIG9mIFRocmVhZHMgICAgIHJsb2NrICAgICAgICAgICBy bG9jawo+ICAgICAtLS0tLS0tLS0tLS0gICAgIC0tLS0tICAgICAgICAgICAtLS0tLQo+ICAgICAg ICAgIDEgICAgICAgICAgIDIzLDY3NiAgICAgICAgICAyNCw0ODgKPiAgICAgICAgICAyICAgICAg ICAgICAgNyw2OTcgICAgICAgICAgIDksNTAyCj4gICAgICAgICAgNCAgICAgICAgICAgIDQsOTQ1 ICAgICAgICAgICAzLDQ0MAo+ICAgICAgICAgIDggICAgICAgICAgICAyLDY0MSAgICAgICAgICAg MSw2MDMKPiAKPiBGb3IgdGhlIHVuY29udGVuZGVkIGNhc2UgKDEgdGhyZWFkKSwgdGhlIG5ldyBk b3duX3JlYWRfdHJ5bG9jaygpIGlzIGEKPiBsaXR0bGUgYml0IGZhc3Rlci4gRm9yIHRoZSBjb250 ZW5kZWQgY2FzZXMsIHRoZSBuZXcgZG93bl9yZWFkX3RyeWxvY2soKQo+IHBlcmZvcm0gcHJldHR5 IHdlbGwgaW4geDg2LTY0LCBidXQgcGVyZm9ybWFuY2UgZGVncmFkZXMgYXQgaGlnaAo+IGNvbnRl bnRpb24gbGV2ZWwgb24gQVJNNjQuCj4gCj4gU3VnZ2VzdGVkLWJ5OiBMaW51cyBUb3J2YWxkcyA8 dG9ydmFsZHNAbGludXgtZm91bmRhdGlvbi5vcmc+Cj4gU2lnbmVkLW9mZi1ieTogV2FpbWFuIExv bmcgPGxvbmdtYW5AcmVkaGF0LmNvbT4KPiAtLS0KPiAgIGtlcm5lbC9sb2NraW5nL3J3c2VtLmgg fCAxMyArKysrKysrKy0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA1 IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9rZXJuZWwvbG9ja2luZy9yd3NlbS5oIGIv a2VybmVsL2xvY2tpbmcvcndzZW0uaAo+IGluZGV4IDQ1ZWUwMDIzNmUwMy4uMWY1Nzc1YWE2YTFk IDEwMDY0NAo+IC0tLSBhL2tlcm5lbC9sb2NraW5nL3J3c2VtLmgKPiArKysgYi9rZXJuZWwvbG9j a2luZy9yd3NlbS5oCj4gQEAgLTE3NCwxNCArMTc0LDE3IEBAIHN0YXRpYyBpbmxpbmUgaW50IF9f ZG93bl9yZWFkX2tpbGxhYmxlKHN0cnVjdCByd19zZW1hcGhvcmUgKnNlbSkKPiAgIAo+ICAgc3Rh dGljIGlubGluZSBpbnQgX19kb3duX3JlYWRfdHJ5bG9jayhzdHJ1Y3Qgcndfc2VtYXBob3JlICpz ZW0pCj4gICB7Cj4gLQlsb25nIHRtcDsKPiArCS8qCj4gKwkgKiBPcHRpbWl6ZSBmb3IgdGhlIGNh c2Ugd2hlbiB0aGUgcndzZW0gaXMgbm90IGxvY2tlZCBhdCBhbGwuCj4gKwkgKi8KPiArCWxvbmcg dG1wID0gUldTRU1fVU5MT0NLRURfVkFMVUU7Cj4gICAKPiAtCXdoaWxlICgodG1wID0gYXRvbWlj X2xvbmdfcmVhZCgmc2VtLT5jb3VudCkpID49IDApIHsKPiAtCQlpZiAodG1wID09IGF0b21pY19s b25nX2NtcHhjaGdfYWNxdWlyZSgmc2VtLT5jb3VudCwgdG1wLAo+IC0JCQkJICAgdG1wICsgUldT RU1fQUNUSVZFX1JFQURfQklBUykpIHsKPiArCWRvIHsKPiArCQlpZiAoYXRvbWljX2xvbmdfdHJ5 X2NtcHhjaGdfYWNxdWlyZSgmc2VtLT5jb3VudCwgJnRtcCwKPiArCQkJCQl0bXAgKyBSV1NFTV9B Q1RJVkVfUkVBRF9CSUFTKSkgewo+ICAgCQkJcmV0dXJuIDE7Cj4gICAJCX0KPiAtCX0KPiArCX0g d2hpbGUgKHRtcCA+PSAwKTsKPiAgIAlyZXR1cm4gMDsKPiAgIH0KPiAgIAo+IAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christophe Leroy Date: Mon, 25 Mar 2019 16:25:24 +0100 Subject: [OpenRISC] [PATCH v5 3/3] locking/rwsem: Optimize down_read_trylock() In-Reply-To: <20190322143008.21313-4-longman@redhat.com> References: <20190322143008.21313-1-longman@redhat.com> <20190322143008.21313-4-longman@redhat.com> Message-ID: <014279a5-8998-8e03-adb3-c3d611dff171@c-s.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: openrisc@lists.librecores.org Hi, Could you share the microbenchmark you are using ? I'd like to test the series on powerpc. Thanks Christophe Le 22/03/2019 à 15:30, Waiman Long a écrit : > Modify __down_read_trylock() to optimize for an unlocked rwsem and make > it generate slightly better code. > > Before this patch, down_read_trylock: > > 0x0000000000000000 <+0>: callq 0x5 > 0x0000000000000005 <+5>: jmp 0x18 > 0x0000000000000007 <+7>: lea 0x1(%rdx),%rcx > 0x000000000000000b <+11>: mov %rdx,%rax > 0x000000000000000e <+14>: lock cmpxchg %rcx,(%rdi) > 0x0000000000000013 <+19>: cmp %rax,%rdx > 0x0000000000000016 <+22>: je 0x23 > 0x0000000000000018 <+24>: mov (%rdi),%rdx > 0x000000000000001b <+27>: test %rdx,%rdx > 0x000000000000001e <+30>: jns 0x7 > 0x0000000000000020 <+32>: xor %eax,%eax > 0x0000000000000022 <+34>: retq > 0x0000000000000023 <+35>: mov %gs:0x0,%rax > 0x000000000000002c <+44>: or $0x3,%rax > 0x0000000000000030 <+48>: mov %rax,0x20(%rdi) > 0x0000000000000034 <+52>: mov $0x1,%eax > 0x0000000000000039 <+57>: retq > > After patch, down_read_trylock: > > 0x0000000000000000 <+0>: callq 0x5 > 0x0000000000000005 <+5>: xor %eax,%eax > 0x0000000000000007 <+7>: lea 0x1(%rax),%rdx > 0x000000000000000b <+11>: lock cmpxchg %rdx,(%rdi) > 0x0000000000000010 <+16>: jne 0x29 > 0x0000000000000012 <+18>: mov %gs:0x0,%rax > 0x000000000000001b <+27>: or $0x3,%rax > 0x000000000000001f <+31>: mov %rax,0x20(%rdi) > 0x0000000000000023 <+35>: mov $0x1,%eax > 0x0000000000000028 <+40>: retq > 0x0000000000000029 <+41>: test %rax,%rax > 0x000000000000002c <+44>: jns 0x7 > 0x000000000000002e <+46>: xor %eax,%eax > 0x0000000000000030 <+48>: retq > > By using a rwsem microbenchmark, the down_read_trylock() rate (with a > load of 10 to lengthen the lock critical section) on a x86-64 system > before and after the patch were: > > Before Patch After Patch > # of Threads rlock rlock > ------------ ----- ----- > 1 14,496 14,716 > 2 8,644 8,453 > 4 6,799 6,983 > 8 5,664 7,190 > > On a ARM64 system, the performance results were: > > Before Patch After Patch > # of Threads rlock rlock > ------------ ----- ----- > 1 23,676 24,488 > 2 7,697 9,502 > 4 4,945 3,440 > 8 2,641 1,603 > > For the uncontended case (1 thread), the new down_read_trylock() is a > little bit faster. For the contended cases, the new down_read_trylock() > perform pretty well in x86-64, but performance degrades at high > contention level on ARM64. > > Suggested-by: Linus Torvalds > Signed-off-by: Waiman Long > --- > kernel/locking/rwsem.h | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/kernel/locking/rwsem.h b/kernel/locking/rwsem.h > index 45ee00236e03..1f5775aa6a1d 100644 > --- a/kernel/locking/rwsem.h > +++ b/kernel/locking/rwsem.h > @@ -174,14 +174,17 @@ static inline int __down_read_killable(struct rw_semaphore *sem) > > static inline int __down_read_trylock(struct rw_semaphore *sem) > { > - long tmp; > + /* > + * Optimize for the case when the rwsem is not locked at all. > + */ > + long tmp = RWSEM_UNLOCKED_VALUE; > > - while ((tmp = atomic_long_read(&sem->count)) >= 0) { > - if (tmp == atomic_long_cmpxchg_acquire(&sem->count, tmp, > - tmp + RWSEM_ACTIVE_READ_BIAS)) { > + do { > + if (atomic_long_try_cmpxchg_acquire(&sem->count, &tmp, > + tmp + RWSEM_ACTIVE_READ_BIAS)) { > return 1; > } > - } > + } while (tmp >= 0); > return 0; > } > >