From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH v3 1/9] fbarray: fix detach in noshconf mode
Date: Thu, 13 Sep 2018 15:00:55 +0200
Message-ID: <0149c18a-d1dc-b52d-bb23-092b17a9c8c9@redhat.com>
References: <cover.1536073996.git.anatoly.burakov@intel.com>
 <3ab2d0a7cf61d800e1b4bc8571d79e5a113e0dd7.1536073997.git.anatoly.burakov@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: tiwei.bie@intel.com, ray.kinsella@intel.com, zhihong.wang@intel.com,
 kuralamudhan.ramakrishnan@intel.com, stable@dpdk.org
To: Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <3ab2d0a7cf61d800e1b4bc8571d79e5a113e0dd7.1536073997.git.anatoly.burakov@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 09/04/2018 05:15 PM, Anatoly Burakov wrote:
> In noshconf mode, no shared files are created, but we're still trying
> to unlink them, resulting in detach/destroy failure even though it
> should have succeeded. Fix it by exiting early in noshconf mode.
> 
> Fixes: 3ee2cde248a7 ("fbarray: support --no-shconf mode")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>   lib/librte_eal/common/eal_common_fbarray.c | 4 ++++
>   1 file changed, 4 insertions(+)

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>