From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZotBq-00008b-Hd for qemu-devel@nongnu.org; Wed, 21 Oct 2015 09:12:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZotBk-00060D-Up for qemu-devel@nongnu.org; Wed, 21 Oct 2015 09:12:26 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:37398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZotBk-0005zn-PV for qemu-devel@nongnu.org; Wed, 21 Oct 2015 09:12:20 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NWK00959NCIVDA0@mailout2.w1.samsung.com> for qemu-devel@nongnu.org; Wed, 21 Oct 2015 14:12:18 +0100 (BST) From: Pavel Fedin References: <1445361732-16257-1-git-send-email-shlomopongratz@gmail.com> <1445361732-16257-7-git-send-email-shlomopongratz@gmail.com> <014301d10bfe$20c00970$62401c50$@samsung.com> In-reply-to: Date: Wed, 21 Oct 2015 16:12:16 +0300 Message-id: <015801d10c02$1c60d130$55227390$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: quoted-printable Content-language: ru Subject: Re: [Qemu-devel] [PATCH RFC V5 6/9] hw/intc: arm_gicv3_spi_its List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Shlomo Pongratz' Cc: peter.maydell@linaro.org, eric.auger@linaro.org, 'Shlomo Pongratz' , qemu-devel@nongnu.org, shannon.zhao@linaro.org, ashoks@broadcom.com, imammedo@redhat.com Hello! > I just added a placeholder, I didn't add any functionality. I see. Just wanted to say, that if we accept my proposal (implementing = ITS as a separate object), then the only thing we would do with this = placeholder is to remove it. It should go then to something like = hw/intc/arm_gicv3_its.c and its object should inherit from = TYPE_ARM_GICV3_ITS_COMMON. Or do you have some explicit reasons to have everything as a monolith? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia