From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v9 00/19] Add support for FDMA DMA controller and slim core rproc found on STi chipsets References: <1473081421-16555-1-git-send-email-peter.griffin@linaro.org> <20160913093107.GA10953@griffinp-ThinkPad-X1-Carbon-2nd> <20160913180616.GD21438@tuxbot> From: Patrice Chotard Message-ID: <01669e54-8410-76cd-11f8-fce5cbeefbdc@st.com> Date: Wed, 14 Sep 2016 08:59:32 +0200 MIME-Version: 1.0 In-Reply-To: <20160913180616.GD21438@tuxbot> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit To: Bjorn Andersson , Peter Griffin , vinod.koul@intel.com Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, dan.j.williams@intel.com, airlied@linux.ie, kraxel@redhat.com, ohad@wizery.com, lee.jones@linaro.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-remoteproc@vger.kernel.org, virtualization@lists.linux-foundation.org List-ID: Hi Bjorn On 09/13/2016 08:06 PM, Bjorn Andersson wrote: > On Tue 13 Sep 02:31 PDT 2016, Peter Griffin wrote: > >> Hi Vinod & Bjorn, >> >> [..] >> >> On Mon, 05 Sep 2016, Peter Griffin wrote: >> >>> v8 actions some review feedback from Bjorn to the slim rproc driver, and also includes >>> a patch which fixes a recursive Kconfig error which is triggered when st_fdma selects >>> slim_rproc driver. The series has also been rebased on v4.8-rc3. >>> >>> v9 actions some review feedback from Bjorn, Lee and Vinod. See below. Importantly a bug >>> was found during testing now that the platform boots without clk_ignore_unused parameter >>> whereby the clocks would not be enabled properly before firmware loading was attempted. >>> >>> regards, >>> >>> Peter. >>> >>> Changes since v8: >>> - Add MODULE_ALIAS (Vinod) >>> - devm_kzalloc to devm_kcalloc (Vinod) >>> - quisce tasklet initialised by vchan_init() (Vinod) >>> - Don't make SLIM rproc user selectable (Bjorn) >>> - slim_rproc: Ensure clocks enabled before firmware load (Peter) >>> - Various code style nits / commit message change (Lee) >>> - Separate patch for '\n' kconfig removal (Vinod) >> >> I hate to send a ping, > > Sorry about that. > >> but do you think we can merge this fdma series? It has gone >> through quite a few review rounds now. >> > > I think the remoteproc part looks good. > > Vinod, I don't have any changes queued in remoteproc that should cause > merge issues. If you want to you could take the remoteproc patch > through your tree. > > > I do however think that the dts patches should go through arm-soc. I will take care about dts patches by adding them in the next STi DT pull request Thanks Patrice > > Regards, > Bjorn > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759918AbcINHAZ (ORCPT ); Wed, 14 Sep 2016 03:00:25 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:41126 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752470AbcINHAW (ORCPT ); Wed, 14 Sep 2016 03:00:22 -0400 Subject: Re: [PATCH v9 00/19] Add support for FDMA DMA controller and slim core rproc found on STi chipsets To: Bjorn Andersson , Peter Griffin , References: <1473081421-16555-1-git-send-email-peter.griffin@linaro.org> <20160913093107.GA10953@griffinp-ThinkPad-X1-Carbon-2nd> <20160913180616.GD21438@tuxbot> CC: , , , , , , , , , , , , From: Patrice Chotard Message-ID: <01669e54-8410-76cd-11f8-fce5cbeefbdc@st.com> Date: Wed, 14 Sep 2016 08:59:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160913180616.GD21438@tuxbot> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.1.66] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-14_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn On 09/13/2016 08:06 PM, Bjorn Andersson wrote: > On Tue 13 Sep 02:31 PDT 2016, Peter Griffin wrote: > >> Hi Vinod & Bjorn, >> >> [..] >> >> On Mon, 05 Sep 2016, Peter Griffin wrote: >> >>> v8 actions some review feedback from Bjorn to the slim rproc driver, and also includes >>> a patch which fixes a recursive Kconfig error which is triggered when st_fdma selects >>> slim_rproc driver. The series has also been rebased on v4.8-rc3. >>> >>> v9 actions some review feedback from Bjorn, Lee and Vinod. See below. Importantly a bug >>> was found during testing now that the platform boots without clk_ignore_unused parameter >>> whereby the clocks would not be enabled properly before firmware loading was attempted. >>> >>> regards, >>> >>> Peter. >>> >>> Changes since v8: >>> - Add MODULE_ALIAS (Vinod) >>> - devm_kzalloc to devm_kcalloc (Vinod) >>> - quisce tasklet initialised by vchan_init() (Vinod) >>> - Don't make SLIM rproc user selectable (Bjorn) >>> - slim_rproc: Ensure clocks enabled before firmware load (Peter) >>> - Various code style nits / commit message change (Lee) >>> - Separate patch for '\n' kconfig removal (Vinod) >> >> I hate to send a ping, > > Sorry about that. > >> but do you think we can merge this fdma series? It has gone >> through quite a few review rounds now. >> > > I think the remoteproc part looks good. > > Vinod, I don't have any changes queued in remoteproc that should cause > merge issues. If you want to you could take the remoteproc patch > through your tree. > > > I do however think that the dts patches should go through arm-soc. I will take care about dts patches by adding them in the next STi DT pull request Thanks Patrice > > Regards, > Bjorn > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrice Chotard Subject: Re: [PATCH v9 00/19] Add support for FDMA DMA controller and slim core rproc found on STi chipsets Date: Wed, 14 Sep 2016 08:59:32 +0200 Message-ID: <01669e54-8410-76cd-11f8-fce5cbeefbdc@st.com> References: <1473081421-16555-1-git-send-email-peter.griffin@linaro.org> <20160913093107.GA10953@griffinp-ThinkPad-X1-Carbon-2nd> <20160913180616.GD21438@tuxbot> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160913180616.GD21438@tuxbot> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bjorn Andersson , Peter Griffin , vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org, dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, kraxel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-remoteproc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Bjorn On 09/13/2016 08:06 PM, Bjorn Andersson wrote: > On Tue 13 Sep 02:31 PDT 2016, Peter Griffin wrote: > >> Hi Vinod & Bjorn, >> >> [..] >> >> On Mon, 05 Sep 2016, Peter Griffin wrote: >> >>> v8 actions some review feedback from Bjorn to the slim rproc driver, and also includes >>> a patch which fixes a recursive Kconfig error which is triggered when st_fdma selects >>> slim_rproc driver. The series has also been rebased on v4.8-rc3. >>> >>> v9 actions some review feedback from Bjorn, Lee and Vinod. See below. Importantly a bug >>> was found during testing now that the platform boots without clk_ignore_unused parameter >>> whereby the clocks would not be enabled properly before firmware loading was attempted. >>> >>> regards, >>> >>> Peter. >>> >>> Changes since v8: >>> - Add MODULE_ALIAS (Vinod) >>> - devm_kzalloc to devm_kcalloc (Vinod) >>> - quisce tasklet initialised by vchan_init() (Vinod) >>> - Don't make SLIM rproc user selectable (Bjorn) >>> - slim_rproc: Ensure clocks enabled before firmware load (Peter) >>> - Various code style nits / commit message change (Lee) >>> - Separate patch for '\n' kconfig removal (Vinod) >> >> I hate to send a ping, > > Sorry about that. > >> but do you think we can merge this fdma series? It has gone >> through quite a few review rounds now. >> > > I think the remoteproc part looks good. > > Vinod, I don't have any changes queued in remoteproc that should cause > merge issues. If you want to you could take the remoteproc patch > through your tree. > > > I do however think that the dts patches should go through arm-soc. I will take care about dts patches by adding them in the next STi DT pull request Thanks Patrice > > Regards, > Bjorn > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: patrice.chotard@st.com (Patrice Chotard) Date: Wed, 14 Sep 2016 08:59:32 +0200 Subject: [PATCH v9 00/19] Add support for FDMA DMA controller and slim core rproc found on STi chipsets In-Reply-To: <20160913180616.GD21438@tuxbot> References: <1473081421-16555-1-git-send-email-peter.griffin@linaro.org> <20160913093107.GA10953@griffinp-ThinkPad-X1-Carbon-2nd> <20160913180616.GD21438@tuxbot> Message-ID: <01669e54-8410-76cd-11f8-fce5cbeefbdc@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Bjorn On 09/13/2016 08:06 PM, Bjorn Andersson wrote: > On Tue 13 Sep 02:31 PDT 2016, Peter Griffin wrote: > >> Hi Vinod & Bjorn, >> >> [..] >> >> On Mon, 05 Sep 2016, Peter Griffin wrote: >> >>> v8 actions some review feedback from Bjorn to the slim rproc driver, and also includes >>> a patch which fixes a recursive Kconfig error which is triggered when st_fdma selects >>> slim_rproc driver. The series has also been rebased on v4.8-rc3. >>> >>> v9 actions some review feedback from Bjorn, Lee and Vinod. See below. Importantly a bug >>> was found during testing now that the platform boots without clk_ignore_unused parameter >>> whereby the clocks would not be enabled properly before firmware loading was attempted. >>> >>> regards, >>> >>> Peter. >>> >>> Changes since v8: >>> - Add MODULE_ALIAS (Vinod) >>> - devm_kzalloc to devm_kcalloc (Vinod) >>> - quisce tasklet initialised by vchan_init() (Vinod) >>> - Don't make SLIM rproc user selectable (Bjorn) >>> - slim_rproc: Ensure clocks enabled before firmware load (Peter) >>> - Various code style nits / commit message change (Lee) >>> - Separate patch for '\n' kconfig removal (Vinod) >> >> I hate to send a ping, > > Sorry about that. > >> but do you think we can merge this fdma series? It has gone >> through quite a few review rounds now. >> > > I think the remoteproc part looks good. > > Vinod, I don't have any changes queued in remoteproc that should cause > merge issues. If you want to you could take the remoteproc patch > through your tree. > > > I do however think that the dts patches should go through arm-soc. I will take care about dts patches by adding them in the next STi DT pull request Thanks Patrice > > Regards, > Bjorn >