All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: "David Hildenbrand" <david@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>
Cc: Halil Pasic <pasic@linux.ibm.com>, Thomas Huth <thuth@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	qemu-s390x@nongnu.org
Subject: Re: [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn
Date: Fri, 24 May 2019 20:28:19 +0200	[thread overview]
Message-ID: <016edc53-278e-cc58-0061-d2c5de80afd2@de.ibm.com> (raw)
In-Reply-To: <3fab9e76-53ad-2de7-45df-eb69c8604709@redhat.com>



On 24.05.19 20:04, David Hildenbrand wrote:
> On 24.05.19 19:54, Philippe Mathieu-Daudé wrote:
>> Hi Christian,
>>
>> I'm having hard time to understand why the S390_IPL object calls
>> qemu_register_reset(qdev_reset_all_fn) in its realize() method, while
>> being QOM'ified (it has a reset method).
>>
>> It doesn't seem to have a qdev children added explicitly to it.
>> I see it is used as a singleton, what else am I missing?
>>
>> Thanks,
>>
>> Phil.
>>
> 
> Looks like I added it back then (~4 years ago) when converting it into a
> TYPE_DEVICE.
> 
> I could imagine that - back then - this was needed because only
> TYPE_SYS_BUS_DEVICE would recursively get reset.

Yes, back then singleton devices were not recursively resetted. Has that changed?
> 
> Did you try removing it, to see if anything breaks?
> 



  parent reply	other threads:[~2019-05-24 18:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24 17:54 [Qemu-devel] hw/s390x/ipl: Dubious use of qdev_reset_all_fn Philippe Mathieu-Daudé
2019-05-24 18:04 ` David Hildenbrand
2019-05-24 18:20   ` Philippe Mathieu-Daudé
2019-05-24 18:28   ` Christian Borntraeger [this message]
2019-05-24 18:36     ` David Hildenbrand
2019-05-24 19:00       ` David Hildenbrand
2019-05-24 19:45         ` Christian Borntraeger
2019-05-24 19:58           ` David Hildenbrand
2019-05-25 15:03           ` Peter Maydell
2019-05-27  7:52             ` Markus Armbruster
2019-05-27  9:59               ` Philippe Mathieu-Daudé
2019-05-27 18:55               ` Peter Maydell
2019-05-28  5:02                 ` Markus Armbruster
2019-05-29  6:08                 ` Markus Armbruster
2019-05-29 10:32                   ` Philippe Mathieu-Daudé
2019-05-28  8:29           ` David Hildenbrand
2019-05-28  8:33             ` Cornelia Huck
2019-05-28  9:29               ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=016edc53-278e-cc58-0061-d2c5de80afd2@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=armbru@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.