From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B11E9C433F5 for ; Wed, 17 Nov 2021 22:10:19 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D39A61B2B for ; Wed, 17 Nov 2021 22:10:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9D39A61B2B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=traverse.com.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 102FD82093; Wed, 17 Nov 2021 23:10:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=traverse.com.au Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=traverse.com.au header.i=@traverse.com.au header.b="moOvSjmB"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="EHOW2Qkj"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 923658291E; Wed, 17 Nov 2021 23:10:13 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 081FA81FD5 for ; Wed, 17 Nov 2021 23:10:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=traverse.com.au Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=matt@traverse.com.au Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 342765C0280; Wed, 17 Nov 2021 17:10:04 -0500 (EST) Received: from imap41 ([10.202.2.91]) by compute6.internal (MEProxy); Wed, 17 Nov 2021 17:10:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=traverse.com.au; h=mime-version:message-id:in-reply-to:references:date:from:to :cc:subject:content-type; s=fm2; bh=dmmWNUTrZG00sz0BecER4MYtiQOK hWIZjF/fDAFwEe8=; b=moOvSjmBijcgcc7slux0pT3iRFFVLklkFlJBm8JIaSQo +ZR6740/vgq0uCbnL6BLqK1qUFoKtyaKBfgMBxewVFmXuBX+YTbD8jU4nzaDRSgw i14YHdRA05S2qHtcMFeP46unl+BSF0XfLXdvR7aHndkOe+RJoU0X3zVpfijHA/OD tQRvnqZygFpFsxL/Cg2vMaNN/4a+70v4trLo2zGua0Th600+/R3Gjrg1btLjF+WC rK51QgrpvJCkgZRvX3QmagOKmtHLRkJtP5mhqoYRyIyQ+JliK0lNFQ8ODWo2TmYP SMLRAIOeoqcyAfE1W00tCcsYSzSr1Iw4kSjQj0Q+fQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=dmmWNU TrZG00sz0BecER4MYtiQOKhWIZjF/fDAFwEe8=; b=EHOW2QkjUm2GUyLHZbyghm kxwMR5CDPgECO6OuYAy8YE+zxCpG0rWZHoG4JLpLB3hWabOcGzXPBKM0jC6uDYfi e62w3WLTceOYwFisiMdfq5dJ1EjlRYlKHjLHehqN9wYXsdAgNAxRkONRmPrRfvC+ 7ZSLFqBja4RH4Zexe79zKvXWgNh+2QbSpoJ4XSoK64Mi5fLw+jzgoDIaz7lpbi8+ zGVZjHcok3A8NMhhGmKnc5lFDHmD8rwxAzRhck5aOHrKKCX5xVy6BZkZhgFgpIE3 H9Dm68xYNbtqEXPSk7GZnZIFWZSIONeu7fF8SlTdffQWLHgtjwSTXqzxg8pvwKgQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrfeeggdduhedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesrgdtreerreertdenucfhrhhomhepfdforght hhgvficuofgtuehrihguvgdfuceomhgrthhtsehtrhgrvhgvrhhsvgdrtghomhdrrghuqe enucggtffrrghtthgvrhhnpeehjeekleeuudejgeetgeejudegveekffetfefgfedtveei kedtgeefkeekhffhvdenucffohhmrghinhepsghoohhtlhhinhdrtghomhenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghtthesthhrrghv vghrshgvrdgtohhmrdgruh X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id BD4FD3C0C77; Wed, 17 Nov 2021 17:10:03 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-1371-g2296cc3491-fm-20211109.003-g2296cc34 Mime-Version: 1.0 Message-Id: <017630d6-ca34-4121-b5a7-c306948dae1b@www.fastmail.com> In-Reply-To: <20211111182046.GU24579@bill-the-cat> References: <20211110044639.7070-1-matt@traverse.com.au> <20211110044639.7070-3-matt@traverse.com.au> <20211111182046.GU24579@bill-the-cat> Date: Thu, 18 Nov 2021 09:09:44 +1100 From: "Mathew McBride" To: "Tom Rini" Cc: u-boot@lists.denx.de, "Priyanka Jain" Subject: Re: [PATCH v2 2/2] board: traverse: add initial Ten64 support Content-Type: text/plain X-Content-Filtered-By: Mailman/MimeDel 2.1.35 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Fri, Nov 12, 2021, at 5:20 AM, Tom Rini wrote: > On Wed, Nov 10, 2021 at 04:46:39AM +0000, Mathew McBride wrote: > > > Signed-off-by: Mathew McBride > > --- > > arch/arm/Kconfig | 16 ++ > > arch/arm/dts/Makefile | 2 + > > arch/arm/dts/fsl-ls1088a-ten64.dts | 377 +++++++++++++++++++++++++ > > What is the status of this dts with upstream Linux? It's been in Linux since v5.15, though there is going to be some flux between U-Boot and Linux for a short while as some devices will be introduced into one or the other other first. e.g traverse,ten64-controller does not and will not have a Linux (kernel) counterpart but I'll try and get it added to the dt yaml's for validation. (The upstream DTS intentionally left out some I2C devices that don't have Linux drivers or formal DT bindings yet) > [snip] > > > > +#define QSPI_NOR_BOOTCOMMAND "run distro_bootcmd" > > +#define SD_BOOTCOMMAND "run distro_bootcmd" > > You should just set CONFIG_USE_BOOTCOMMAND and then CONFIG_BOOTCOMMAND > will be "run distro_bootcmd". Thanks! This actually comes about from fsl_setenv_bootcmd: https://elixir.bootlin.com/u-boot/latest/source/arch/arm/cpu/armv8/fsl-layerscape/soc.c#L800 Which gets hooked into board_late_init https://elixir.bootlin.com/u-boot/latest/source/arch/arm/cpu/armv8/fsl-layerscape/soc.c#L961 The main reason I understand that exists is because the secure boot (FSL trust architecture) setup differs a depending on where the board has booted from: https://elixir.bootlin.com/u-boot/latest/source/include/configs/ls1088ardb.h#L448 (There is also a similar issue with mcinitcmd which does affect us) Since trust architecture isn't supported on our board yet, it just collapses down to "run distro_bootcmd" regardless of where the board started from. I guess this behaviour could be hidden behind a Kconfig so it's opt-in? - Matt