From: "Khem Raj" <raj.khem@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [RFC PATCH 11/14] populate_sdk_base/images: Drop use of 'meta' class and hence do_build dependencies
Date: Mon, 20 Sep 2021 09:32:40 -0700 [thread overview]
Message-ID: <01765ca0-de7c-2e32-7e46-455d18737705@gmail.com> (raw)
In-Reply-To: <3efdb496fefa59a9a7edec21f2ca751de5439bd5.camel@linuxfoundation.org>
On 9/20/21 5:51 AM, Richard Purdie wrote:
> On Mon, 2021-09-20 at 13:46 +0100, Richard Purdie via lists.openembedded.org
> wrote:
>> The 'meta' is old and not very useful. It empties PACKAGES and creates
>> recursive do_build dependencies.
>>
>> We shouldn't need such recursive build dependencies any more so simplify the code.
>>
>> This does cause behaviour changes as some dependencies are no longer built.
>> It did show up issues with qemu-helper-native handling for example but those
>> issues look like real races and the underlying dependency chains were not correct.
>>
>> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>> ---
>> meta/classes/populate_sdk_base.bbclass | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
>> index ccfe2232895..49e166e697d 100644
>> --- a/meta/classes/populate_sdk_base.bbclass
>> +++ b/meta/classes/populate_sdk_base.bbclass
>> @@ -1,4 +1,6 @@
>> -inherit meta image-postinst-intercepts image-artifact-names
>> +PACKAGES = ""
>> +
>> +inherit image-postinst-intercepts image-artifact-names
>>
>> # Wildcards specifying complementary packages to install for every package that has been explicitly
>> # installed into the rootfs
>
> This change is probably high impact in that it changes behaviour the most of any
> of the changes. It does make image builds use a lot less sstate and in theory,
> if there are issues with failures from this, there are probably existing races.
>
> It does also have CI impact as it changes the things which are built as not all
> build tasks now run. Open to opinions on whether we should do this now or not.
>
I definitely like this change and want it in upcoming LTS in 2022, not
comfortable with rushing it into this release. It will cause fair bit of
work for rest of layers in ecosystem.
> The meta class is pretty useless and should be removed regardless.
>
yes
> Cheers,
>
> Richard
>
>
>
>
>
next prev parent reply other threads:[~2021-09-20 16:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:46 [PATCH 01/14] vim: Backport fix for CVE-2021-3770 Richard Purdie
2021-09-20 12:46 ` [PATCH 02/14] libgcrypt: Upgrade 1.9.3 -> 1.9.4 Richard Purdie
2021-09-20 12:46 ` [PATCH 03/14] sqlite3: Exclude CVE-2021-36690 from cve checks Richard Purdie
2021-09-20 12:46 ` [PATCH 04/14] recipes: Add missing pkgconfig inherit Richard Purdie
2021-09-20 12:46 ` [PATCH 05/14] lttng-tools: Add missing DEPENDS on bison-native Richard Purdie
2022-01-18 20:48 ` [OE-core] " Denys Dmytriyenko
2021-09-20 12:46 ` [PATCH 06/14] image/qemu: Add explict depends for qemu-helper addto_recipe_sysroot task Richard Purdie
2021-09-20 12:46 ` [PATCH 07/14] staging: Mark deploy an sstate task Richard Purdie
2021-09-20 12:46 ` [PATCH 08/14] sstate: Ensure deploy tasks don't pull in toolchains Richard Purdie
2021-09-20 12:46 ` [PATCH 09/14] sstate: Avoid deploy_source_date_epoch sstate when unneeded Richard Purdie
2021-09-20 12:46 ` [RFC PATCH 10/14] package_ipk/deb/rpm: Drop recursive do_build task dependencies Richard Purdie
2021-09-23 21:41 ` [OE-core] " Peter Kjellerstedt
2021-09-23 21:58 ` Richard Purdie
2021-09-24 4:50 ` Khem Raj
2021-09-24 7:58 ` Martin Jansa
2021-09-24 8:30 ` Richard Purdie
2021-09-24 17:20 ` Khem Raj
2021-09-20 12:46 ` [RFC PATCH 11/14] populate_sdk_base/images: Drop use of 'meta' class and hence do_build dependencies Richard Purdie
2021-10-27 2:43 ` [OE-core] " ChenQi
2021-11-02 13:06 ` Richard Purdie
2021-09-20 12:46 ` [PATCH 12/14] buildtools-tarball/uninative-tarball/meta-ide-support: Drop useless meta class Richard Purdie
2021-09-20 12:46 ` [PATCH 13/14] meta: Drop useless class Richard Purdie
2021-09-20 12:46 ` [RFC PATCH 14/14] layer.conf: Extend recipes not to install without explict dependencies Richard Purdie
[not found] ` <16A68880435BB472.28512@lists.openembedded.org>
2021-09-20 12:48 ` [OE-core] " Richard Purdie
2021-09-20 13:34 ` Joshua Watt
2021-09-21 4:21 ` Khem Raj
2021-10-01 14:17 ` Martin Jansa
2021-10-17 23:50 ` Andreas Müller
2021-10-18 14:12 ` Martin Jansa
2021-10-18 14:29 ` Richard Purdie
2021-10-18 16:50 ` Andreas Müller
2021-10-18 16:59 ` Andreas Müller
2021-10-18 19:07 ` Konrad Weihmann
2021-10-18 21:08 ` Richard Purdie
[not found] ` <16A6887F33E2E04C.31899@lists.openembedded.org>
2021-09-20 12:51 ` [OE-core] [RFC PATCH 11/14] populate_sdk_base/images: Drop use of 'meta' class and hence do_build dependencies Richard Purdie
2021-09-20 16:32 ` Khem Raj [this message]
2021-09-20 20:02 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01765ca0-de7c-2e32-7e46-455d18737705@gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.