From: Quentin Monnet <quentin.monnet@netronome.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Andrii Nakryiko <andriin@fb.com>,
Networking <netdev@vger.kernel.org>,
bpf@vger.kernel.org, Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v2 bpf-next 11/12] bpftool/docs: add description of btf dump C option
Date: Fri, 24 May 2019 20:42:31 +0100 [thread overview]
Message-ID: <017b901f-f942-77dd-4d85-b8a7f9ee79a6@netronome.com> (raw)
In-Reply-To: <CAEf4BzZSLSDv-Hr47HrrboDAscW166JCERGs6eRPijkCqzzb7g@mail.gmail.com>
2019-05-24 10:25 UTC-0700 ~ Andrii Nakryiko <andrii.nakryiko@gmail.com>
> On Fri, May 24, 2019 at 2:14 AM Quentin Monnet
> <quentin.monnet@netronome.com> wrote:
>>
>> 2019-05-23 13:42 UTC-0700 ~ Andrii Nakryiko <andriin@fb.com>
>>> Document optional **c** option for btf dump subcommand.
>>>
>>> Cc: Quentin Monnet <quentin.monnet@netronome.com>
>>> Signed-off-by: Andrii Nakryiko <andriin@fb.com>
>>> ---
>>> tools/bpf/bpftool/Documentation/bpftool-btf.rst | 7 ++++++-
>>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/tools/bpf/bpftool/Documentation/bpftool-btf.rst b/tools/bpf/bpftool/Documentation/bpftool-btf.rst
>>> index 2dbc1413fabd..1aec7dc039e9 100644
>>> --- a/tools/bpf/bpftool/Documentation/bpftool-btf.rst
>>> +++ b/tools/bpf/bpftool/Documentation/bpftool-btf.rst
>>> @@ -19,10 +19,11 @@ SYNOPSIS
>>> BTF COMMANDS
>>> =============
>>>
>>> -| **bpftool** **btf dump** *BTF_SRC*
>>> +| **bpftool** **btf dump** *BTF_SRC* [**format** *FORMAT*]
>>> | **bpftool** **btf help**
>>> |
>>> | *BTF_SRC* := { **id** *BTF_ID* | **prog** *PROG* | **map** *MAP* [{**key** | **value** | **kv** | **all**}] | **file** *FILE* }
>>> +| *FORMAT* := { **raw** | **c** }
>>
>> Nit: This line should use a tab for indent (Do not respin just for that,
>> though!).
>
> Oh, I didn't notice that. My vim setup very aggressively refuses to
> insert tabs, so I had to literaly copy/paste pieces of tabulations :)
> Fixed it.
I can relate :). On my (vim) setup, I can usually hit Ctrl+V then <Tab>
to insert tabulations in that case.
>
>>
>>> | *MAP* := { **id** *MAP_ID* | **pinned** *FILE* }
>>> | *PROG* := { **id** *PROG_ID* | **pinned** *FILE* | **tag** *PROG_TAG* }
>>>
>>> @@ -49,6 +50,10 @@ DESCRIPTION
>>> .BTF section with well-defined BTF binary format data,
>>> typically produced by clang or pahole.
>>>
>>> + **format** option can be used to override default (raw)
>>> + output format. Raw (**raw**) or C-syntax (**c**) output
>>> + formats are supported.
>>> +
>>
>> Other files use tabs here as well, but most of the description here
>> already uses spaces, so ok.
>
> Yeah, thanks for pointing out, fixed everything to tabs + 2 spaces, as
> in other files (unclear why we have extra 2 spaces, but not going to
> change that).
Thanks!
>
>>
>>> **bpftool btf help**
>>> Print short help message.
>>>
>>>
>>
next prev parent reply other threads:[~2019-05-24 19:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 20:42 [PATCH v2 bpf-next 00/12] BTF-to-C converter Andrii Nakryiko
2019-05-23 20:42 ` [PATCH v2 bpf-next 01/12] libbpf: ensure libbpf.h is included along libbpf_internal.h Andrii Nakryiko
2019-05-23 20:42 ` [PATCH v2 bpf-next 02/12] libbpf: add btf__parse_elf API to load .BTF and .BTF.ext Andrii Nakryiko
2019-05-23 20:42 ` [PATCH v2 bpf-next 03/12] bpftool: use libbpf's btf__parse_elf API Andrii Nakryiko
2019-05-23 20:42 ` [PATCH v2 bpf-next 04/12] selftests/bpf: use btf__parse_elf to check presence of BTF/BTF.ext Andrii Nakryiko
2019-05-23 20:42 ` [PATCH v2 bpf-next 05/12] libbpf: add resizable non-thread safe internal hashmap Andrii Nakryiko
2019-05-23 20:42 ` [PATCH v2 bpf-next 06/12] selftests/bpf: add tests for libbpf's hashmap Andrii Nakryiko
2019-05-23 20:42 ` [PATCH v2 bpf-next 07/12] libbpf: switch btf_dedup() to hashmap for dedup table Andrii Nakryiko
2019-05-23 20:42 ` [PATCH v2 bpf-next 08/12] libbpf: add btf_dump API for BTF-to-C conversion Andrii Nakryiko
2019-05-23 20:42 ` [PATCH v2 bpf-next 09/12] selftests/bpf: add btf_dump BTF-to-C conversion tests Andrii Nakryiko
2019-05-23 20:42 ` [PATCH v2 bpf-next 10/12] bpftool: add C output format option to btf dump subcommand Andrii Nakryiko
2019-05-23 20:50 ` Jakub Kicinski
2019-05-24 9:13 ` Quentin Monnet
2019-05-24 17:14 ` Andrii Nakryiko
2019-05-24 19:42 ` Quentin Monnet
2019-05-23 20:42 ` [PATCH v2 bpf-next 11/12] bpftool/docs: add description of btf dump C option Andrii Nakryiko
2019-05-24 9:14 ` Quentin Monnet
2019-05-24 17:25 ` Andrii Nakryiko
2019-05-24 19:42 ` Quentin Monnet [this message]
2019-05-23 20:42 ` [PATCH v2 bpf-next 12/12] bpftool: update bash-completion w/ new c option for btf dump Andrii Nakryiko
2019-05-24 9:15 ` Quentin Monnet
2019-05-24 18:10 ` Andrii Nakryiko
2019-05-24 19:42 ` Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=017b901f-f942-77dd-4d85-b8a7f9ee79a6@netronome.com \
--to=quentin.monnet@netronome.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.