From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34573)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1YvoJ4-0003xc-IP
	for qemu-devel@nongnu.org; Fri, 22 May 2015 10:52:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1YvoJ1-0002sY-BV
	for qemu-devel@nongnu.org; Fri, 22 May 2015 10:52:14 -0400
Received: from mailout1.w1.samsung.com ([210.118.77.11]:11841)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <p.fedin@samsung.com>) id 1YvoJ1-0002qS-5M
	for qemu-devel@nongnu.org; Fri, 22 May 2015 10:52:11 -0400
Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245])
	by mailout1.w1.samsung.com
	(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5
	2014)) with ESMTP id <0NOR00MFJAMU2B70@mailout1.w1.samsung.com> for
	qemu-devel@nongnu.org; Fri, 22 May 2015 15:52:06 +0100 (BST)
From: Pavel Fedin <p.fedin@samsung.com>
References: <1430921082-16779-1-git-send-email-shlomopongratz@gmail.com>
	<1430921082-16779-3-git-send-email-shlomopongratz@gmail.com>
	<555F28BD.8080001@linaro.org>
In-reply-to: <555F28BD.8080001@linaro.org>
Date: Fri, 22 May 2015 17:52:04 +0300
Message-id: <019801d0949e$debee360$9c3caa20$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Content-language: ru
Subject: Re: [Qemu-devel] [PATCH RFC V2 2/4] Implment GIC-500
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Eric Auger' <eric.auger@linaro.org>, qemu-devel@nongnu.org, shlomopongratz@gmail.com, 'Shlomo Pongratz' <shlomo.pongratz@huawei.com>

 Hello!

> Please find some more comments inline.

 Since there are notes about code style, i would add one more thing. structures of v3
implementation keep old names (like GICState), and i would suggest to rename these things
(like GICv3State) in order to avoid confusion.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia