From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13D47C43332 for ; Tue, 2 Mar 2021 11:01:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF9F564EFC for ; Tue, 2 Mar 2021 11:01:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383221AbhCBKvx (ORCPT ); Tue, 2 Mar 2021 05:51:53 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:41702 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1379949AbhCBKWF (ORCPT ); Tue, 2 Mar 2021 05:22:05 -0500 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 122AHmce015298; Tue, 2 Mar 2021 11:20:10 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=AHNRA07W/8XeOi1fcP+UwN+hE9l5HeWlAvjNP7Od2XQ=; b=K44Nf8dxpJTK46y0qHK1yIq2djKmoAPatyObmNxYQPiIHtUDRntpEEGxwmjemolYJOln TwbbG4a5qd9k9WdP1v6bqkilm8txSV4YWh2FMjdeyLo0GsgGF4KSKVWDkXaI3jzl75y+ x84hXPiJBBmoociIaR/6Cv4F1QVmeyaMRocSFDuzJ7i0ljHCHU0VoSRtZyMIprqvkHEP Gsq7KBRJwOD0nOLLa0NZI6Q1MTY1hjGfS1xcN/CMXD4DTnGW0mdvpZNxSbwWD3l50Yfj r6gBbq9PjvdEQl60wr1Shi3WdX2iPAmaoNBZQ8kSJnLQpKWrnkDlvCnxz13uddjcsCbQ 8g== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 36yf9q1dun-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Mar 2021 11:20:10 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 93F86100034; Tue, 2 Mar 2021 11:20:09 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 717022C38D2; Tue, 2 Mar 2021 11:20:09 +0100 (CET) Received: from [10.211.13.170] (10.75.127.50) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 2 Mar 2021 11:20:08 +0100 Subject: Re: [PATCH v2 1/2] tty/serial: Add rx-tx-swap OF option to stm32-usart To: Martin DEVERA , CC: , Alexandre Torgue , Greg Kroah-Hartman , Rob Herring , , Maxime Coquelin , , Jiri Slaby , , Le Ray References: <20210227164157.30971-1-devik@eaxlabs.cz> <439a0d7a-cc0e-764b-7ed8-668b5a85f4a7@foss.st.com> From: Fabrice Gasnier Message-ID: <019b62e9-ec9b-d366-ee77-59c980d66a07@foss.st.com> Date: Tue, 2 Mar 2021 11:20:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG3NODE2.st.com (10.75.127.8) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761 definitions=2021-03-02_03:2021-03-01,2021-03-02 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/1/21 11:40 PM, Martin DEVERA wrote: > On 3/1/21 11:28 AM, Fabrice Gasnier wrote: >> On 2/27/21 5:41 PM, Martin Devera wrote: >>> STM32 F7/H7 usarts supports RX & TX pin swapping. >>> Add option to turn it on. >>> Tested on STM32MP157. >>> >>> Signed-off-by: Martin Devera >>> --- >>>   drivers/tty/serial/stm32-usart.c | 3 ++- >>>   drivers/tty/serial/stm32-usart.h | 1 + >>>   2 files changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/tty/serial/stm32-usart.c >>> b/drivers/tty/serial/stm32-usart.c >>> index b3675cf25a69..3650c8798061 100644 >>> --- a/drivers/tty/serial/stm32-usart.c >>> +++ b/drivers/tty/serial/stm32-usart.c >>> @@ -758,7 +758,7 @@ static void stm32_usart_set_termios(struct >>> uart_port *port, >>>       cr1 = USART_CR1_TE | USART_CR1_RE; >>>       if (stm32_port->fifoen) >>>           cr1 |= USART_CR1_FIFOEN; >>> -    cr2 = 0; >>> +    cr2 = stm32_port->swap ? USART_CR2_SWAP : 0; >> Hi Martin, >> >> Same could be done in the startup routine, that enables the port for >> reception (as described in Documentation/driver-api/serial/driver.rst) > Hello Fabrice, > > I already incorporated all your comments but I'm struggling with the one > above. > The code must be in stm32_usart_set_termios too, because CR2 is modified. Hi Martin, Yes, sure, > What is the reason to have it in startup() ? RX is enabled at both places. So the swap setting should be there too. > Is it because USART can be started without calling set_termios at all ? Yes, that's what the driver API expects: "startup(port)" ... "Enable the port for reception." Best Regards, Fabrice > Like > to reuse bootloader's last settings ? > > Thanks, Martin > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EC99C433DB for ; Tue, 2 Mar 2021 10:21:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D956E6146D for ; Tue, 2 Mar 2021 10:21:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D956E6146D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w9+XcojpRCov33nAVmIRQ++81PGD/1RMw4MDRQoQN58=; b=vdh+g/nzyIefGPiP4CXs3ftLG /HfgZtshsmvTdOJT6bnYE0PnELHJU+v9A6H/02RJorNK9Ug2sakvgxmHg4MpIBmxO9iNvhaqnCY1L amyIcLUKUItQEfpFhVIQkxmc2O8WR2BNypsa14kUShf9Ut1F4hYgnmqHZPErB14hzx8l0WEQeD2Ea Srlt42lAfS3wYZCFbaM9V6MJXsy5rKWAuUy/tSO1rFj3qzTpIckaiju/dnQCRGEWyPs0M8VrJ3Kuj LEOlj3zSB/7I0Pml4NAefUotQGaqkPHSRV3RgoYaLT7bGKhjMdoexgDb7+T6FlluunXFMrwCbafnY P2krhLRDg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lH28f-0002Sc-LF; Tue, 02 Mar 2021 10:20:25 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lH28b-0002Rj-HZ for linux-arm-kernel@lists.infradead.org; Tue, 02 Mar 2021 10:20:22 +0000 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 122AHmce015298; Tue, 2 Mar 2021 11:20:10 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=AHNRA07W/8XeOi1fcP+UwN+hE9l5HeWlAvjNP7Od2XQ=; b=K44Nf8dxpJTK46y0qHK1yIq2djKmoAPatyObmNxYQPiIHtUDRntpEEGxwmjemolYJOln TwbbG4a5qd9k9WdP1v6bqkilm8txSV4YWh2FMjdeyLo0GsgGF4KSKVWDkXaI3jzl75y+ x84hXPiJBBmoociIaR/6Cv4F1QVmeyaMRocSFDuzJ7i0ljHCHU0VoSRtZyMIprqvkHEP Gsq7KBRJwOD0nOLLa0NZI6Q1MTY1hjGfS1xcN/CMXD4DTnGW0mdvpZNxSbwWD3l50Yfj r6gBbq9PjvdEQl60wr1Shi3WdX2iPAmaoNBZQ8kSJnLQpKWrnkDlvCnxz13uddjcsCbQ 8g== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 36yf9q1dun-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 02 Mar 2021 11:20:10 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 93F86100034; Tue, 2 Mar 2021 11:20:09 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 717022C38D2; Tue, 2 Mar 2021 11:20:09 +0100 (CET) Received: from [10.211.13.170] (10.75.127.50) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 2 Mar 2021 11:20:08 +0100 Subject: Re: [PATCH v2 1/2] tty/serial: Add rx-tx-swap OF option to stm32-usart To: Martin DEVERA , References: <20210227164157.30971-1-devik@eaxlabs.cz> <439a0d7a-cc0e-764b-7ed8-668b5a85f4a7@foss.st.com> From: Fabrice Gasnier Message-ID: <019b62e9-ec9b-d366-ee77-59c980d66a07@foss.st.com> Date: Tue, 2 Mar 2021 11:20:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG3NODE2.st.com (10.75.127.8) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.761 definitions=2021-03-02_03:2021-03-01, 2021-03-02 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210302_052021_909614_80850A3E X-CRM114-Status: GOOD ( 22.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexandre Torgue , Greg Kroah-Hartman , Rob Herring , Le Ray , Maxime Coquelin , linux-serial@vger.kernel.org, Jiri Slaby , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMy8xLzIxIDExOjQwIFBNLCBNYXJ0aW4gREVWRVJBIHdyb3RlOgo+IE9uIDMvMS8yMSAxMToy OCBBTSwgRmFicmljZSBHYXNuaWVyIHdyb3RlOgo+PiBPbiAyLzI3LzIxIDU6NDEgUE0sIE1hcnRp biBEZXZlcmEgd3JvdGU6Cj4+PiBTVE0zMiBGNy9INyB1c2FydHMgc3VwcG9ydHMgUlggJiBUWCBw aW4gc3dhcHBpbmcuCj4+PiBBZGQgb3B0aW9uIHRvIHR1cm4gaXQgb24uCj4+PiBUZXN0ZWQgb24g U1RNMzJNUDE1Ny4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBNYXJ0aW4gRGV2ZXJhIDxkZXZpa0Bl YXhsYWJzLmN6Pgo+Pj4gLS0tCj4+PiDCoCBkcml2ZXJzL3R0eS9zZXJpYWwvc3RtMzItdXNhcnQu YyB8IDMgKystCj4+PiDCoCBkcml2ZXJzL3R0eS9zZXJpYWwvc3RtMzItdXNhcnQuaCB8IDEgKwo+ Pj4gwqAgMiBmaWxlcyBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPj4+ Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy90dHkvc2VyaWFsL3N0bTMyLXVzYXJ0LmMKPj4+IGIv ZHJpdmVycy90dHkvc2VyaWFsL3N0bTMyLXVzYXJ0LmMKPj4+IGluZGV4IGIzNjc1Y2YyNWE2OS4u MzY1MGM4Nzk4MDYxIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy90dHkvc2VyaWFsL3N0bTMyLXVz YXJ0LmMKPj4+ICsrKyBiL2RyaXZlcnMvdHR5L3NlcmlhbC9zdG0zMi11c2FydC5jCj4+PiBAQCAt NzU4LDcgKzc1OCw3IEBAIHN0YXRpYyB2b2lkIHN0bTMyX3VzYXJ0X3NldF90ZXJtaW9zKHN0cnVj dAo+Pj4gdWFydF9wb3J0ICpwb3J0LAo+Pj4gwqDCoMKgwqDCoCBjcjEgPSBVU0FSVF9DUjFfVEUg fCBVU0FSVF9DUjFfUkU7Cj4+PiDCoMKgwqDCoMKgIGlmIChzdG0zMl9wb3J0LT5maWZvZW4pCj4+ PiDCoMKgwqDCoMKgwqDCoMKgwqAgY3IxIHw9IFVTQVJUX0NSMV9GSUZPRU47Cj4+PiAtwqDCoMKg IGNyMiA9IDA7Cj4+PiArwqDCoMKgIGNyMiA9IHN0bTMyX3BvcnQtPnN3YXAgPyBVU0FSVF9DUjJf U1dBUCA6IDA7Cj4+IEhpIE1hcnRpbiwKPj4KPj4gU2FtZSBjb3VsZCBiZSBkb25lIGluIHRoZSBz dGFydHVwIHJvdXRpbmUsIHRoYXQgZW5hYmxlcyB0aGUgcG9ydCBmb3IKPj4gcmVjZXB0aW9uIChh cyBkZXNjcmliZWQgaW4gRG9jdW1lbnRhdGlvbi9kcml2ZXItYXBpL3NlcmlhbC9kcml2ZXIucnN0 KQo+IEhlbGxvIEZhYnJpY2UsCj4gCj4gSSBhbHJlYWR5IGluY29ycG9yYXRlZCBhbGwgeW91ciBj b21tZW50cyBidXQgSSdtIHN0cnVnZ2xpbmcgd2l0aCB0aGUgb25lCj4gYWJvdmUuCj4gVGhlIGNv ZGUgbXVzdCBiZSBpbiBzdG0zMl91c2FydF9zZXRfdGVybWlvcyB0b28sIGJlY2F1c2UgQ1IyIGlz IG1vZGlmaWVkLgoKSGkgTWFydGluLAoKWWVzLCBzdXJlLAoKPiBXaGF0IGlzIHRoZSByZWFzb24g dG8gaGF2ZSBpdCBpbiBzdGFydHVwKCkgPwoKUlggaXMgZW5hYmxlZCBhdCBib3RoIHBsYWNlcy4g U28gdGhlIHN3YXAgc2V0dGluZyBzaG91bGQgYmUgdGhlcmUgdG9vLgoKPiBJcyBpdCBiZWNhdXNl IFVTQVJUIGNhbiBiZSBzdGFydGVkIHdpdGhvdXQgY2FsbGluZyBzZXRfdGVybWlvcyBhdCBhbGwg PwoKWWVzLCB0aGF0J3Mgd2hhdCB0aGUgZHJpdmVyIEFQSSBleHBlY3RzOiAic3RhcnR1cChwb3J0 KSIgLi4uICJFbmFibGUgdGhlCnBvcnQgZm9yIHJlY2VwdGlvbi4iCgpCZXN0IFJlZ2FyZHMsCkZh YnJpY2UKCj4gTGlrZQo+IHRvIHJldXNlIGJvb3Rsb2FkZXIncyBsYXN0IHNldHRpbmdzID8KPiAK PiBUaGFua3MsIE1hcnRpbgo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=