From: Dorian Taylor <dorian.taylor.lists@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org, Brandon Williams <bmwill@google.com>
Subject: Re: bug in HTTP protocol spec
Date: Thu, 22 Feb 2018 12:12:54 -0800 [thread overview]
Message-ID: <01B07AA7-B2A4-4A81-B1F0-E2EC3D6BFBF9@gmail.com> (raw)
In-Reply-To: <xmqqbmggx063.fsf@gitster-ct.c.googlers.com>
[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]
> On Feb 22, 2018, at 12:02 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
> I saw somewhere "Apple-Mail" and a phrase "repaste". So perhaps
> copy&paste on the client is involved in the whitespace damage (of
> course the original could be broken, but I somehow doubt it).
https://doriantaylor.com/file/well-ill-be-damned.png
> For what it's worth, I am slightly negative on this addition. It
> makes it inconsistent if we only mention it about _this_ flush and
> not any other flush. It even gets in the way of learning the
> protocol by new people reading it, by giving an impression that
> somehow LF is outside and in between packet line.
>
> Thanks.
This patch exists because I was asked to write it. I don’t know squat about this protocol other than the fact that I followed the spec and it didn’t work. I traced a known-good protocol endpoint and found it contained content that didn’t agree with the spec. I then obliged the request to submit a patch with *what I knew to be true* about the sample that actually worked. I then followed the recommendations *advertised on GitHub* for submitting the patch.
You’re welcome.
--
Dorian Taylor
Make things. Make sense.
https://doriantaylor.com
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 842 bytes --]
next prev parent reply other threads:[~2018-02-22 20:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 18:29 bug in HTTP protocol spec Dorian Taylor
2018-02-21 22:15 ` Jeff King
2018-02-21 23:50 ` Dorian Taylor
2018-02-22 5:37 ` Jonathan Nieder
2018-02-22 7:23 ` Dorian Taylor
2018-02-22 10:08 ` Jeff King
2018-02-22 16:16 ` Dorian Taylor
2018-02-22 20:02 ` Junio C Hamano
2018-02-22 20:12 ` Dorian Taylor [this message]
2018-03-03 5:27 ` [PATCH] smart-http: document flush after "# service" line Jeff King
2018-03-03 8:28 ` Eric Sunshine
2018-03-03 10:02 ` Jeff King
2018-02-22 17:52 ` bug in HTTP protocol spec Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01B07AA7-B2A4-4A81-B1F0-E2EC3D6BFBF9@gmail.com \
--to=dorian.taylor.lists@gmail.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.