From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Guo, Jia" Subject: Re: [PATCH v2 2/2] net/i40e: add hot plug monitor in i40e Date: Thu, 29 Jun 2017 07:47:32 +0000 Message-ID: <01BA8470C017D6468C8290E4B9C5E1E83B23E394@shsmsx102.ccr.corp.intel.com> References: <1495986280-26207-1-git-send-email-jia.guo@intel.com> <1498648044-57541-1-git-send-email-jia.guo@intel.com> <1498648044-57541-2-git-send-email-jia.guo@intel.com> <20170628203441.22e9dbb8@xeon-e3> <9BB6961774997848B5B42BEC655768F810DB5BBA@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Zhang, Helin" , "dev@dpdk.org" , "Chang, Cunyin" , "Liang, Cunming" To: "Wu, Jingjing" , Stephen Hemminger Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 325A7271 for ; Thu, 29 Jun 2017 09:50:44 +0200 (CEST) In-Reply-To: <9BB6961774997848B5B42BEC655768F810DB5BBA@SHSMSX103.ccr.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Agree with jingjing. That patch is definitely not for generic fashion of hot plug, the uevent j= ust give the adding approach to monitor the remove event even if the drive= r not add it as interrupt , we know mlx driver have already implement the e= vent of remove interrupt into their infinite framework driver, but other dr= iver maybe not yet. So uevent is not unique for i40e or other intel nic, the aim just let more = diversity drivers which use pci-uio framework to use the common hot plug f= eature in DPDK. Best regards, Jeff Guo -----Original Message----- From: Wu, Jingjing=20 Sent: Thursday, June 29, 2017 12:48 PM To: Stephen Hemminger ; Guo, Jia Cc: Zhang, Helin ; dev@dpdk.org; Chang, Cunyin ; Liang, Cunming Subject: RE: [dpdk-dev] [PATCH v2 2/2] net/i40e: add hot plug monitor in i4= 0e > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Thursday, June 29, 2017 11:35 AM > To: Guo, Jia > Cc: Zhang, Helin ; Wu, Jingjing=20 > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: add hot plug monitor=20 > in i40e >=20 > On Wed, 28 Jun 2017 19:07:24 +0800 > Jeff Guo wrote: >=20 > > From: "Guo, Jia" > > > > This patch enable the hot plug feature in i40e, by monitoring the=20 > > hot plug uevent of the device. When remove event got, call the app=20 > > callback function to handle the detach process. > > > > Signed-off-by: Guo, Jia > > --- >=20 > Hot plug is good and needed. >=20 > But it needs to be done in a generic fashion in the bus layer. > There is nothing about uevents that are unique to i40e or even Intel devi= ces. > Plus the way hotplug is handled is OS specific, so this isn't going to=20 > work well on BSD. >=20 This patch is not a way to full support hut plug. And we know it is handled= in OS specific. This patch just provides a way to tell DPDK user the remove happened on thi= s device (DPDK dev). And Mlx driver already supports that with patch http://dpdk.org/dev/patchwo= rk/patch/23695/ What GuoJia did is just making the EVENT can be process by application thro= ugh interrupt callback Mechanisms. > Sorry if I sound like a broken record but there has been a repeated=20 > pattern of Intel developers putting their head down (or in the sand)=20 > and creating functionality inside device driver. Sorry, I cannot agree. Thanks Jingjing