From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Guo, Jia" <jia.guo@intel.com>
Subject: Re: [PATCH v7 1/2] eal: add uevent monitor for hot plug
Date: Tue, 9 Jan 2018 12:08:52 +0000
Message-ID: <01BA8470C017D6468C8290E4B9C5E1E83B2D1493@shsmsx102.ccr.corp.intel.com>
References: <1509567405-27439-3-git-send-email-jia.guo@intel.com>
 <2803089.mJXnisXhBj@xps>
 <01BA8470C017D6468C8290E4B9C5E1E83B2D13F4@shsmsx102.ccr.corp.intel.com>
 <3539603.0DoXzmkF5E@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: Mordechay Haimovsky <motih@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>, "Richardson,
 Bruce" <bruce.richardson@intel.com>, "Yigit, Ferruh"
 <ferruh.yigit@intel.com>, "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "shreyansh.jain@nxp.com" <shreyansh.jain@nxp.com>, "Wu, Jingjing"
 <jingjing.wu@intel.com>, "Zhang, Helin" <helin.zhang@intel.com>, "Van
 Haaren, Harry" <harry.van.haaren@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 7A6BB1B16D
 for <dev@dpdk.org>; Tue,  9 Jan 2018 13:08:56 +0100 (CET)
In-Reply-To: <3539603.0DoXzmkF5E@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Your comments about split it totally make sense ,no doubt that, but my ques=
tion is that if split api with the funcational , so the function part shoul=
d be set null implement or stake. Any other good idea or tip for that.=20

Best regards,
Jeff Guo


-----Original Message-----
From: Thomas Monjalon [mailto:thomas@monjalon.net]=20
Sent: Tuesday, January 9, 2018 7:45 PM
To: Guo, Jia <jia.guo@intel.com>
Cc: Mordechay Haimovsky <motih@mellanox.com>; dev@dpdk.org; stephen@network=
plumber.org; Richardson, Bruce <bruce.richardson@intel.com>; Yigit, Ferruh =
<ferruh.yigit@intel.com>; gaetan.rivet@6wind.com; Ananyev, Konstantin <kons=
tantin.ananyev@intel.com>; shreyansh.jain@nxp.com; Wu, Jingjing <jingjing.w=
u@intel.com>; Zhang, Helin <helin.zhang@intel.com>; Van Haaren, Harry <harr=
y.van.haaren@intel.com>
Subject: Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug

09/01/2018 12:39, Guo, Jia:
> So, how can separate the patch into more small patch, use stake or null i=
mplement in function. I think we should consider if it is a economic way no=
w, if I could explain more detail in code for you all not very familiar the=
 background? I have sent v8, please check, thanks all.=20

The v8 is not split enough.
Please try to address all my comments.