All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst
Date: Fri, 5 Mar 2021 11:07:31 +0800	[thread overview]
Message-ID: <01a0ff76-6fa7-3196-8760-e7f6f163ef64@huawei.com> (raw)
In-Reply-To: <YEFBAuP26t0RzVHZ@google.com>

On 2021/3/5 4:20, Jaegeuk Kim wrote:
> On 02/27, Jaegeuk Kim wrote:
>> On 02/04, Chao Yu wrote:
>>> Jaegeuk,
>>>
>>> On 2021/2/2 16:00, Chao Yu wrote:
>>>> -	for (i = 0; i < dic->nr_cpages; i++) {
>>>> +	for (i = 0; i < cc->nr_cpages; i++) {
>>>>    		struct page *page = dic->cpages[i];
>>>
>>> por_fsstress still hang in this line?
>>
>> I'm stuck on testing the patches, since the latest kernel is panicking somehow.
>> Let me update later, once I can test a bit. :(
> 
> It seems this works without error.
> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=4e6e1364dccba80ed44925870b97fbcf989b96c9

Ah, good news.

Thanks for helping to test the patch. :)

Thanks,

> 
>>
>>>
>>> Thanks,
>>>
>>>>    		block_t blkaddr;
>>>>    		struct bio_post_read_ctx *ctx;
>>>> @@ -2201,6 +2207,14 @@ int f2fs_read_multi_pages(struct compress_ctx *cc, struct bio **bio_ret,
>>>>    		blkaddr = data_blkaddr(dn.inode, dn.node_page,
>>>>    						dn.ofs_in_node + i + 1);
>>>> +		f2fs_wait_on_block_writeback(inode, blkaddr);
>>>> +
>>>> +		if (f2fs_load_compressed_page(sbi, page, blkaddr)) {
>>>> +			if (atomic_dec_and_test(&dic->remaining_pages))
>>>> +				f2fs_decompress_cluster(dic);
>>>> +			continue;
>>>> +		}
>>>> +
>>
>>
>> _______________________________________________
>> Linux-f2fs-devel mailing list
>> Linux-f2fs-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> .
> 

WARNING: multiple messages have this Message-ID
From: Chao Yu <yuchao0@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst
Date: Fri, 5 Mar 2021 11:07:31 +0800	[thread overview]
Message-ID: <01a0ff76-6fa7-3196-8760-e7f6f163ef64@huawei.com> (raw)
In-Reply-To: <YEFBAuP26t0RzVHZ@google.com>

On 2021/3/5 4:20, Jaegeuk Kim wrote:
> On 02/27, Jaegeuk Kim wrote:
>> On 02/04, Chao Yu wrote:
>>> Jaegeuk,
>>>
>>> On 2021/2/2 16:00, Chao Yu wrote:
>>>> -	for (i = 0; i < dic->nr_cpages; i++) {
>>>> +	for (i = 0; i < cc->nr_cpages; i++) {
>>>>    		struct page *page = dic->cpages[i];
>>>
>>> por_fsstress still hang in this line?
>>
>> I'm stuck on testing the patches, since the latest kernel is panicking somehow.
>> Let me update later, once I can test a bit. :(
> 
> It seems this works without error.
> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=4e6e1364dccba80ed44925870b97fbcf989b96c9

Ah, good news.

Thanks for helping to test the patch. :)

Thanks,

> 
>>
>>>
>>> Thanks,
>>>
>>>>    		block_t blkaddr;
>>>>    		struct bio_post_read_ctx *ctx;
>>>> @@ -2201,6 +2207,14 @@ int f2fs_read_multi_pages(struct compress_ctx *cc, struct bio **bio_ret,
>>>>    		blkaddr = data_blkaddr(dn.inode, dn.node_page,
>>>>    						dn.ofs_in_node + i + 1);
>>>> +		f2fs_wait_on_block_writeback(inode, blkaddr);
>>>> +
>>>> +		if (f2fs_load_compressed_page(sbi, page, blkaddr)) {
>>>> +			if (atomic_dec_and_test(&dic->remaining_pages))
>>>> +				f2fs_decompress_cluster(dic);
>>>> +			continue;
>>>> +		}
>>>> +
>>
>>
>> _______________________________________________
>> Linux-f2fs-devel mailing list
>> Linux-f2fs-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> .
> 


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2021-03-05  3:07 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02  8:00 [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst Chao Yu
2021-02-02  8:00 ` [f2fs-dev] " Chao Yu
2021-02-04  3:25 ` Chao Yu
2021-02-04  3:25   ` [f2fs-dev] " Chao Yu
2021-02-28  5:09   ` Jaegeuk Kim
2021-02-28  5:09     ` [f2fs-dev] " Jaegeuk Kim
2021-03-04 20:20     ` Jaegeuk Kim
2021-03-04 20:20       ` Jaegeuk Kim
2021-03-05  3:07       ` Chao Yu [this message]
2021-03-05  3:07         ` Chao Yu
2021-03-09  0:01         ` Jaegeuk Kim
2021-03-09  0:01           ` Jaegeuk Kim
2021-03-09  2:49           ` Chao Yu
2021-03-09  2:49             ` Chao Yu
2021-03-10 20:52             ` Jaegeuk Kim
2021-03-10 20:52               ` Jaegeuk Kim
2021-04-21  9:08               ` Chao Yu
2021-04-21  9:08                 ` Chao Yu
2021-04-22  3:59                 ` Jaegeuk Kim
2021-04-22  3:59                   ` Jaegeuk Kim
2021-04-22  6:07                   ` Chao Yu
2021-04-22  6:07                     ` Chao Yu
2021-05-10  9:05                     ` Chao Yu
2021-05-10  9:05                       ` Chao Yu
2021-05-10 14:35                       ` Jaegeuk Kim
2021-05-10 14:35                         ` Jaegeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01a0ff76-6fa7-3196-8760-e7f6f163ef64@huawei.com \
    --to=yuchao0@huawei.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.