From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D28E8C433DB for ; Fri, 5 Mar 2021 03:07:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96E3264FEB for ; Fri, 5 Mar 2021 03:07:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229674AbhCEDHh (ORCPT ); Thu, 4 Mar 2021 22:07:37 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:12694 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbhCEDHh (ORCPT ); Thu, 4 Mar 2021 22:07:37 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DsCKJ1x5yzlT2D; Fri, 5 Mar 2021 11:05:24 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by smtp.huawei.com (10.3.19.214) with Microsoft SMTP Server (TLS) id 14.3.498.0; Fri, 5 Mar 2021 11:07:31 +0800 Subject: Re: [f2fs-dev] [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst To: Jaegeuk Kim CC: , References: <20210202080056.51658-1-yuchao0@huawei.com> <46e9924c-0086-cd2a-2e93-7149b92ba27e@huawei.com> From: Chao Yu Message-ID: <01a0ff76-6fa7-3196-8760-e7f6f163ef64@huawei.com> Date: Fri, 5 Mar 2021 11:07:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.110.154] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/3/5 4:20, Jaegeuk Kim wrote: > On 02/27, Jaegeuk Kim wrote: >> On 02/04, Chao Yu wrote: >>> Jaegeuk, >>> >>> On 2021/2/2 16:00, Chao Yu wrote: >>>> - for (i = 0; i < dic->nr_cpages; i++) { >>>> + for (i = 0; i < cc->nr_cpages; i++) { >>>> struct page *page = dic->cpages[i]; >>> >>> por_fsstress still hang in this line? >> >> I'm stuck on testing the patches, since the latest kernel is panicking somehow. >> Let me update later, once I can test a bit. :( > > It seems this works without error. > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=4e6e1364dccba80ed44925870b97fbcf989b96c9 Ah, good news. Thanks for helping to test the patch. :) Thanks, > >> >>> >>> Thanks, >>> >>>> block_t blkaddr; >>>> struct bio_post_read_ctx *ctx; >>>> @@ -2201,6 +2207,14 @@ int f2fs_read_multi_pages(struct compress_ctx *cc, struct bio **bio_ret, >>>> blkaddr = data_blkaddr(dn.inode, dn.node_page, >>>> dn.ofs_in_node + i + 1); >>>> + f2fs_wait_on_block_writeback(inode, blkaddr); >>>> + >>>> + if (f2fs_load_compressed_page(sbi, page, blkaddr)) { >>>> + if (atomic_dec_and_test(&dic->remaining_pages)) >>>> + f2fs_decompress_cluster(dic); >>>> + continue; >>>> + } >>>> + >> >> >> _______________________________________________ >> Linux-f2fs-devel mailing list >> Linux-f2fs-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9459C433DB for ; Fri, 5 Mar 2021 03:07:57 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81A9864FF0; Fri, 5 Mar 2021 03:07:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81A9864FF0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1lI0om-0007g6-SH; Fri, 05 Mar 2021 03:07:56 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lI0ol-0007fy-1i for linux-f2fs-devel@lists.sourceforge.net; Fri, 05 Mar 2021 03:07:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9IoSglGPl4uxKXg6bqFLKo2ojkeT4YAb8eVB2BWHtuU=; b=grXlLu1Aw8eflE72lvKsTnvYtu GfvOHAXCUGHO6qBOCxV5Ytz2ZLjvSV1OXET8ZkFjyLdKrY5DFrDG3NCLUCjyhSYwhtxdvXRsCC43/ peKrItk2W+RxZwk7i4X91pFyAa0RoR1UFhkBn9Rm9ddjyG2Sy8pLkxOFvK2Cay8XsL4c=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9IoSglGPl4uxKXg6bqFLKo2ojkeT4YAb8eVB2BWHtuU=; b=D+wPO+VA6K5LxhGkKVamD9nuon MET8BR3vuk6riYz/Ni2hWznLAIaD6b1iQ2hdDel+ylde2yTH03lhq4hLeAV58ICURpk4Qy2zJS/WV 2MuSwUuhwAyMZhWlY+3E2WzU80vsKvrhJ1vS9xqMO9akyiQQe/cR57PLfVSJTpqDVrB8=; Received: from szxga04-in.huawei.com ([45.249.212.190]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1lI0oa-00EY72-AT for linux-f2fs-devel@lists.sourceforge.net; Fri, 05 Mar 2021 03:07:54 +0000 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4DsCKJ1x5yzlT2D; Fri, 5 Mar 2021 11:05:24 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by smtp.huawei.com (10.3.19.214) with Microsoft SMTP Server (TLS) id 14.3.498.0; Fri, 5 Mar 2021 11:07:31 +0800 To: Jaegeuk Kim References: <20210202080056.51658-1-yuchao0@huawei.com> <46e9924c-0086-cd2a-2e93-7149b92ba27e@huawei.com> From: Chao Yu Message-ID: <01a0ff76-6fa7-3196-8760-e7f6f163ef64@huawei.com> Date: Fri, 5 Mar 2021 11:07:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.136.110.154] X-CFilter-Loop: Reflected X-Headers-End: 1lI0oa-00EY72-AT Subject: Re: [f2fs-dev] [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/3/5 4:20, Jaegeuk Kim wrote: > On 02/27, Jaegeuk Kim wrote: >> On 02/04, Chao Yu wrote: >>> Jaegeuk, >>> >>> On 2021/2/2 16:00, Chao Yu wrote: >>>> - for (i = 0; i < dic->nr_cpages; i++) { >>>> + for (i = 0; i < cc->nr_cpages; i++) { >>>> struct page *page = dic->cpages[i]; >>> >>> por_fsstress still hang in this line? >> >> I'm stuck on testing the patches, since the latest kernel is panicking somehow. >> Let me update later, once I can test a bit. :( > > It seems this works without error. > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=4e6e1364dccba80ed44925870b97fbcf989b96c9 Ah, good news. Thanks for helping to test the patch. :) Thanks, > >> >>> >>> Thanks, >>> >>>> block_t blkaddr; >>>> struct bio_post_read_ctx *ctx; >>>> @@ -2201,6 +2207,14 @@ int f2fs_read_multi_pages(struct compress_ctx *cc, struct bio **bio_ret, >>>> blkaddr = data_blkaddr(dn.inode, dn.node_page, >>>> dn.ofs_in_node + i + 1); >>>> + f2fs_wait_on_block_writeback(inode, blkaddr); >>>> + >>>> + if (f2fs_load_compressed_page(sbi, page, blkaddr)) { >>>> + if (atomic_dec_and_test(&dic->remaining_pages)) >>>> + f2fs_decompress_cluster(dic); >>>> + continue; >>>> + } >>>> + >> >> >> _______________________________________________ >> Linux-f2fs-devel mailing list >> Linux-f2fs-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > . > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel