From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [RFC PATCH 2/4] ethdev: introduce Rx queue offloads API Date: Tue, 29 Aug 2017 14:11:59 +0100 Message-ID: <01aab945-be22-04e7-6b57-5326ec133f5c@intel.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Shahaf Shuler , dev@dpdk.org Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 32EE111F5 for ; Tue, 29 Aug 2017 15:12:01 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/7/2017 11:54 AM, Shahaf Shuler wrote: > Introduce a new API to configure Rx offloads. > > The new API will re-use existing DEV_RX_OFFLOAD_* flags > to enable the different offloads. This will ease the process > of adding a new Rx offloads, as no ABI breakage is involved. > In addition, the offload configuration can be done per queue, > instead of per port. > > The Rx queue offload API can be used only with devices which advertize > the RTE_ETH_DEV_RXQ_OFFLOAD capability. > > The old Rx offloads API is kept for the meanwhile, in order to enable a > smooth transition for PMDs and application to the new API. > > Signed-off-by: Shahaf Shuler <...> > /** > @@ -691,6 +698,12 @@ struct rte_eth_rxq_conf { > uint16_t rx_free_thresh; /**< Drives the freeing of RX descriptors. */ > uint8_t rx_drop_en; /**< Drop packets if no descriptors are available. */ > uint8_t rx_deferred_start; /**< Do not start queue with rte_eth_dev_start(). */ > + uint64_t offloads; Also there is a documentation aims to help PMDs on developing features [1], currently for Rx offload features it documents rxmode fields as to be used. Can you please update that document too, according new API, new field to use, both for Rx and Tx. [1] doc/guides/nics/features.rst