From: Akhil P Oommen <quic_akhilpo@quicinc.com>
To: Douglas Anderson <dianders@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: <konrad.dybcio@somainline.org>, <swboyd@chromium.org>,
<kgodara@codeaurora.org>, <mka@chromium.org>,
<sibis@codeaurora.org>, <pmaliset@codeaurora.org>,
<quic_rjendra@quicinc.com>, Andy Gross <agross@kernel.org>,
Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/5] arm64: dts: qcom: sc7280: Fix gmu unit address
Date: Tue, 1 Feb 2022 12:57:30 +0530 [thread overview]
Message-ID: <01aac7b1-88e9-32e3-9b3c-625a2b03bdce@quicinc.com> (raw)
In-Reply-To: <20220125144316.v2.1.I19f60014e9be4b9dda4d66b5d56ef3d9600b6e10@changeid>
On 1/26/2022 4:14 AM, Douglas Anderson wrote:
> When processing sc7280 device trees, I can see:
>
> Warning (simple_bus_reg): /soc@0/gmu@3d69000:
> simple-bus unit address format error, expected "3d6a000"
>
> There's a clear typo in the node name. Fix it.
>
> Fixes: 96c471970b7b ("arm64: dts: qcom: sc7280: Add gpu support")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>
> (no changes since v1)
>
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 937c2e0e93eb..eab7a8505053 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -1790,7 +1790,7 @@ opp-550000000 {
> };
> };
>
> - gmu: gmu@3d69000 {
> + gmu: gmu@3d6a000 {
> compatible="qcom,adreno-gmu-635.0", "qcom,adreno-gmu";
> reg = <0 0x03d6a000 0 0x34000>,
> <0 0x3de0000 0 0x10000>,
My bad! Thanks for the fix.
fwiw, Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
-Akhil.
next prev parent reply other threads:[~2022-02-01 7:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 22:44 [PATCH v2 0/5] arm64: dts: qcom: sc7280: Introduce herobrine-rev1 Douglas Anderson
2022-01-25 22:44 ` [PATCH v2 1/5] arm64: dts: qcom: sc7280: Fix gmu unit address Douglas Anderson
2022-02-01 7:27 ` Akhil P Oommen [this message]
2022-01-25 22:44 ` [PATCH v2 2/5] arm64: dts: qcom: sc7280: Move herobrine-r0 to its own dts Douglas Anderson
2022-01-25 22:44 ` [PATCH v2 3/5] arm64: dts: qcom: sc7280: Factor out Chrome common fragment Douglas Anderson
2022-02-01 5:19 ` (subset) " Bjorn Andersson
2022-01-25 22:44 ` [PATCH v2 4/5] arm64: dts: qcom: sc7280: Factor gpio.h include to sc7280.dtsi Douglas Anderson
2022-01-25 22:54 ` Stephen Boyd
2022-01-25 22:44 ` [PATCH v2 5/5] arm64: dts: qcom: sc7280: Add herobrine-r1 Douglas Anderson
2022-01-25 22:58 ` Stephen Boyd
2022-01-25 23:46 ` Doug Anderson
2022-01-26 3:01 ` Bjorn Andersson
2022-01-27 21:16 ` Stephen Boyd
2022-01-31 16:41 ` Bjorn Andersson
2022-01-31 16:50 ` Doug Anderson
2022-02-01 1:01 ` Doug Anderson
2022-02-02 21:32 ` Doug Anderson
2022-02-03 21:55 ` Stephen Boyd
2022-01-31 16:44 ` Doug Anderson
2022-02-03 21:50 ` Stephen Boyd
2022-01-31 18:24 ` (subset) [PATCH v2 0/5] arm64: dts: qcom: sc7280: Introduce herobrine-rev1 Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01aac7b1-88e9-32e3-9b3c-625a2b03bdce@quicinc.com \
--to=quic_akhilpo@quicinc.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=kgodara@codeaurora.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=pmaliset@codeaurora.org \
--cc=quic_rjendra@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.