From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toshiaki Makita Subject: Re: [PATCH net-next v6 2/2] bridge: vlan: signal if anything changed on vlan add Date: Sat, 28 Oct 2017 08:34:03 +0900 Message-ID: <01acc055-ad4e-c35b-e6b5-5f0493e9c5ac@gmail.com> References: <1f6df7e3-cd05-9b96-9f45-49c433011ff2@cumulusnetworks.com> <1509099577-5959-1-git-send-email-nikolay@cumulusnetworks.com> <1509099577-5959-3-git-send-email-nikolay@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Cc: roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org, mrv@mojatatu.com, dsa@cumulusnetworks.com, davem@davemloft.net To: Nikolay Aleksandrov , netdev@vger.kernel.org Return-path: In-Reply-To: <1509099577-5959-3-git-send-email-nikolay@cumulusnetworks.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On 17/10/27 (金) 19:19, Nikolay Aleksandrov wrote: > Before this patch there was no way to tell if the vlan add operation > actually changed anything, thus we would always generate a notification > on adds. Let's make the notifications more precise and generate them > only if anything changed, so use the new bool parameter to signal that the > vlan was updated. We cannot return an error because there are valid use > cases that will be broken (e.g. overlapping range add) and also we can't > risk masking errors due to calls into drivers for vlan add which can > potentially return anything. > > Signed-off-by: Nikolay Aleksandrov Reviewed-by: Toshiaki Makita Toshiaki Makita From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=ry1u6dFP9VPVeVBN49nxl4dOmjIWDWyPAVFORKq8OOs=; b=V7LrDmH3PmnXGFZ8ph7dHMhiZxNvYsNow+9j978REebbO9/Jh574GNBmTl9Yiwt7Nr qZBXOl2rettETDVbMuR/6yakBvnBQ/KL65Vrb+qw6CYtdROyykC/0g4P2leQgu7fRf1Y GtwcLP5bYRoq8TpP2c83cFQrbXBvk5Dq9j4CErXF15uRuiyZvYsRJV2kyQ2hA5LGq8fp PcunzjMLmdSSinC7gdql7eoEGkO4LpG+lX+/+qI03gYHnqDGq9Iv03HoHQ7i/K/iBlQX YJ4RVl6YwGkHWnzf2O+SbIaQdQsHr6H5Jqyk1KX/9v+pLqtcOXnUqQCJobBJKoBy5ea8 nfFg== References: <1f6df7e3-cd05-9b96-9f45-49c433011ff2@cumulusnetworks.com> <1509099577-5959-1-git-send-email-nikolay@cumulusnetworks.com> <1509099577-5959-3-git-send-email-nikolay@cumulusnetworks.com> From: Toshiaki Makita Message-ID: <01acc055-ad4e-c35b-e6b5-5f0493e9c5ac@gmail.com> Date: Sat, 28 Oct 2017 08:34:03 +0900 MIME-Version: 1.0 In-Reply-To: <1509099577-5959-3-git-send-email-nikolay@cumulusnetworks.com> Content-Type: text/plain; charset=iso-2022-jp; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net-next v6 2/2] bridge: vlan: signal if anything changed on vlan add List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikolay Aleksandrov , netdev@vger.kernel.org Cc: roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org, mrv@mojatatu.com, dsa@cumulusnetworks.com, davem@davemloft.net On 17/10/27 (金) 19:19, Nikolay Aleksandrov wrote: > Before this patch there was no way to tell if the vlan add operation > actually changed anything, thus we would always generate a notification > on adds. Let's make the notifications more precise and generate them > only if anything changed, so use the new bool parameter to signal that the > vlan was updated. We cannot return an error because there are valid use > cases that will be broken (e.g. overlapping range add) and also we can't > risk masking errors due to calls into drivers for vlan add which can > potentially return anything. > > Signed-off-by: Nikolay Aleksandrov Reviewed-by: Toshiaki Makita Toshiaki Makita