From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve Wise" Subject: RE: [PATCH] RDMA/nes: Adding queue drain functions Date: Mon, 4 Apr 2016 08:54:57 -0500 Message-ID: <01b501d18e79$92ddee20$b899ca60$@opengridcomputing.com> References: <20160329175837.GA9868@TENIKOLO-MOBL2> <046801d189fc$7697f890$63c7e9b0$@opengridcomputing.com> <20160331011902.GC2670@leon.nu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160331011902.GC2670-2ukJVAZIZ/Y@public.gmane.org> Content-Language: en-us Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: leon-2ukJVAZIZ/Y@public.gmane.org Cc: 'Tatyana Nikolova' , 'Doug Ledford' , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, faisal.latif-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org List-Id: linux-rdma@vger.kernel.org > On Tue, Mar 29, 2016 at 03:49:18PM -0500, Steve Wise wrote: > > > > > > Adding sq and rq drain functions, which block until all > > > previously posted wr-s in the specified queue have completed. > > > A completion object is signaled to unblock the thread, > > > when the last cqe for the corresponding queue is processed. > > > > > > Signed-off-by: Tatyana Nikolova > > > Signed-off-by: Faisal Latif > > > > Looks good to me. No locking needed though? > > > > Reviewed-by: Steve Wise > > Steve, > I see that this implementation follows your reference implementation of > iw_cxgb4 which was iWARP specific. Can you point me to the relevant > information which explain why this specific case exists? The iWARP Verbs spec mandates that when the QP is in ERROR, post_send() and post_recv() must, at some point, fail synchronously. See: http://tools.ietf.org/html/draft-hilland-rddp-verbs-00#section-6.2.4 Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html