From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1m5xar-0006n1-Mb for mharc-grub-devel@gnu.org; Tue, 20 Jul 2021 17:48:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5xap-0006ji-Er for grub-devel@gnu.org; Tue, 20 Jul 2021 17:47:59 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:36948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5xan-00074E-V0 for grub-devel@gnu.org; Tue, 20 Jul 2021 17:47:59 -0400 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16KLYdWU106319; Tue, 20 Jul 2021 17:47:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=HrCc6Bd48Y4cihsSUPfYvquqdd7lieD3RCR5fPdc4xc=; b=RyVHiHxD3Un4Td2NhP6BCuqu+CJ+D2DBPeuOX7uR1GjtoSd3c+vPoHzhbNq7DODgVXxl quhGSvS06rameMFeQWgNqA1+Pggh5mTseMYUlY1Z+AhAM1ix4yWDUXK0/kaiTpFxANtx lAvSwlhUkSpYrmU+QqkftizPNg9hvbqMdCvme78vvInqDD3/9WDwo1qjBjtOzs5ktdaM 4VsTAjQEtQFkh+LszbgCqrKUpp5+fyLPnAdmdkb+mTFufkwWAj2s9SLMW2ZJTLI/dvY7 9PNEZWOOj6SY2CWRBV/kpcT+mHsnxgIpYMx08nhjSkY4fqYRQtGtyv7ntrSqbF8z+Xd8 1A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 39wy71yfs6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Jul 2021 17:47:55 -0400 Received: from m0098393.ppops.net (m0098393.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 16KLYqtq107189; Tue, 20 Jul 2021 17:47:55 -0400 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 39wy71yfs0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Jul 2021 17:47:55 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 16KLgRtM031601; Tue, 20 Jul 2021 21:47:54 GMT Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by ppma01dal.us.ibm.com with ESMTP id 39upucnk0x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 20 Jul 2021 21:47:54 +0000 Received: from b03ledav002.gho.boulder.ibm.com (b03ledav002.gho.boulder.ibm.com [9.17.130.233]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 16KLlrO226280358 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 20 Jul 2021 21:47:53 GMT Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 51DDF136051; Tue, 20 Jul 2021 21:47:53 +0000 (GMT) Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EB02713604F; Tue, 20 Jul 2021 21:47:52 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 20 Jul 2021 21:47:52 +0000 (GMT) Subject: Re: [PATCH v2 12/22] libtasn1: disable code not needed in grub To: The development of GNU GRUB , Daniel Axtens Cc: rashmica.g@gmail.com, alastair@d-silva.org, nayna@linux.ibm.com References: <20210630084031.2663622-1-dja@axtens.net> <20210630084031.2663622-13-dja@axtens.net> From: Stefan Berger Message-ID: <01b9a6df-f434-73a4-5905-c8f6734ac2e4@linux.ibm.com> Date: Tue, 20 Jul 2021 17:47:52 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210630084031.2663622-13-dja@axtens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-GUID: qYIlB9zOQY2LBdp2qid3Lsb8pGETOzjA X-Proofpoint-ORIG-GUID: ORCecrHco2mmAS5u9w2RMArlednsY_GE X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-20_14:2021-07-19, 2021-07-20 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 suspectscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 malwarescore=0 adultscore=0 phishscore=0 impostorscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107200134 Received-SPF: pass client-ip=148.163.156.1; envelope-from=stefanb@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2021 21:47:59 -0000 On 6/30/21 4:40 AM, Daniel Axtens wrote: > We don't expect to be able to write ASN.1, only read it, > so we can disable some code. > > Do that with #if 0/#endif, rather than deletion. This means > that the difference between upstream and grub is smaller, > which should make updating libtasn1 easier in the future. > > With these exclusions we also avoid the need for minmax.h, > which is convenient because it means we don't have to > import it from gnulib. > > Signed-off-by: Daniel Axtens Reviewed-by: Stefan Berger