From: "Bob Pearson" <rpearson@systemfabricworks.com>
To: "'Andrew Morton'" <akpm@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>, <fzago@systemfabricworks.com>,
"'Joakim Tjernlund'" <joakim.tjernlund@transmode.se>,
"'George Spelvin'" <linux@horizon.com>
Subject: RE: [PATCH v6 05/10] crc32-misc-cleanup.diff
Date: Tue, 6 Sep 2011 11:05:06 -0500 [thread overview]
Message-ID: <01c101cc6cae$bf219460$3d64bd20$@systemfabricworks.com> (raw)
In-Reply-To: <20110902165047.6aaec238.akpm@linux-foundation.org>
> -----Original Message-----
> From: Andrew Morton [mailto:akpm@linux-foundation.org]
> Sent: Friday, September 02, 2011 6:51 PM
> To: Bob Pearson
> Cc: linux-kernel@vger.kernel.org; fzago@systemfabricworks.com; Joakim
> Tjernlund; George Spelvin
> Subject: Re: [PATCH v6 05/10] crc32-misc-cleanup.diff
>
> On Wed, 31 Aug 2011 17:30:12 -0500
> Bob Pearson <rpearson@systemfabricworks.com> wrote:
>
> > Misc cleanup of lib/crc32.c and related files
> > - removed unnecessary header files.
> > - straightened out some convoluted ifdef's
> > - rewrote some references to 2 dimensional arrays as 1 dimensional
> > arrays to make them correct. I.e. replaced tab[i] with tab[0][i].
> > - a few trivial whitespace changes
> > - fixed a warning in gen_crc32tables.c caused by a mismatch in the
> > type of the pointer passed to output table. Since the table is
> > only used at kernel compile time, it is simpler to make the table
> > big enough to hold the largest column size used. One cannot make
> the
> > column size smaller in output_table because it has to be used by
> > both the le and be tables and they can have different column
sizes.
> >
> > ...
> >
> > --- for-next.orig/lib/crc32.c
> > +++ for-next/lib/crc32.c
> > @@ -23,13 +23,10 @@
> > /* see: Documentation/crc32.txt for a description of algorithms */
> >
> > #include <linux/crc32.h>
> > -#include <linux/kernel.h>
> > #include <linux/module.h>
> > -#include <linux/compiler.h>
> > #include <linux/types.h>
> > -#include <linux/init.h>
> > -#include <asm/atomic.h>
> > #include "crc32defs.h"
>
> I don't like this bit much. Surely there's _something_ in here which
> needs kernel.h, and crc32_init() is marked __init so init.h is
> certainly needed.
>
> Sure, these these things may be accidentally dragged in via nested
> includes but it's bad to depend upon that - such things regularly cause
> breakage when configs are changed.
I tried to copy the usage in other drivers. Happy to oblige.
>
next prev parent reply other threads:[~2011-09-06 16:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110831213729.395283830@systemfabricworks.com>
2011-08-31 22:29 ` [PATCH v6 01/10] crc32-remove-trailing-whitespace.diff Bob Pearson
2011-08-31 22:29 ` [PATCH v6 02/10] crc32-move-to-documentation.diff Bob Pearson
2011-08-31 22:29 ` [PATCH v6 03/10] crc32-replace-self-test.diff Bob Pearson
2011-09-02 23:51 ` Andrew Morton
2011-09-06 16:14 ` Bob Pearson
2011-08-31 22:30 ` [PATCH v6 04/10] crc32-add-pointer-to-tab.diff Bob Pearson
2011-09-01 8:16 ` Joakim Tjernlund
2011-08-31 22:30 ` [PATCH v6 05/10] crc32-misc-cleanup.diff Bob Pearson
2011-09-02 23:50 ` Andrew Morton
2011-09-03 1:44 ` Stephen Rothwell
2011-09-06 13:40 ` Joakim Tjernlund
2011-09-06 14:50 ` Stephen Rothwell
2011-09-06 19:38 ` Andrew Morton
2011-09-06 20:18 ` Bob Pearson
2011-09-07 7:39 ` Joakim Tjernlund
2011-09-07 16:30 ` Bob Pearson
2011-09-07 17:51 ` Joakim Tjernlund
2011-09-06 16:05 ` Bob Pearson [this message]
2011-08-31 22:30 ` [PATCH v6 06/10] crc32-fix-check-endian-warnings.diff Bob Pearson
2011-08-31 22:30 ` [PATCH v6 07/10] crc32-add-real-8-bit.diff Bob Pearson
2011-08-31 22:30 ` [PATCH v6 08/10] crc32-add-slicing-by-8.diff Bob Pearson
2011-09-07 7:31 ` Joakim Tjernlund
2011-09-07 19:44 ` Bob Pearson
[not found] ` <OF3D37A60B.7A33B855-ONC1257904.00276B5B-C1257904.002951AF@LocalDomain>
2011-09-07 8:30 ` Joakim Tjernlund
2011-08-31 22:30 ` [PATCH v6 09/10] crc32-optimize-loops-for-x86.diff Bob Pearson
2011-08-31 22:30 ` [PATCH v6 10/10] crc32-final.diff Bob Pearson
2011-09-01 3:03 ` [PATCH v6 08/10] crc32-add-slicing-by-8.diff Bob Pearson
2011-09-07 7:32 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01c101cc6cae$bf219460$3d64bd20$@systemfabricworks.com' \
--to=rpearson@systemfabricworks.com \
--cc=akpm@linux-foundation.org \
--cc=fzago@systemfabricworks.com \
--cc=joakim.tjernlund@transmode.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.