From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Michael Schmitz <schmitzmic@gmail.com>
Cc: Linux/m68k <linux-m68k@vger.kernel.org>,
Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: [PATCH] m68k/kernel - wire up syscall_trace_enter/leave for m68k
Date: Wed, 26 Aug 2020 13:27:27 +0200 [thread overview]
Message-ID: <01c270ec-cd73-1d7e-0d1a-4ccde66e9d1b@physik.fu-berlin.de> (raw)
In-Reply-To: <CAMuHMdVNqgG_6LSSuzMZekE1q7i_V4YisDJQUsjptLDejNGaRw@mail.gmail.com>
Hi Geert!
On 8/26/20 1:23 PM, Geert Uytterhoeven wrote:
>> Changes from RFC v1:
>>
>> - add return code check in do_trace_entry branch to enable syscall
>> filtering (will return -EPERM)
>> - change to use testl for return code check (suggested by Andreas Schwab)
>>
>> Changes from RFC v2:
>>
>> - don't set return code of filtered syscall - seccomp may want to set
>> that for use by calling process.
>
> As your email subject didn't contain "v3", b4[*] insists on picking up
> RFC v2, and refuses to pick up the latest version, even when forced
> (msgid not present)...
>
> The patch itself looks good to me. Does it make sense to apply it before
> we have real seccomp support?
Adding SECCOMP support itself doesn't take much:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/sh?id=c4637d475170ca0d99973efd07df727012db6cd1
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/sh?id=0bb605c2c7f2b4b314b91510810b226de7f34fa1
Once syscall_trace_entry/leave have been made available, we just need to
add some Kconfig bits and the part which checks the return code of
syscall_trace_enter.
The rest is done by arch-agnostic code.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
next prev parent reply other threads:[~2020-08-26 11:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 10:03 syscall_trace_enter and syscall_trace_leave for m68k w/MMU John Paul Adrian Glaubitz
2020-07-23 22:56 ` Michael Schmitz
2020-07-25 1:48 ` [PATCH RFC] m68k/kernel - wire up syscall_trace_enter/leave for m68k Michael Schmitz
2020-07-26 1:28 ` [PATCH RFC v2] " Michael Schmitz
2020-07-27 4:19 ` [PATCH] " Michael Schmitz
2020-07-27 10:03 ` John Paul Adrian Glaubitz
2020-07-27 20:48 ` Michael Schmitz
2020-07-27 21:09 ` John Paul Adrian Glaubitz
2020-08-26 11:18 ` Geert Uytterhoeven
2020-08-26 11:50 ` John Paul Adrian Glaubitz
2020-08-26 11:23 ` Geert Uytterhoeven
2020-08-26 11:27 ` John Paul Adrian Glaubitz [this message]
2020-08-26 12:32 ` Geert Uytterhoeven
2020-08-26 12:35 ` John Paul Adrian Glaubitz
2020-08-26 12:38 ` Geert Uytterhoeven
2020-08-26 12:42 ` John Paul Adrian Glaubitz
2020-08-26 14:22 ` Geert Uytterhoeven
2020-08-27 0:08 ` Michael Schmitz
2020-08-27 9:19 ` Geert Uytterhoeven
2020-08-27 19:29 ` Michael Schmitz
2020-08-28 8:58 ` Geert Uytterhoeven
2021-06-14 22:11 ` Michael Schmitz
2021-06-14 23:04 ` John Paul Adrian Glaubitz
2021-06-14 23:14 ` Michael Schmitz
2021-06-15 7:51 ` Geert Uytterhoeven
2021-06-15 20:32 ` Michael Schmitz
2021-06-16 0:27 ` Michael Schmitz
2020-08-05 12:23 ` syscall_trace_enter and syscall_trace_leave for m68k w/MMU Greg Ungerer
2020-08-05 12:36 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01c270ec-cd73-1d7e-0d1a-4ccde66e9d1b@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schmitzmic@gmail.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.