From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Joseph, Anoob" <Anoob.Joseph@caviumnetworks.com>
Subject: Re: [PATCH v2 03/33] crypto/octeontx: add PCI probe and
 remove
Date: Mon, 17 Sep 2018 16:08:46 +0530
Message-ID: <01c58bca-9c17-2ed0-8ebf-83319e456174@caviumnetworks.com>
References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com>
 <1536033560-21541-1-git-send-email-ajoseph@caviumnetworks.com>
 <1536033560-21541-4-git-send-email-ajoseph@caviumnetworks.com>
 <c59f457f-4423-94c2-5d1e-451f74df0d59@nxp.com>
 <5d7c6f9e-5865-a356-e1c2-5a85908055a0@caviumnetworks.com>
 <a9cd18b8-e972-0a4c-4abd-f1f43d427cb4@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: Ankur Dwivedi <ankur.dwivedi@caviumnetworks.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 Narayana Prasad <narayanaprasad.athreya@caviumnetworks.com>, dev@dpdk.org,
 Murthy NSSR <nidadavolu.murthy@caviumnetworks.com>,
 Nithin Dabilpuram <nithin.dabilpuram@caviumnetworks.com>,
 Ragothaman Jayaraman <rjayaraman@caviumnetworks.com>,
 Srisivasubramanian S <ssrinivasan@caviumnetworks.com>,
 Tejasree Kondoj <kondoj.tejasree@caviumnetworks.com>
To: Akhil Goyal <akhil.goyal@nxp.com>,
 Anoob Joseph <ajoseph@caviumnetworks.com>,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM05-DM3-obe.outbound.protection.outlook.com
 (mail-eopbgr730064.outbound.protection.outlook.com [40.107.73.64])
 by dpdk.org (Postfix) with ESMTP id 552995689
 for <dev@dpdk.org>; Mon, 17 Sep 2018 12:38:03 +0200 (CEST)
In-Reply-To: <a9cd18b8-e972-0a4c-4abd-f1f43d427cb4@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Akhil,

On 17-09-2018 16:04, Akhil Goyal wrote:
> External Email
>
>>>> +static struct rte_pci_driver otx_cryptodev_pmd = {
>>>> +             .id_table = pci_id_cpt_table,
>>>> +             .drv_flags = RTE_PCI_DRV_NEED_MAPPING,
>>>> +             .probe = otx_cpt_pci_probe,
>>>> +             .remove = otx_cpt_pci_remove,
>>>> +};
>>> remove extra spaces/
>> Between otx_cryptodev_pmd, otx_cryptodev_drv &
>> RTE_INIT(otx_cpt_init_log)? Which all ones you want removed?
> It looks there are 2 tabs for the elements of the above structure.. It
> should be a single tab.
Understood. Will fix it in v3.

Thanks,
Anoob