All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taniya Das <tdas@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>
Cc: David Brown <david.brown@linaro.org>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andy Gross <agross@kernel.org>,
	devicetree@vger.kernel.org, robh@kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH v4 2/4] dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7180
Date: Tue, 21 Jul 2020 22:56:53 +0530	[thread overview]
Message-ID: <01daee94-756d-3970-9057-849de2b76430@codeaurora.org> (raw)
In-Reply-To: <159531791606.3847286.11896325263133276429@swboyd.mtv.corp.google.com>

Hi Stephen,

Thanks for the review.

On 7/21/2020 1:21 PM, Stephen Boyd wrote:

>> +...
>> diff --git a/include/dt-bindings/clock/qcom,gcc-sc7180.h b/include/dt-bindings/clock/qcom,gcc-sc7180.h
>> index 992b67b..bdf43adc 100644
>> --- a/include/dt-bindings/clock/qcom,gcc-sc7180.h
>> +++ b/include/dt-bindings/clock/qcom,gcc-sc7180.h
>> @@ -138,6 +138,7 @@
>>   #define GCC_MSS_Q6_MEMNOC_AXI_CLK                              128
>>   #define GCC_MSS_SNOC_AXI_CLK                                   129
>>   #define GCC_SEC_CTRL_CLK_SRC                                   130
>> +#define GCC_LPASS_CFG_NOC_SWAY_CLK                             131
>>   
>>   /* GCC resets */
>>   #define GCC_QUSB2PHY_PRIM_BCR                                  0
> 
> This hunk should be in the next patch. Oh but then that patch should come
> before this one so the binding can use it. Either way, shouldn't be part
> of this patch.
> 


We had a problem with the bot complaining about the clock handles being 
used in the example.

https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1582540703-6328-4-git-send-email-tdas@codeaurora.org/

Thus I have kept the GCC bindings in the same patch.

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--

  reply	other threads:[~2020-07-21 17:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15  6:36 [PATCH v4 0/4] clk: qcom: Support for Low Power Audio Clocks on SC7180 Taniya Das
2020-07-15  6:36 ` [PATCH v4 1/4] clk: qcom: gdsc: Add support to enable retention of GSDCR Taniya Das
2020-07-15  6:36 ` [PATCH v4 2/4] dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7180 Taniya Das
2020-07-16 19:06   ` Rob Herring
2020-07-21  7:51   ` Stephen Boyd
2020-07-21 17:26     ` Taniya Das [this message]
2020-07-23  1:05       ` Stephen Boyd
2020-07-15  6:36 ` [PATCH v4 3/4] clk: qcom: gcc: Add support for GCC LPASS clock for SC7180 Taniya Das
2020-07-15  6:36 ` [PATCH v4 4/4] clk: qcom: lpass: Add support for LPASS clock controller " Taniya Das
2020-07-21  7:48   ` Stephen Boyd
2020-07-24 16:06     ` Taniya Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01daee94-756d-3970-9057-849de2b76430@codeaurora.org \
    --to=tdas@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.