All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sangbeom Kim <sbkim73@samsung.com>
To: "'Venu Byravarasu'" <vbyravarasu@nvidia.com>,
	sameo@linux.intel.com,
	"'Mark Brown'" <broonie@opensource.wolfsonmicro.com>
Cc: "'Liam Girdwood'" <lrg@ti.com>,
	linux-kernel@vger.kernel.org, sbkim01@gmail.com
Subject: RE: [PATCH V3 3/7] mfd: samsung: Modify samsung mfd header
Date: Fri, 13 Jul 2012 07:30:09 +0900	[thread overview]
Message-ID: <01ed01cd607d$e4f98a30$aeec9e90$@com> (raw)
In-Reply-To: <D958900912E20642BCBC71664EFECE3E6DDB1D61AC@BGMAIL02.nvidia.com>

Hi!
On Wednesday, July 11, 2012 9:30 PM, Venu Byravarasu wrote:

> > + * copyright (c) 2011 Samsung Electronics Co., Ltd
> > + *              http://www.samsung.com
> 
> In most of the files you mentioned 2011.
> Should they not be changed to 2012?

Most of the files are created in 2011.
This file is moved from include/linux/mfd/s5m87xx/s5m-core.h
 
> > -	int				buck_set1;
> > -	int				buck_set2;
> > -	int				buck_set3;
> 
> As you have buck4_enable etc below, by any chance do you need buck_set4 as well here?


No, S5M8767 have 3 controllerble gpios.
The purpose of buck_set1,2,3 is each gpio control.
To handle 3 gpio, I had added buck_set1, buck_set2, buck_set3.

> Similarly should you declare buck1_enable here?


No, gpio control can be enabled on buck2, buck3, buck4.
There is no need buck1_enable.

> > -	int				buck2_enable;
> > -	int				buck3_enable;
> > -	int				buck4_enable;
> > -	int				buck_default_idx;
> > -	int				buck2_default_idx;

Thanks,
Sangbeom.


      reply	other threads:[~2012-07-12 22:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-11 12:07 [PATCH V3 3/7] mfd: samsung: Modify samsung mfd header Sangbeom Kim
2012-07-11 12:30 ` Venu Byravarasu
2012-07-12 22:30   ` Sangbeom Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='01ed01cd607d$e4f98a30$aeec9e90$@com' \
    --to=sbkim73@samsung.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=sameo@linux.intel.com \
    --cc=sbkim01@gmail.com \
    --cc=vbyravarasu@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.