From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAD89C43381 for ; Tue, 26 Mar 2019 01:59:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B828D206BA for ; Tue, 26 Mar 2019 01:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553565575; bh=S+vy7MtkYSeBHrLzIA1nUZYgaiTpzcW96rqj0aBG3Ho=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=OtxK5gUFXM0dNTQTMqCd/JKBUIo8wXFffi7nUZDumn7AkIpcF+z12nl5zEoWLpbmN qA4hfWmSiC7piTP3aIUWdtj6hxQ3zHUikKr2MiOlIyor/i82mSjwNAdqBQZyaoGbI5 BQ644gjCs5pZ5qpxR7ZJ/j6CBN6BUDi1aH2roRVg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730751AbfCZB7e (ORCPT ); Mon, 25 Mar 2019 21:59:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:49884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727043AbfCZB7c (ORCPT ); Mon, 25 Mar 2019 21:59:32 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 74589206BA; Tue, 26 Mar 2019 01:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553565571; bh=S+vy7MtkYSeBHrLzIA1nUZYgaiTpzcW96rqj0aBG3Ho=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=k2DqdBzdeZJJcfOD47um1q3T0EwBzJmvlrXZKM6wu1DxFN/T+7lL+0lervr7BpYMo q5+6VmHRS3tpdYWrYQ4KqcFTMgC1QT0ZcBoR06E9APhF0GFGY5Dy71bnJExJ60tdCg iCmjvKU9nJH59AjmKjsnLcIwuiyrZnvaY0O/0Iz8= Subject: Re: [PATCH] tools: usb: usbip: adding support for older kernel versions To: Brian Norris Cc: David Valleau , LKML , Linux USB Mailing List , Michael Grzeschik , Valentina Manea , Greg Kroah-Hartman , Sasha Levin , shuah References: <20190306214730.6545-1-valleau@chromium.org> <44e151af-b6c4-d0af-3ef1-a5632d079915@kernel.org> <23918a77-2694-fdae-4300-0882c7c940cf@kernel.org> <759fcefa-974b-7430-e7cf-64eabd219d61@kernel.org> From: shuah Message-ID: <01ee061c-bbf5-12f2-8e0e-eda3f9132ad0@kernel.org> Date: Mon, 25 Mar 2019 19:59:30 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/25/19 7:29 PM, Brian Norris wrote: > Hi Shuah, > > On Mon, Mar 25, 2019 at 5:04 PM shuah wrote: >> Agreed. Let's move forward with the assumption that this won't happen >> in the future. > I would amend that to say, unless absolutely necessary. The user exported information is stable after fixing the kernel address pointer leaks. If something pops up that requires changes, I will have to make a call on that. > Great! Are you going to propose a Documentation/ABI/ patch to help > with that? e.g., Documentation/ABI/testing/sysfs-platform-vhci-hcd? > I'm frankly not that familiar with usbip (I'm just trying to help > David out) and might not be the best person for describing the details > exposed here. > ABI will need to documented at some point. :) This driver moved from staging to mainline around 3.18 time frame. So what you are seeing is adaption and enhancements. Some background on this driver might help understand some of the growing pains. :) This is one of the reasons, I strongly recommend not using old tool on new kernels and make sure you are on the latest stable releases. For more details on the nature if security fixes: https://events.linuxfoundation.org/wp-content/uploads/2017/11/One-Small-Step-to-Harden-USB-Over-IP-on-Linux-Shuah-Khan-Samsung-OSG.pdf > And are you planning to try something else to maintain compatibility > pre-[1]? I'm not saying you have to, but you mentioned it and I'd like > to know if we're doing any duplicate work. > 1. I plan to fix the tool to make it run on older kernels (pre-USB 3.0). 2. I don't plan to support old tool running on new kernels. It doesn't make sense considering the security fixes. You can use the latest on older kernels (pre-USB 3.0). 3. I am going to assume you are *using* the latest stable kernels that have the security fixes. thanks, -- Shuah From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: tools: usb: usbip: adding support for older kernel versions From: Shuah Khan Message-Id: <01ee061c-bbf5-12f2-8e0e-eda3f9132ad0@kernel.org> Date: Mon, 25 Mar 2019 19:59:30 -0600 To: Brian Norris Cc: David Valleau , LKML , Linux USB Mailing List , Michael Grzeschik , Valentina Manea , Greg Kroah-Hartman , Sasha Levin , shuah List-ID: T24gMy8yNS8xOSA3OjI5IFBNLCBCcmlhbiBOb3JyaXMgd3JvdGU6Cj4gSGkgU2h1YWgsCj4gCj4g T24gTW9uLCBNYXIgMjUsIDIwMTkgYXQgNTowNCBQTSBzaHVhaCA8c2h1YWhAa2VybmVsLm9yZz4g d3JvdGU6Cj4+IEFncmVlZC4gTGV0J3MgbW92ZSBmb3J3YXJkIHdpdGggdGhlIGFzc3VtcHRpb24g dGhhdCB0aGlzIHdvbid0IGhhcHBlbgo+PiBpbiB0aGUgZnV0dXJlLgo+IAoKSSB3b3VsZCBhbWVu ZCB0aGF0IHRvIHNheSwgdW5sZXNzIGFic29sdXRlbHkgbmVjZXNzYXJ5LiBUaGUgdXNlcgpleHBv cnRlZCBpbmZvcm1hdGlvbiBpcyBzdGFibGUgYWZ0ZXIgZml4aW5nIHRoZSBrZXJuZWwgYWRkcmVz cwpwb2ludGVyIGxlYWtzLiBJZiBzb21ldGhpbmcgcG9wcyB1cCB0aGF0IHJlcXVpcmVzIGNoYW5n ZXMsIEkgd2lsbApoYXZlIHRvIG1ha2UgYSBjYWxsIG9uIHRoYXQuCgo+IEdyZWF0ISBBcmUgeW91 IGdvaW5nIHRvIHByb3Bvc2UgYSBEb2N1bWVudGF0aW9uL0FCSS8gcGF0Y2ggdG8gaGVscAo+IHdp dGggdGhhdD8gZS5nLiwgRG9jdW1lbnRhdGlvbi9BQkkvdGVzdGluZy9zeXNmcy1wbGF0Zm9ybS12 aGNpLWhjZD8KPiBJJ20gZnJhbmtseSBub3QgdGhhdCBmYW1pbGlhciB3aXRoIHVzYmlwIChJJ20g anVzdCB0cnlpbmcgdG8gaGVscAo+IERhdmlkIG91dCkgYW5kIG1pZ2h0IG5vdCBiZSB0aGUgYmVz dCBwZXJzb24gZm9yIGRlc2NyaWJpbmcgdGhlIGRldGFpbHMKPiBleHBvc2VkIGhlcmUuCj4gCgpB Qkkgd2lsbCBuZWVkIHRvIGRvY3VtZW50ZWQgYXQgc29tZSBwb2ludC4gOikgVGhpcyBkcml2ZXIg bW92ZWQgZnJvbQpzdGFnaW5nIHRvIG1haW5saW5lIGFyb3VuZCAzLjE4IHRpbWUgZnJhbWUuIFNv IHdoYXQgeW91IGFyZSBzZWVpbmcgaXMKYWRhcHRpb24gYW5kIGVuaGFuY2VtZW50cy4gU29tZSBi YWNrZ3JvdW5kIG9uIHRoaXMgZHJpdmVyIG1pZ2h0IGhlbHAKdW5kZXJzdGFuZCBzb21lIG9mIHRo ZSBncm93aW5nIHBhaW5zLiA6KSBUaGlzIGlzIG9uZSBvZiB0aGUgcmVhc29ucywKSSBzdHJvbmds eSByZWNvbW1lbmQgbm90IHVzaW5nIG9sZCB0b29sIG9uIG5ldyBrZXJuZWxzIGFuZCBtYWtlIHN1 cmUKeW91IGFyZSBvbiB0aGUgbGF0ZXN0IHN0YWJsZSByZWxlYXNlcy4gRm9yIG1vcmUgZGV0YWls cyBvbiB0aGUgbmF0dXJlCmlmIHNlY3VyaXR5IGZpeGVzOgoKaHR0cHM6Ly9ldmVudHMubGludXhm b3VuZGF0aW9uLm9yZy93cC1jb250ZW50L3VwbG9hZHMvMjAxNy8xMS9PbmUtU21hbGwtU3RlcC10 by1IYXJkZW4tVVNCLU92ZXItSVAtb24tTGludXgtU2h1YWgtS2hhbi1TYW1zdW5nLU9TRy5wZGYK Cj4gQW5kIGFyZSB5b3UgcGxhbm5pbmcgdG8gdHJ5IHNvbWV0aGluZyBlbHNlIHRvIG1haW50YWlu IGNvbXBhdGliaWxpdHkKPiBwcmUtWzFdPyBJJ20gbm90IHNheWluZyB5b3UgaGF2ZSB0bywgYnV0 IHlvdSBtZW50aW9uZWQgaXQgYW5kIEknZCBsaWtlCj4gdG8ga25vdyBpZiB3ZSdyZSBkb2luZyBh bnkgZHVwbGljYXRlIHdvcmsuCj4gCgoxLiBJIHBsYW4gdG8gZml4IHRoZSB0b29sIHRvIG1ha2Ug aXQgcnVuIG9uIG9sZGVyIGtlcm5lbHMgKHByZS1VU0IgMy4wKS4KMi4gSSBkb24ndCBwbGFuIHRv IHN1cHBvcnQgb2xkIHRvb2wgcnVubmluZyBvbiBuZXcga2VybmVscy4gSXQgZG9lc24ndAptYWtl IHNlbnNlIGNvbnNpZGVyaW5nIHRoZSBzZWN1cml0eSBmaXhlcy4gWW91IGNhbiB1c2UgdGhlIGxh dGVzdCBvbgpvbGRlciBrZXJuZWxzIChwcmUtVVNCIDMuMCkuCjMuIEkgYW0gZ29pbmcgdG8gYXNz dW1lIHlvdSBhcmUgKnVzaW5nKiB0aGUgbGF0ZXN0IHN0YWJsZSBrZXJuZWxzIHRoYXQKaGF2ZSB0 aGUgc2VjdXJpdHkgZml4ZXMuCgp0aGFua3MsCi0tIFNodWFoCg==