From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E597C4332F for ; Wed, 19 Oct 2022 13:30:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230460AbiJSNaA (ORCPT ); Wed, 19 Oct 2022 09:30:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232601AbiJSN3H (ORCPT ); Wed, 19 Oct 2022 09:29:07 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E43B9AC28; Wed, 19 Oct 2022 06:16:02 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 37E5C66023AA; Wed, 19 Oct 2022 09:51:09 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666169469; bh=JRrtscYJcgnvP6zoQUoIszeWzHvqEHR17uOuuaKa6uA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MfG6R1OFvTDzIsvmQwazrsJnhSLRTyrtSrgynYi08JlaDlOxOKCPip8RY8pvSiRgN KHb2pqiMn8wrmvIEDU4mM/ucE8/nyn+dbJgdN0muZb0dQ9rgRNqt+jaWTa3riM+zYc wDPK6pXdn/LhiAnQa1pF37+eoFm26xSj+Skk3fR4nVOhtpBldwVO0A3+5i+hhu717Q jj+iXCHioBkax2EtGx12ed0P2XL9JPxMT9+fiu5dPi0El57ERZ/oxru4OxfRB5GGye pf9NGLGTrQ2mEC4wZ3z+qtqmv8BIXMwAtSdLEcv3RrzeHiDI4J0ogl2iIy3WR+CEkN xyzf96mibVOwg== Message-ID: <01ef8a2d-091f-5428-2cb8-41ba3e137a06@collabora.com> Date: Wed, 19 Oct 2022 10:51:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v1 3/3] arm64: dts: mt8195: Add venc node Content-Language: en-US To: Tinghan Shen , Ryder Lee , Jianjun Wang , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Matthias Brugger Cc: linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Irui Wang References: <20221017070858.13902-1-tinghan.shen@mediatek.com> <20221017070858.13902-4-tinghan.shen@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20221017070858.13902-4-tinghan.shen@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 17/10/22 09:08, Tinghan Shen ha scritto: > Add venc node for mt8195 SoC. > > Signed-off-by: Irui Wang > Signed-off-by: Tinghan Shen > --- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > index 903e92d6156f..7cf2f7ef4ec6 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > @@ -2163,6 +2163,30 @@ > power-domains = <&spm MT8195_POWER_DOMAIN_VENC>; > }; > > + venc: venc@1a020000 { As Krzysztof also said, this is video-codec@1a020000. Also, there's one more thing... MT8195 has two video encoder cores, but this node is only for the first one. There's a second instance at 0x1b020000: please add it. Regards, Angelo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61A81C4332F for ; Wed, 19 Oct 2022 08:52:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OUp/85EP6V9ptOg1MNis9EEjc4t+LmFBO66o1QfjQns=; b=Eibtce/DWIB29P TPsOjJuMKxpChDejof/XLaY7TRynGLS4YYx+bRqv0SQyUtE5loWWmJi31vdKhhA/SkFFBIWGtkJKV JubWdycoQe6pSgj44f8+I1DlrS0/dnxivU1mXijVuX9Yq86e/j0GsB44oBrFFWM1cLUR/3mTBeewD C67JDJ9bD2TOnYicSQH5N9TSJz6vZAEIdGVHFno5s4u6OKWWpEQy9BB0w1f0GWBc31XTuO9eAEmm7 qUzOlcJUR5af50W9kTmRi4GIb1+U2g4uJWDObNr1HwpZGlsVh08LEu4Vn7khsZHxLxjhx5ccktICi ZUzaxoXEwb3sxrTan0rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ol4nC-00Gw8h-OZ; Wed, 19 Oct 2022 08:51:14 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ol4n9-00Gw7D-GA; Wed, 19 Oct 2022 08:51:12 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 37E5C66023AA; Wed, 19 Oct 2022 09:51:09 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666169469; bh=JRrtscYJcgnvP6zoQUoIszeWzHvqEHR17uOuuaKa6uA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=MfG6R1OFvTDzIsvmQwazrsJnhSLRTyrtSrgynYi08JlaDlOxOKCPip8RY8pvSiRgN KHb2pqiMn8wrmvIEDU4mM/ucE8/nyn+dbJgdN0muZb0dQ9rgRNqt+jaWTa3riM+zYc wDPK6pXdn/LhiAnQa1pF37+eoFm26xSj+Skk3fR4nVOhtpBldwVO0A3+5i+hhu717Q jj+iXCHioBkax2EtGx12ed0P2XL9JPxMT9+fiu5dPi0El57ERZ/oxru4OxfRB5GGye pf9NGLGTrQ2mEC4wZ3z+qtqmv8BIXMwAtSdLEcv3RrzeHiDI4J0ogl2iIy3WR+CEkN xyzf96mibVOwg== Message-ID: <01ef8a2d-091f-5428-2cb8-41ba3e137a06@collabora.com> Date: Wed, 19 Oct 2022 10:51:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v1 3/3] arm64: dts: mt8195: Add venc node Content-Language: en-US To: Tinghan Shen , Ryder Lee , Jianjun Wang , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Matthias Brugger Cc: linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Irui Wang References: <20221017070858.13902-1-tinghan.shen@mediatek.com> <20221017070858.13902-4-tinghan.shen@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20221017070858.13902-4-tinghan.shen@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221019_015111_724475_CA7D4C29 X-CRM114-Status: GOOD ( 14.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 17/10/22 09:08, Tinghan Shen ha scritto: > Add venc node for mt8195 SoC. > > Signed-off-by: Irui Wang > Signed-off-by: Tinghan Shen > --- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > index 903e92d6156f..7cf2f7ef4ec6 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > @@ -2163,6 +2163,30 @@ > power-domains = <&spm MT8195_POWER_DOMAIN_VENC>; > }; > > + venc: venc@1a020000 { As Krzysztof also said, this is video-codec@1a020000. Also, there's one more thing... MT8195 has two video encoder cores, but this node is only for the first one. There's a second instance at 0x1b020000: please add it. Regards, Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel