From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick DELAUNAY Date: Tue, 8 Dec 2020 18:20:59 +0100 Subject: FW: [PATCH 1/4] ARM: dts: stm32: Enable internal pull-ups for SDMMC1 on DHCOM SoM In-Reply-To: <22668d9b2add43d5bb75f50862baf2f6@SFHDAG2NODE3.st.com> References: <20201201102920.84051-1-marex@denx.de> <22668d9b2add43d5bb75f50862baf2f6@SFHDAG2NODE3.st.com> Message-ID: <01f3a78a-6cb5-560c-63e6-e0b94629e098@foss.st.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, From: Marek Vasut > Sent: mardi 1 d?cembre 2020 11:29 > > The default state of SD bus and clock line is logical HI. SD card IO is open-drain and pulls the bus lines LO. Always enable the SD bus pull ups to guarantee this behavior on DHCOM SoM. Note that on SoMs with SD bus voltage level shifter, the pull ups are built into the level shifter, however that has no negative impact. > > Signed-off-by: Marek Vasut > Cc: Patrice Chotard > Cc: Patrick Delaunay > --- > arch/arm/dts/stm32mp15xx-dhcom.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm/dts/stm32mp15xx-dhcom.dtsi b/arch/arm/dts/stm32mp15xx-dhcom.dtsi > index f022d8395c..9049245c5b 100644 > --- a/arch/arm/dts/stm32mp15xx-dhcom.dtsi > +++ b/arch/arm/dts/stm32mp15xx-dhcom.dtsi > @@ -339,6 +339,20 @@ > status = "okay"; > }; > > +&sdmmc1_b4_pins_a { > + /* > + * SD bus pull-up resistors: > + * - optional on SoMs with SD voltage translator > + * - mandatory on SoMs without SD voltage translator > + */ > + pins1 { > + bias-pull-up; > + }; > + pins2 { > + bias-pull-up; > + }; > +}; > + > &sdmmc2 { > pinctrl-names = "default"; > pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_a>; > -- > 2.29.2 > Reviewed-by: Patrick Delaunay For the serie:? the target is next or it is a bugfix for master / v2021.01 ? Thanks Patrick