From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AA53C43334 for ; Wed, 8 Jun 2022 09:46:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6643D10E1AE; Wed, 8 Jun 2022 09:46:08 +0000 (UTC) Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by gabe.freedesktop.org (Postfix) with ESMTPS id CCE6810E350 for ; Wed, 8 Jun 2022 09:46:06 +0000 (UTC) Received: by mail-lj1-x233.google.com with SMTP id b12so11124820ljq.3 for ; Wed, 08 Jun 2022 02:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=yOxlrq/fVxPT2FiIBOKVYPAfqctXd+eFiAOIP5/2A9I=; b=tK6MPAKdwAPFIty4ejAYcTThkcFkg/1Oh2+ATxAdMGPqIubvJ4BszTL5490txOQko0 +PVeYN/aF8p1zjmZEyecBoSOBdq6BnbKqlsAd5XcPOvq2iAhvkncnuSOutXrWrRwpkvy kuBhZ/YNus4Jp0+0a8sc9Vm6vA8lXiN6Hp2aB2ngoss94TCPww+yD9SdUl1dhRinWL4E 8egiPVOAgFz2JvbgFC1GJFzYuGWARYCELyFVL0URhmMwPoa36DY1FwGYNsxhZ2BSnW1e lgL7RhMx67ojhUFnbEU+ty3aID7kBOwCPB+n5Zm9IGYCFySewMIuEfX6rExi3PLPmvlJ pioQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=yOxlrq/fVxPT2FiIBOKVYPAfqctXd+eFiAOIP5/2A9I=; b=nw1U7jiQmmtTqW4GSsQot7LvEUstt5Ycu71R+ScYKcz4kJMuPAXV6ig1d3/UxZZpyo 2wsigU56Ir9sIGnQOtUdjXeewAFi3NkuPnOiEEkZCCff6pZw05w+/4Zvy+Go3Lz3kewa 7l97Fc1VqdPwWAziuKg1a+YVH6L4kqnRaNSnKT5F/rrZuCXKJhey0A/2121faJX8KxFk sRZadhVO4lZbDG/G6SQKz8cI1Sh/G4/j0WtYGhvquOtX4VyTBCKstuwTzeA83JvXlY9H TLYXqM+OZr3NUNKiBcdNDP9cOFTRbtcD4qksHirJe+uWq3CYUqwm4mps9Fl0INqng13n 6WmA== X-Gm-Message-State: AOAM533ZDtWdoXemVNj32FngoqWYNHsJOxJIW1Ogz9dK27KPO7DCX/uL exFdsoo5DKwKjVudK2T2/cft7w== X-Google-Smtp-Source: ABdhPJy5CV6jmqkNgx7+BORI++6FNMcw3VxWhdwVuW4GJRDqmVWkWjcqfQoqVS8RufTt3xWoWEXfGQ== X-Received: by 2002:a05:651c:1a21:b0:255:e727:78cd with SMTP id by33-20020a05651c1a2100b00255e72778cdmr787682ljb.232.1654681564933; Wed, 08 Jun 2022 02:46:04 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id d25-20020a056512369900b0047255d21114sm3643588lfs.67.2022.06.08.02.46.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jun 2022 02:46:04 -0700 (PDT) Message-ID: <0209dce1-5c3b-1d2b-0241-f58fbfe17ea8@linaro.org> Date: Wed, 8 Jun 2022 12:46:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v1 1/7] dt-bindings: display/msm: hdmi: split and convert to yaml Content-Language: en-GB To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar , Rob Herring , Krzysztof Kozlowski References: <20220607185806.2771739-1-dmitry.baryshkov@linaro.org> <20220607185806.2771739-2-dmitry.baryshkov@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , David Heidelberg , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 08/06/2022 11:58, Krzysztof Kozlowski wrote: > On 07/06/2022 20:58, Dmitry Baryshkov wrote: >> Convert Qualcomm HDMI binding into HDMI TX and PHY yaml bindings. >> >> Changes to schema: >> HDMI: >> - fixed reg-names numbering to match 0..3 instead 0,1,3,4 >> >> PHY: >> - moved into phy/ directory >> - split into QMP and non-QMP PHY schemas >> >> Co-developed-by: David Heidelberg >> Signed-off-by: Dmitry Baryshkov >> --- >> .../devicetree/bindings/display/msm/hdmi.txt | 99 -------- >> .../bindings/display/msm/qcom,hdmi.yaml | 237 ++++++++++++++++++ >> .../bindings/phy/qcom,hdmi-phy-other.yaml | 103 ++++++++ >> .../bindings/phy/qcom,hdmi-phy-qmp.yaml | 84 +++++++ >> 4 files changed, 424 insertions(+), 99 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/display/msm/hdmi.txt >> create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,hdmi.yaml >> create mode 100644 Documentation/devicetree/bindings/phy/qcom,hdmi-phy-other.yaml >> create mode 100644 Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml >> >> diff --git a/Documentation/devicetree/bindings/display/msm/hdmi.txt b/Documentation/devicetree/bindings/display/msm/hdmi.txt >> deleted file mode 100644 >> index 5f90a40da51b..000000000000 >> --- a/Documentation/devicetree/bindings/display/msm/hdmi.txt >> +++ /dev/null >> @@ -1,99 +0,0 @@ >> -Qualcomm adreno/snapdragon hdmi output >> - >> -Required properties: >> -- compatible: one of the following >> - * "qcom,hdmi-tx-8996" >> - * "qcom,hdmi-tx-8994" >> - * "qcom,hdmi-tx-8084" >> - * "qcom,hdmi-tx-8974" >> - * "qcom,hdmi-tx-8660" >> - * "qcom,hdmi-tx-8960" >> -- reg: Physical base address and length of the controller's registers >> -- reg-names: "core_physical" >> -- interrupts: The interrupt signal from the hdmi block. >> -- power-domains: Should be <&mmcc MDSS_GDSC>. >> -- clocks: device clocks >> - See ../clocks/clock-bindings.txt for details. >> -- core-vdda-supply: phandle to supply regulator >> -- hdmi-mux-supply: phandle to mux regulator >> -- phys: the phandle for the HDMI PHY device >> -- phy-names: the name of the corresponding PHY device >> - >> -Optional properties: >> -- hpd-gpios: hpd pin >> -- qcom,hdmi-tx-mux-en-gpios: hdmi mux enable pin >> -- qcom,hdmi-tx-mux-sel-gpios: hdmi mux select pin >> -- qcom,hdmi-tx-mux-lpm-gpios: hdmi mux lpm pin >> -- power-domains: reference to the power domain(s), if available. >> -- pinctrl-names: the pin control state names; should contain "default" >> -- pinctrl-0: the default pinctrl state (active) >> -- pinctrl-1: the "sleep" pinctrl state >> - >> -HDMI PHY: >> -Required properties: >> -- compatible: Could be the following >> - * "qcom,hdmi-phy-8660" >> - * "qcom,hdmi-phy-8960" >> - * "qcom,hdmi-phy-8974" >> - * "qcom,hdmi-phy-8084" >> - * "qcom,hdmi-phy-8996" >> -- #phy-cells: Number of cells in a PHY specifier; Should be 0. >> -- reg: Physical base address and length of the registers of the PHY sub blocks. >> -- reg-names: The names of register regions. The following regions are required: >> - * "hdmi_phy" >> - * "hdmi_pll" >> - For HDMI PHY on msm8996, these additional register regions are required: >> - * "hdmi_tx_l0" >> - * "hdmi_tx_l1" >> - * "hdmi_tx_l3" >> - * "hdmi_tx_l4" >> -- power-domains: Should be <&mmcc MDSS_GDSC>. >> -- clocks: device clocks >> - See Documentation/devicetree/bindings/clock/clock-bindings.txt for details. >> -- core-vdda-supply: phandle to vdda regulator device node >> - >> -Example: >> - >> -/ { >> - ... >> - >> - hdmi: hdmi@4a00000 { >> - compatible = "qcom,hdmi-tx-8960"; >> - reg-names = "core_physical"; >> - reg = <0x04a00000 0x2f0>; >> - interrupts = ; >> - power-domains = <&mmcc MDSS_GDSC>; >> - clock-names = >> - "core", >> - "master_iface", >> - "slave_iface"; >> - clocks = >> - <&mmcc HDMI_APP_CLK>, >> - <&mmcc HDMI_M_AHB_CLK>, >> - <&mmcc HDMI_S_AHB_CLK>; >> - qcom,hdmi-tx-ddc-clk = <&msmgpio 70 GPIO_ACTIVE_HIGH>; >> - qcom,hdmi-tx-ddc-data = <&msmgpio 71 GPIO_ACTIVE_HIGH>; >> - qcom,hdmi-tx-hpd = <&msmgpio 72 GPIO_ACTIVE_HIGH>; >> - core-vdda-supply = <&pm8921_hdmi_mvs>; >> - hdmi-mux-supply = <&ext_3p3v>; >> - pinctrl-names = "default", "sleep"; >> - pinctrl-0 = <&hpd_active &ddc_active &cec_active>; >> - pinctrl-1 = <&hpd_suspend &ddc_suspend &cec_suspend>; >> - >> - phys = <&hdmi_phy>; >> - phy-names = "hdmi_phy"; >> - }; >> - >> - hdmi_phy: phy@4a00400 { >> - compatible = "qcom,hdmi-phy-8960"; >> - reg-names = "hdmi_phy", >> - "hdmi_pll"; >> - reg = <0x4a00400 0x60>, >> - <0x4a00500 0x100>; >> - #phy-cells = <0>; >> - power-domains = <&mmcc MDSS_GDSC>; >> - clock-names = "slave_iface"; >> - clocks = <&mmcc HDMI_S_AHB_CLK>; >> - core-vdda-supply = <&pm8921_hdmi_mvs>; >> - }; >> -}; >> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,hdmi.yaml b/Documentation/devicetree/bindings/display/msm/qcom,hdmi.yaml >> new file mode 100644 >> index 000000000000..2f485b5d1c5d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/msm/qcom,hdmi.yaml >> @@ -0,0 +1,237 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> + >> +$id: "http://devicetree.org/schemas/display/msm/qcom,hdmi.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > Both go without quotes. > >> + >> +title: Qualcomm Adreno/Snapdragon HDMI output >> + >> +maintainers: >> + - Rob Clark >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,hdmi-tx-8660 >> + - qcom,hdmi-tx-8960 >> + - qcom,hdmi-tx-8974 >> + - qcom,hdmi-tx-8084 >> + - qcom,hdmi-tx-8994 >> + - qcom,hdmi-tx-8996 > > Could you order them alphabetically? Helps to avoid conflicts, if ever > extended. I ordered them 'logically' (basing on the generation). But I'll change the order. > >> + >> + clocks: >> + minItems: 1 >> + maxItems: 5 >> + >> + clock-names: >> + minItems: 1 >> + maxItems: 5 >> + >> + reg: >> + minItems: 1 >> + maxItems: 3 >> + description: Physical base address and length of the controller's registers > > Skip description, it's obvious. > >> + >> + reg-names: >> + minItems: 1 >> + items: >> + - const: core_physical >> + - const: qfprom_physical >> + - const: hdcp_physical >> + >> + interrupts: >> + maxItems: 1 >> + description: The interrupt signal from the hdmi block. > > Skip description, it's obvious. > >> + >> + phys: >> + description: the phandle for the HDMI PHY device > > You can skip description, it's quite obvious... Also in some places > description is first in the property, in some last. Just keep one choice. :) > >> + maxItems: 1 >> + >> + phy-names: >> + enum: >> + - hdmi_phy >> + - hdmi-phy > > Fix the DTS and use only one. Do the drivers actually use it? No, the driver just looks for the first phy entry. Should we mark phy-names as deprecated and remove its usage from actual DTs? > >> + >> + hpd-gpios: >> + maxItems: 1 >> + description: hpd pin >> + >> + qcom,hdmi-tx-ddc-clk-gpios: >> + maxItems: 1 >> + description: HDMI DDC clock >> + >> + qcom,hdmi-tx-ddc-data-gpios: >> + maxItems: 1 >> + description: HDMI DDC data >> + >> + qcom,hdmi-tx-mux-en-gpios: >> + maxItems: 1 >> + description: HDMI mux enable pin > > These were not documented before, so mention that in the commit msg, please. Fun. qcom,hdmi-tx-mux-* were documented (but not used anywhere) qcom,hdmi-tx-ddc-* were not documented, but were present in the example. > >> + >> + qcom,hdmi-tx-mux-sel-gpios: >> + maxItems: 1 >> + description: HDMI mux select pin >> + >> + qcom,hdmi-tx-mux-lpm-gpios: >> + maxItems: 1 >> + description: HDMI mux lpm pin >> + >> + '#sound-dai-cells': >> + const: 1 >> + >> + ports: >> + type: object >> + $ref: /schemas/graph.yaml#/properties/ports >> + properties: >> + port@0: >> + $ref: /schemas/graph.yaml#/$defs/port-base >> + description: | >> + Input endpoints of the controller. >> + >> + port@1: >> + $ref: /schemas/graph.yaml#/$defs/port-base >> + description: | >> + Output endpoints of the controller. >> + >> + required: >> + - port@0 >> + >> +required: >> + - compatible >> + - clocks >> + - clock-names >> + - reg >> + - reg-names >> + - interrupts >> + - phys >> + - phy-names >> + >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,hdmi-tx-8960 >> + then: >> + properties: >> + clocks: >> + minItems: 3 >> + maxItems: 3 >> + clock-names: >> + items: >> + - const: core >> + - const: master_iface >> + - const: slave_iface >> + core-vdda-supply: >> + description: phandle to VDDA supply regulator >> + hdmi-mux-supply: >> + description: phandle to mux regulator >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,hdmi-tx-8974 >> + - qcom,hdmi-tx-8084 >> + - qcom,hdmi-tx-8994 >> + - qcom,hdmi-tx-8996 >> + then: >> + properties: >> + clocks: >> + minItems: 5 >> + clock-names: >> + items: >> + - const: mdp_core >> + - const: iface >> + - const: core >> + - const: alt_iface >> + - const: extp >> + core-vdda-supply: >> + description: phandle to VDDA supply regulator >> + core-vcc-supply: >> + description: phandle to VCC supply regulator >> + >> +unevaluatedProperties: false > > This should be additionalProperties:false, because you do not reference > any schema. If it fails on supplies, please define the supplies in the > properties list (not in the allOf:if:then) and disallow it on chosen > variant (only one I guess)... if the supplies are really not possible on > that variant. The supplies are variant-specific, thus I wanted to define them in the conditional clauses. But I see your point, I'll change it. > >> + >> +examples: >> + - | >> + hdmi: hdmi@4a00000 { >> + compatible = "qcom,hdmi-tx-8960"; >> + reg-names = "core_physical"; >> + reg = <0x04a00000 0x2f0>; >> + interrupts = <0 79 0>; > > Use proper defines for GIC and flags. IRQ TYPE none is not correct usually. Ack > >> + clock-names = >> + "core", >> + "master_iface", >> + "slave_iface"; > > clock-names = "core", > (and align continued lines) > > >> + clocks = >> + <&clk 61>, >> + <&clk 72>, >> + <&clk 98>; >> + qcom,hdmi-tx-ddc-clk-gpios = <&msmgpio 70 0>; >> + qcom,hdmi-tx-ddc-data-gpios = <&msmgpio 71 0>; >> + hpd-gpios = <&msmgpio 72 0>; > > Proper GPIO flags. > >> + core-vdda-supply = <&pm8921_hdmi_mvs>; >> + hdmi-mux-supply = <&ext_3p3v>; >> + pinctrl-names = "default", "sleep"; >> + pinctrl-0 = <&hpd_active &ddc_active &cec_active>; >> + pinctrl-1 = <&hpd_suspend &ddc_suspend &cec_suspend>; >> + >> + phys = <&hdmi_phy>; >> + phy-names = "hdmi_phy"; >> + }; >> + - | >> + #include >> + #include >> + #include >> + #include >> + hdmi-tx@9a0000 { > > Node name just "hdmi" > >> + compatible = "qcom,hdmi-tx-8996"; >> + reg = <0x009a0000 0x50c>, >> + <0x00070000 0x6158>, >> + <0x009e0000 0xfff>; >> + reg-names = "core_physical", >> + "qfprom_physical", >> + "hdcp_physical"; >> + >> + interrupt-parent = <&mdss>; >> + interrupts = <8 IRQ_TYPE_LEVEL_HIGH>; >> + >> + clocks = <&mmcc MDSS_MDP_CLK>, >> + <&mmcc MDSS_AHB_CLK>, >> + <&mmcc MDSS_HDMI_CLK>, >> + <&mmcc MDSS_HDMI_AHB_CLK>, >> + <&mmcc MDSS_EXTPCLK_CLK>; >> + clock-names = "mdp_core", >> + "iface", >> + "core", >> + "alt_iface", >> + "extp"; >> + >> + phys = <&hdmi_phy>; >> + phy-names = "hdmi_phy"; >> + #sound-dai-cells = <1>; >> + >> + pinctrl-names = "default", "sleep"; >> + pinctrl-0 = <&hdmi_hpd_active &hdmi_ddc_active>; >> + pinctrl-1 = <&hdmi_hpd_suspend &hdmi_ddc_suspend>; >> + >> + core-vdda-supply = <&vreg_l12a_1p8>; >> + core-vcc-supply = <&vreg_s4a_1p8>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + endpoint { >> + remote-endpoint = <&mdp5_intf3_out>; >> + }; >> + }; >> + }; >> + }; >> +... >> diff --git a/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-other.yaml b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-other.yaml >> new file mode 100644 >> index 000000000000..79193cf71828 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-other.yaml >> @@ -0,0 +1,103 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> + >> +$id: "http://devicetree.org/schemas/phy/qcom,hdmi-phy-other.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > Same comment > >> + >> +title: Qualcomm Adreno/Snapdragon HDMI phy >> + >> +maintainers: >> + - Rob Clark >> + >> +properties: >> + compatible: >> + contains: > > Remove contains > >> + enum: >> + - qcom,hdmi-phy-8660 >> + - qcom,hdmi-phy-8960 >> + - qcom,hdmi-phy-8974 >> + - qcom,hdmi-phy-8084 >> + >> + reg: >> + minItems: 2 >> + maxItems: 2 > > maxItems is enough in such case > >> + >> + reg-names: >> + items: >> + - const: hdmi_phy >> + - const: hdmi_pll >> + >> + clocks: >> + minItems: 1 >> + maxItems: 2 >> + >> + clock-names: >> + minItems: 1 >> + maxItems: 2 >> + >> + power-domains: >> + maxItems: 1 >> + >> + '#phy-cells': >> + const: 0 >> + >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,hdmi-phy-8960 >> + then: >> + properties: >> + clocks: >> + maxItems: 1 >> + clock-names: >> + items: >> + - const: slave_iface >> + core-vdda-supply: >> + description: phandle to VDDA supply regulator >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,hdmi-phy-8974 >> + then: >> + properties: >> + clocks: >> + maxItems: 2 >> + clock-names: >> + items: >> + - const: iface >> + - const: alt_iface >> + core-vdda-supply: >> + description: phandle to VDDA supply regulator >> + vddio-supply: >> + description: phandle to VDD I/O supply regulator >> + > > What are the clocks for other variants? Also between 1-2 with any name? As you asked about it... 8084 is an alias for 8974, so I'll add it here. As for the 8660... It doesn't declare any clocks, so I'll have to move this requirement to an if clause. Or maybe just split 8660 away. > >> +required: >> + - compatible >> + - clocks >> + - reg >> + - reg-names >> + - '#phy-cells' >> + >> +unevaluatedProperties: false > > additionalProperties:false > >> + >> +examples: >> + - | >> + hdmi_phy: phy@4a00400 { >> + compatible = "qcom,hdmi-phy-8960"; >> + reg-names = "hdmi_phy", >> + "hdmi_pll"; >> + reg = <0x4a00400 0x60>, >> + <0x4a00500 0x100>; >> + #phy-cells = <0>; >> + power-domains = <&mmcc 1>; >> + clock-names = "slave_iface"; >> + clocks = <&clk 21>; >> + core-vdda-supply = <&pm8921_hdmi_mvs>; >> + }; >> diff --git a/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml >> new file mode 100644 >> index 000000000000..2b36a4c3d4c3 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml >> @@ -0,0 +1,84 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> + >> +$id: "http://devicetree.org/schemas/phy/qcom,hdmi-phy-qmp.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > Same comment > >> + >> +title: Qualcomm Adreno/Snapdragon QMP HDMI phy >> + >> +maintainers: >> + - Rob Clark >> + >> +properties: >> + compatible: >> + contains: > > Remove contains >> + enum: >> + - qcom,hdmi-phy-8996 >> + >> + reg: >> + maxItems: 6 >> + >> + reg-names: >> + items: >> + - const: hdmi_pll >> + - const: hdmi_tx_l0 >> + - const: hdmi_tx_l1 >> + - const: hdmi_tx_l2 >> + - const: hdmi_tx_l3 >> + - const: hdmi_phy >> + >> + clocks: >> + maxItems: 2 >> + >> + clock-names: >> + items: >> + - const: iface >> + - const: ref >> + >> + power-domains: >> + maxItems: 1 >> + >> + vcca-supply: true >> + >> + vddio-supply: true >> + >> + '#phy-cells': >> + const: 0 >> + >> +required: >> + - compatible >> + - clocks >> + - clock-names >> + - reg >> + - reg-names >> + - '#phy-cells' >> + >> +unevaluatedProperties: false > > additionalProperties:false > >> + >> +examples: >> + - | >> + hdmi-phy@9a0600 { > > > Best regards, > Krzysztof -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E5FDCCA47F for ; Wed, 8 Jun 2022 10:04:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235742AbiFHKEi (ORCPT ); Wed, 8 Jun 2022 06:04:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235878AbiFHKDJ (ORCPT ); Wed, 8 Jun 2022 06:03:09 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9C3A1673E6 for ; Wed, 8 Jun 2022 02:46:06 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id v9so22088996lja.12 for ; Wed, 08 Jun 2022 02:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=yOxlrq/fVxPT2FiIBOKVYPAfqctXd+eFiAOIP5/2A9I=; b=tK6MPAKdwAPFIty4ejAYcTThkcFkg/1Oh2+ATxAdMGPqIubvJ4BszTL5490txOQko0 +PVeYN/aF8p1zjmZEyecBoSOBdq6BnbKqlsAd5XcPOvq2iAhvkncnuSOutXrWrRwpkvy kuBhZ/YNus4Jp0+0a8sc9Vm6vA8lXiN6Hp2aB2ngoss94TCPww+yD9SdUl1dhRinWL4E 8egiPVOAgFz2JvbgFC1GJFzYuGWARYCELyFVL0URhmMwPoa36DY1FwGYNsxhZ2BSnW1e lgL7RhMx67ojhUFnbEU+ty3aID7kBOwCPB+n5Zm9IGYCFySewMIuEfX6rExi3PLPmvlJ pioQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=yOxlrq/fVxPT2FiIBOKVYPAfqctXd+eFiAOIP5/2A9I=; b=hgs2MQmDeIDwlQZBOqD/2q6mjvOtZQy8erlakWJQN4aetH3JEADFtcRQCdd66JT9nx k1X9NUmYJNiEwGG8f0suViKnA8silGcG4dbhQwair358OtyeiwBmnkfrZ+TIsqtTHfFo 0I6bke1doxPVrIeIdb0mdbTwrtGUg3yzNvN4qq9MZ4zkkw+711x97lBrgfhz2DYInycp RA7g6viBMUZOCFujKP8RSEvL2qdlUI251rtRUO+YWMGEYi8Py/szeACXVds+jvlRscjK 04gT7ekHZoA4Dsagiqlv30q7F4UkBe+uKnmpyH5xEPtUEPzxWGqdJMV0p9YZlJ2nFp8u lmuA== X-Gm-Message-State: AOAM531s/uLWcEcfrevRFuPMTp4fxMJ8JccRwxBokV3piUvROm9rP4uP aS+TM6QyxQlgtVpPyiLma1DbmA== X-Google-Smtp-Source: ABdhPJy5CV6jmqkNgx7+BORI++6FNMcw3VxWhdwVuW4GJRDqmVWkWjcqfQoqVS8RufTt3xWoWEXfGQ== X-Received: by 2002:a05:651c:1a21:b0:255:e727:78cd with SMTP id by33-20020a05651c1a2100b00255e72778cdmr787682ljb.232.1654681564933; Wed, 08 Jun 2022 02:46:04 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id d25-20020a056512369900b0047255d21114sm3643588lfs.67.2022.06.08.02.46.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jun 2022 02:46:04 -0700 (PDT) Message-ID: <0209dce1-5c3b-1d2b-0241-f58fbfe17ea8@linaro.org> Date: Wed, 8 Jun 2022 12:46:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v1 1/7] dt-bindings: display/msm: hdmi: split and convert to yaml Content-Language: en-GB To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar , Rob Herring , Krzysztof Kozlowski Cc: Stephen Boyd , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, David Heidelberg References: <20220607185806.2771739-1-dmitry.baryshkov@linaro.org> <20220607185806.2771739-2-dmitry.baryshkov@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 08/06/2022 11:58, Krzysztof Kozlowski wrote: > On 07/06/2022 20:58, Dmitry Baryshkov wrote: >> Convert Qualcomm HDMI binding into HDMI TX and PHY yaml bindings. >> >> Changes to schema: >> HDMI: >> - fixed reg-names numbering to match 0..3 instead 0,1,3,4 >> >> PHY: >> - moved into phy/ directory >> - split into QMP and non-QMP PHY schemas >> >> Co-developed-by: David Heidelberg >> Signed-off-by: Dmitry Baryshkov >> --- >> .../devicetree/bindings/display/msm/hdmi.txt | 99 -------- >> .../bindings/display/msm/qcom,hdmi.yaml | 237 ++++++++++++++++++ >> .../bindings/phy/qcom,hdmi-phy-other.yaml | 103 ++++++++ >> .../bindings/phy/qcom,hdmi-phy-qmp.yaml | 84 +++++++ >> 4 files changed, 424 insertions(+), 99 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/display/msm/hdmi.txt >> create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,hdmi.yaml >> create mode 100644 Documentation/devicetree/bindings/phy/qcom,hdmi-phy-other.yaml >> create mode 100644 Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml >> >> diff --git a/Documentation/devicetree/bindings/display/msm/hdmi.txt b/Documentation/devicetree/bindings/display/msm/hdmi.txt >> deleted file mode 100644 >> index 5f90a40da51b..000000000000 >> --- a/Documentation/devicetree/bindings/display/msm/hdmi.txt >> +++ /dev/null >> @@ -1,99 +0,0 @@ >> -Qualcomm adreno/snapdragon hdmi output >> - >> -Required properties: >> -- compatible: one of the following >> - * "qcom,hdmi-tx-8996" >> - * "qcom,hdmi-tx-8994" >> - * "qcom,hdmi-tx-8084" >> - * "qcom,hdmi-tx-8974" >> - * "qcom,hdmi-tx-8660" >> - * "qcom,hdmi-tx-8960" >> -- reg: Physical base address and length of the controller's registers >> -- reg-names: "core_physical" >> -- interrupts: The interrupt signal from the hdmi block. >> -- power-domains: Should be <&mmcc MDSS_GDSC>. >> -- clocks: device clocks >> - See ../clocks/clock-bindings.txt for details. >> -- core-vdda-supply: phandle to supply regulator >> -- hdmi-mux-supply: phandle to mux regulator >> -- phys: the phandle for the HDMI PHY device >> -- phy-names: the name of the corresponding PHY device >> - >> -Optional properties: >> -- hpd-gpios: hpd pin >> -- qcom,hdmi-tx-mux-en-gpios: hdmi mux enable pin >> -- qcom,hdmi-tx-mux-sel-gpios: hdmi mux select pin >> -- qcom,hdmi-tx-mux-lpm-gpios: hdmi mux lpm pin >> -- power-domains: reference to the power domain(s), if available. >> -- pinctrl-names: the pin control state names; should contain "default" >> -- pinctrl-0: the default pinctrl state (active) >> -- pinctrl-1: the "sleep" pinctrl state >> - >> -HDMI PHY: >> -Required properties: >> -- compatible: Could be the following >> - * "qcom,hdmi-phy-8660" >> - * "qcom,hdmi-phy-8960" >> - * "qcom,hdmi-phy-8974" >> - * "qcom,hdmi-phy-8084" >> - * "qcom,hdmi-phy-8996" >> -- #phy-cells: Number of cells in a PHY specifier; Should be 0. >> -- reg: Physical base address and length of the registers of the PHY sub blocks. >> -- reg-names: The names of register regions. The following regions are required: >> - * "hdmi_phy" >> - * "hdmi_pll" >> - For HDMI PHY on msm8996, these additional register regions are required: >> - * "hdmi_tx_l0" >> - * "hdmi_tx_l1" >> - * "hdmi_tx_l3" >> - * "hdmi_tx_l4" >> -- power-domains: Should be <&mmcc MDSS_GDSC>. >> -- clocks: device clocks >> - See Documentation/devicetree/bindings/clock/clock-bindings.txt for details. >> -- core-vdda-supply: phandle to vdda regulator device node >> - >> -Example: >> - >> -/ { >> - ... >> - >> - hdmi: hdmi@4a00000 { >> - compatible = "qcom,hdmi-tx-8960"; >> - reg-names = "core_physical"; >> - reg = <0x04a00000 0x2f0>; >> - interrupts = ; >> - power-domains = <&mmcc MDSS_GDSC>; >> - clock-names = >> - "core", >> - "master_iface", >> - "slave_iface"; >> - clocks = >> - <&mmcc HDMI_APP_CLK>, >> - <&mmcc HDMI_M_AHB_CLK>, >> - <&mmcc HDMI_S_AHB_CLK>; >> - qcom,hdmi-tx-ddc-clk = <&msmgpio 70 GPIO_ACTIVE_HIGH>; >> - qcom,hdmi-tx-ddc-data = <&msmgpio 71 GPIO_ACTIVE_HIGH>; >> - qcom,hdmi-tx-hpd = <&msmgpio 72 GPIO_ACTIVE_HIGH>; >> - core-vdda-supply = <&pm8921_hdmi_mvs>; >> - hdmi-mux-supply = <&ext_3p3v>; >> - pinctrl-names = "default", "sleep"; >> - pinctrl-0 = <&hpd_active &ddc_active &cec_active>; >> - pinctrl-1 = <&hpd_suspend &ddc_suspend &cec_suspend>; >> - >> - phys = <&hdmi_phy>; >> - phy-names = "hdmi_phy"; >> - }; >> - >> - hdmi_phy: phy@4a00400 { >> - compatible = "qcom,hdmi-phy-8960"; >> - reg-names = "hdmi_phy", >> - "hdmi_pll"; >> - reg = <0x4a00400 0x60>, >> - <0x4a00500 0x100>; >> - #phy-cells = <0>; >> - power-domains = <&mmcc MDSS_GDSC>; >> - clock-names = "slave_iface"; >> - clocks = <&mmcc HDMI_S_AHB_CLK>; >> - core-vdda-supply = <&pm8921_hdmi_mvs>; >> - }; >> -}; >> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,hdmi.yaml b/Documentation/devicetree/bindings/display/msm/qcom,hdmi.yaml >> new file mode 100644 >> index 000000000000..2f485b5d1c5d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/msm/qcom,hdmi.yaml >> @@ -0,0 +1,237 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> + >> +$id: "http://devicetree.org/schemas/display/msm/qcom,hdmi.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > Both go without quotes. > >> + >> +title: Qualcomm Adreno/Snapdragon HDMI output >> + >> +maintainers: >> + - Rob Clark >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,hdmi-tx-8660 >> + - qcom,hdmi-tx-8960 >> + - qcom,hdmi-tx-8974 >> + - qcom,hdmi-tx-8084 >> + - qcom,hdmi-tx-8994 >> + - qcom,hdmi-tx-8996 > > Could you order them alphabetically? Helps to avoid conflicts, if ever > extended. I ordered them 'logically' (basing on the generation). But I'll change the order. > >> + >> + clocks: >> + minItems: 1 >> + maxItems: 5 >> + >> + clock-names: >> + minItems: 1 >> + maxItems: 5 >> + >> + reg: >> + minItems: 1 >> + maxItems: 3 >> + description: Physical base address and length of the controller's registers > > Skip description, it's obvious. > >> + >> + reg-names: >> + minItems: 1 >> + items: >> + - const: core_physical >> + - const: qfprom_physical >> + - const: hdcp_physical >> + >> + interrupts: >> + maxItems: 1 >> + description: The interrupt signal from the hdmi block. > > Skip description, it's obvious. > >> + >> + phys: >> + description: the phandle for the HDMI PHY device > > You can skip description, it's quite obvious... Also in some places > description is first in the property, in some last. Just keep one choice. :) > >> + maxItems: 1 >> + >> + phy-names: >> + enum: >> + - hdmi_phy >> + - hdmi-phy > > Fix the DTS and use only one. Do the drivers actually use it? No, the driver just looks for the first phy entry. Should we mark phy-names as deprecated and remove its usage from actual DTs? > >> + >> + hpd-gpios: >> + maxItems: 1 >> + description: hpd pin >> + >> + qcom,hdmi-tx-ddc-clk-gpios: >> + maxItems: 1 >> + description: HDMI DDC clock >> + >> + qcom,hdmi-tx-ddc-data-gpios: >> + maxItems: 1 >> + description: HDMI DDC data >> + >> + qcom,hdmi-tx-mux-en-gpios: >> + maxItems: 1 >> + description: HDMI mux enable pin > > These were not documented before, so mention that in the commit msg, please. Fun. qcom,hdmi-tx-mux-* were documented (but not used anywhere) qcom,hdmi-tx-ddc-* were not documented, but were present in the example. > >> + >> + qcom,hdmi-tx-mux-sel-gpios: >> + maxItems: 1 >> + description: HDMI mux select pin >> + >> + qcom,hdmi-tx-mux-lpm-gpios: >> + maxItems: 1 >> + description: HDMI mux lpm pin >> + >> + '#sound-dai-cells': >> + const: 1 >> + >> + ports: >> + type: object >> + $ref: /schemas/graph.yaml#/properties/ports >> + properties: >> + port@0: >> + $ref: /schemas/graph.yaml#/$defs/port-base >> + description: | >> + Input endpoints of the controller. >> + >> + port@1: >> + $ref: /schemas/graph.yaml#/$defs/port-base >> + description: | >> + Output endpoints of the controller. >> + >> + required: >> + - port@0 >> + >> +required: >> + - compatible >> + - clocks >> + - clock-names >> + - reg >> + - reg-names >> + - interrupts >> + - phys >> + - phy-names >> + >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,hdmi-tx-8960 >> + then: >> + properties: >> + clocks: >> + minItems: 3 >> + maxItems: 3 >> + clock-names: >> + items: >> + - const: core >> + - const: master_iface >> + - const: slave_iface >> + core-vdda-supply: >> + description: phandle to VDDA supply regulator >> + hdmi-mux-supply: >> + description: phandle to mux regulator >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,hdmi-tx-8974 >> + - qcom,hdmi-tx-8084 >> + - qcom,hdmi-tx-8994 >> + - qcom,hdmi-tx-8996 >> + then: >> + properties: >> + clocks: >> + minItems: 5 >> + clock-names: >> + items: >> + - const: mdp_core >> + - const: iface >> + - const: core >> + - const: alt_iface >> + - const: extp >> + core-vdda-supply: >> + description: phandle to VDDA supply regulator >> + core-vcc-supply: >> + description: phandle to VCC supply regulator >> + >> +unevaluatedProperties: false > > This should be additionalProperties:false, because you do not reference > any schema. If it fails on supplies, please define the supplies in the > properties list (not in the allOf:if:then) and disallow it on chosen > variant (only one I guess)... if the supplies are really not possible on > that variant. The supplies are variant-specific, thus I wanted to define them in the conditional clauses. But I see your point, I'll change it. > >> + >> +examples: >> + - | >> + hdmi: hdmi@4a00000 { >> + compatible = "qcom,hdmi-tx-8960"; >> + reg-names = "core_physical"; >> + reg = <0x04a00000 0x2f0>; >> + interrupts = <0 79 0>; > > Use proper defines for GIC and flags. IRQ TYPE none is not correct usually. Ack > >> + clock-names = >> + "core", >> + "master_iface", >> + "slave_iface"; > > clock-names = "core", > (and align continued lines) > > >> + clocks = >> + <&clk 61>, >> + <&clk 72>, >> + <&clk 98>; >> + qcom,hdmi-tx-ddc-clk-gpios = <&msmgpio 70 0>; >> + qcom,hdmi-tx-ddc-data-gpios = <&msmgpio 71 0>; >> + hpd-gpios = <&msmgpio 72 0>; > > Proper GPIO flags. > >> + core-vdda-supply = <&pm8921_hdmi_mvs>; >> + hdmi-mux-supply = <&ext_3p3v>; >> + pinctrl-names = "default", "sleep"; >> + pinctrl-0 = <&hpd_active &ddc_active &cec_active>; >> + pinctrl-1 = <&hpd_suspend &ddc_suspend &cec_suspend>; >> + >> + phys = <&hdmi_phy>; >> + phy-names = "hdmi_phy"; >> + }; >> + - | >> + #include >> + #include >> + #include >> + #include >> + hdmi-tx@9a0000 { > > Node name just "hdmi" > >> + compatible = "qcom,hdmi-tx-8996"; >> + reg = <0x009a0000 0x50c>, >> + <0x00070000 0x6158>, >> + <0x009e0000 0xfff>; >> + reg-names = "core_physical", >> + "qfprom_physical", >> + "hdcp_physical"; >> + >> + interrupt-parent = <&mdss>; >> + interrupts = <8 IRQ_TYPE_LEVEL_HIGH>; >> + >> + clocks = <&mmcc MDSS_MDP_CLK>, >> + <&mmcc MDSS_AHB_CLK>, >> + <&mmcc MDSS_HDMI_CLK>, >> + <&mmcc MDSS_HDMI_AHB_CLK>, >> + <&mmcc MDSS_EXTPCLK_CLK>; >> + clock-names = "mdp_core", >> + "iface", >> + "core", >> + "alt_iface", >> + "extp"; >> + >> + phys = <&hdmi_phy>; >> + phy-names = "hdmi_phy"; >> + #sound-dai-cells = <1>; >> + >> + pinctrl-names = "default", "sleep"; >> + pinctrl-0 = <&hdmi_hpd_active &hdmi_ddc_active>; >> + pinctrl-1 = <&hdmi_hpd_suspend &hdmi_ddc_suspend>; >> + >> + core-vdda-supply = <&vreg_l12a_1p8>; >> + core-vcc-supply = <&vreg_s4a_1p8>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + endpoint { >> + remote-endpoint = <&mdp5_intf3_out>; >> + }; >> + }; >> + }; >> + }; >> +... >> diff --git a/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-other.yaml b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-other.yaml >> new file mode 100644 >> index 000000000000..79193cf71828 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-other.yaml >> @@ -0,0 +1,103 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> + >> +$id: "http://devicetree.org/schemas/phy/qcom,hdmi-phy-other.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > Same comment > >> + >> +title: Qualcomm Adreno/Snapdragon HDMI phy >> + >> +maintainers: >> + - Rob Clark >> + >> +properties: >> + compatible: >> + contains: > > Remove contains > >> + enum: >> + - qcom,hdmi-phy-8660 >> + - qcom,hdmi-phy-8960 >> + - qcom,hdmi-phy-8974 >> + - qcom,hdmi-phy-8084 >> + >> + reg: >> + minItems: 2 >> + maxItems: 2 > > maxItems is enough in such case > >> + >> + reg-names: >> + items: >> + - const: hdmi_phy >> + - const: hdmi_pll >> + >> + clocks: >> + minItems: 1 >> + maxItems: 2 >> + >> + clock-names: >> + minItems: 1 >> + maxItems: 2 >> + >> + power-domains: >> + maxItems: 1 >> + >> + '#phy-cells': >> + const: 0 >> + >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,hdmi-phy-8960 >> + then: >> + properties: >> + clocks: >> + maxItems: 1 >> + clock-names: >> + items: >> + - const: slave_iface >> + core-vdda-supply: >> + description: phandle to VDDA supply regulator >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,hdmi-phy-8974 >> + then: >> + properties: >> + clocks: >> + maxItems: 2 >> + clock-names: >> + items: >> + - const: iface >> + - const: alt_iface >> + core-vdda-supply: >> + description: phandle to VDDA supply regulator >> + vddio-supply: >> + description: phandle to VDD I/O supply regulator >> + > > What are the clocks for other variants? Also between 1-2 with any name? As you asked about it... 8084 is an alias for 8974, so I'll add it here. As for the 8660... It doesn't declare any clocks, so I'll have to move this requirement to an if clause. Or maybe just split 8660 away. > >> +required: >> + - compatible >> + - clocks >> + - reg >> + - reg-names >> + - '#phy-cells' >> + >> +unevaluatedProperties: false > > additionalProperties:false > >> + >> +examples: >> + - | >> + hdmi_phy: phy@4a00400 { >> + compatible = "qcom,hdmi-phy-8960"; >> + reg-names = "hdmi_phy", >> + "hdmi_pll"; >> + reg = <0x4a00400 0x60>, >> + <0x4a00500 0x100>; >> + #phy-cells = <0>; >> + power-domains = <&mmcc 1>; >> + clock-names = "slave_iface"; >> + clocks = <&clk 21>; >> + core-vdda-supply = <&pm8921_hdmi_mvs>; >> + }; >> diff --git a/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml >> new file mode 100644 >> index 000000000000..2b36a4c3d4c3 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-qmp.yaml >> @@ -0,0 +1,84 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> + >> +$id: "http://devicetree.org/schemas/phy/qcom,hdmi-phy-qmp.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > Same comment > >> + >> +title: Qualcomm Adreno/Snapdragon QMP HDMI phy >> + >> +maintainers: >> + - Rob Clark >> + >> +properties: >> + compatible: >> + contains: > > Remove contains >> + enum: >> + - qcom,hdmi-phy-8996 >> + >> + reg: >> + maxItems: 6 >> + >> + reg-names: >> + items: >> + - const: hdmi_pll >> + - const: hdmi_tx_l0 >> + - const: hdmi_tx_l1 >> + - const: hdmi_tx_l2 >> + - const: hdmi_tx_l3 >> + - const: hdmi_phy >> + >> + clocks: >> + maxItems: 2 >> + >> + clock-names: >> + items: >> + - const: iface >> + - const: ref >> + >> + power-domains: >> + maxItems: 1 >> + >> + vcca-supply: true >> + >> + vddio-supply: true >> + >> + '#phy-cells': >> + const: 0 >> + >> +required: >> + - compatible >> + - clocks >> + - clock-names >> + - reg >> + - reg-names >> + - '#phy-cells' >> + >> +unevaluatedProperties: false > > additionalProperties:false > >> + >> +examples: >> + - | >> + hdmi-phy@9a0600 { > > > Best regards, > Krzysztof -- With best wishes Dmitry